-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[App Service] az functionapp create
: Add --zone-redundant
parameter to support zone redundant for Functions Flex SKU
#29984
Merged
+74
−4
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
55e8258
Adding --zone-redundant flag for flex
khkh-ms 87305a9
Return the object not just JSON
khkh-ms 3be4e8c
Fixed the style issues. No other code change.
khkh-ms a312d6c
removed the plan changes
khkh-ms 89c4dee
Removed the new method for zone-redundancy and using the existing one.
khkh-ms 0c11958
Removed an unused methof after the recent change of requirements.
khkh-ms 73cba31
Adding --zone-redundant flag for flex in flex location list command
khkh-ms 3e34fb9
minor change in the string
khkh-ms d55124a
updated messages to address the review comments
khkh-ms f959e1b
passing null for worker-count so that it always uses the default
khkh-ms b01ad39
updated a couple of messages to address the review comments
khkh-ms 2d22796
updated a couple of messages to address the review comments
khkh-ms 689a28d
Resolved the style error
khkh-ms 65c597e
added the unit tests
khkh-ms 0463aaf
renames variables
khkh-ms File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens when this API call fails? Does the operation fail or the method return no locations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API errors are surfaced to users in cli. The user will be able to see the actual error message from the backend. User can use
--debug
flag for further details for the API requests/responses.