[Internal] Documentation: Add notes and test for memory optimization #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealsur
requested review from
FabianMeiswinkel,
j82w,
kirankumarkolli and
kirillg
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please follow the required format: "[Internal] Category: (Add|Fix|Refactor) Description"
Examples:
Diagnostics: Add GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fix null reference when using default(PartitionKey)
[v4] Client Encryption: Refactor code to external project
[Internal] Query: Add code generator for CosmosNumbers for easy additions in the future.
ealsur
changed the title
FabianMeiswinkel
approved these changes
Apr 17, 2020
j82w
approved these changes
Apr 17, 2020
j82w
added a commit
that referenced
this pull request
Apr 21, 2020
* Bump direct version 3.9.0 * [Internal] Documentation: Add notes and test for memory optimization (#1399) * add test for memorybuffer * changelog * Diagnostics: Add CPU monitoring for .Net Core (#1400) * [Internal] Diagnostics: Add Cpu monitoring for .Net Core * [Internal] Diagnostics: Add Cpu monitoring for .Net Core CI test coverage * Diagnostics: Add Cpu monitoring for .Net Core Diagnostics: Add Cpu monitoring for .Net Core * [Internal]: Diagnostics: Fix for unit tests to address code review comments * Diagnostics: Add CPU monitoring for .Net Core (#1402) * [Internal] Diagnostics: Add Cpu monitoring for .Net Core * [Internal] Diagnostics: Add Cpu monitoring for .Net Core CI test coverage * Diagnostics: Add Cpu monitoring for .Net Core Diagnostics: Add Cpu monitoring for .Net Core * [Internal]: Diagnostics: Fix for unit tests to address code review comments * Update changelog.md Co-authored-by: Matias Quaranta <ealsur@users.noreply.github.com> Co-authored-by: Fabian Meiswinkel <fabianm@microsoft.com>
j82w
added a commit
that referenced
this pull request
Apr 21, 2020
* [Internal] Documentation: Fix text on retry builder extension (#1388) * Autoscale: Fix ThroughputProperties factory names (#1392) * Changed CreateFixedOffer to CreateManualOffer to matcht the portal * Updated contract docs * Fixed contract to use preview version * CreateAutoscaleProvionedThroughput to CreateAutoscaleThroughput * Removed redundant throughput * Updated naming again * Update contract * Client Encryption : Add nuget info to Encryption csproj and compile against preview SDK (#1385) * Add nuget info to Encryption csproj and compile against preview SDK * Remove SourceLink related property unless we need it at first go * Encryption versioning independent of client * Set 3.8.0-preview as minimum client version that would be referenced by Encryption assembly * Add back PREVIEW constant * Internal Query: Add logic to execute some queries as Passthrough when possible (#1319) * added passthrough code path * added another condition * added some sanity tests * moved passthrough creation into pipeline * added test injections to observe whether the query is passthrough or not * missed case where query has top, order by, offset limit * resolved iteration comments * fixed nullable check * fixed typo * [Preview] Change Feed: Add FeedRange and continuation separate (#1355) FeedRange and continuation separate * [Internal] Pipeline: Add Microsoft.Azure.Cosmos.Encryption release pipeline (#1403) * encryption pipeline * removing cred check * Fix path * Apply suggestions from code review Co-Authored-By: j82w <j82w@users.noreply.github.com> Co-authored-by: j82w <j82w@users.noreply.github.com> * [Internal] Direct Version: Add direct version 3.9.0 (#1398) * Bump direct version 3.9.0 * [Internal] Documentation: Add notes and test for memory optimization (#1399) * add test for memorybuffer * changelog * Diagnostics: Add CPU monitoring for .Net Core (#1400) * [Internal] Diagnostics: Add Cpu monitoring for .Net Core * [Internal] Diagnostics: Add Cpu monitoring for .Net Core CI test coverage * Diagnostics: Add Cpu monitoring for .Net Core Diagnostics: Add Cpu monitoring for .Net Core * [Internal]: Diagnostics: Fix for unit tests to address code review comments * Diagnostics: Add CPU monitoring for .Net Core (#1402) * [Internal] Diagnostics: Add Cpu monitoring for .Net Core * [Internal] Diagnostics: Add Cpu monitoring for .Net Core CI test coverage * Diagnostics: Add Cpu monitoring for .Net Core Diagnostics: Add Cpu monitoring for .Net Core * [Internal]: Diagnostics: Fix for unit tests to address code review comments * Update changelog.md Co-authored-by: Matias Quaranta <ealsur@users.noreply.github.com> Co-authored-by: Fabian Meiswinkel <fabianm@microsoft.com> * Fixed changelog and updated api Co-authored-by: Matias Quaranta <ealsur@users.noreply.github.com> Co-authored-by: abhijitpai <abpai@microsoft.com> Co-authored-by: Brandon Chong <bchong95@users.noreply.github.com> Co-authored-by: Fabian Meiswinkel <fabianm@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Direct 3.9.0 brings MemoryStream with TryGetBuffer support on DocumentServiceResponse, which benefits any code path that uses TryGetBuffer on the response Content to avoid Array allocations, like the query CosmosElementSerializer (https://github.com/Azure/azure-cosmos-dotnet-v3/blob/master/Microsoft.Azure.Cosmos/src/CosmosElements/CosmosElementSerializer.cs#L84). It should yield a reduced memory allocation and reduced CPU (due to less GC work).
Type of change