Diagnostics: Add CPU monitoring for .Net Core #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diagnostics: Add Cpu monitoring for .Net Core
FabianMeiswinkel
requested review from
ealsur,
j82w,
kirankumarkolli and
kirillg
as code owners
j82w
reviewed
Apr 20, 2020
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/TransportWrapperTests.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/TransportWrapperTests.cs
Outdated
Show resolved
Hide resolved
FabianMeiswinkel
changed the base branch from
master
to
users/jawilley/direct/3.9.0
j82w
added a commit
that referenced
this pull request
Apr 21, 2020
* Bump direct version 3.9.0 * [Internal] Documentation: Add notes and test for memory optimization (#1399) * add test for memorybuffer * changelog * Diagnostics: Add CPU monitoring for .Net Core (#1400) * [Internal] Diagnostics: Add Cpu monitoring for .Net Core * [Internal] Diagnostics: Add Cpu monitoring for .Net Core CI test coverage * Diagnostics: Add Cpu monitoring for .Net Core Diagnostics: Add Cpu monitoring for .Net Core * [Internal]: Diagnostics: Fix for unit tests to address code review comments * Diagnostics: Add CPU monitoring for .Net Core (#1402) * [Internal] Diagnostics: Add Cpu monitoring for .Net Core * [Internal] Diagnostics: Add Cpu monitoring for .Net Core CI test coverage * Diagnostics: Add Cpu monitoring for .Net Core Diagnostics: Add Cpu monitoring for .Net Core * [Internal]: Diagnostics: Fix for unit tests to address code review comments * Update changelog.md Co-authored-by: Matias Quaranta <ealsur@users.noreply.github.com> Co-authored-by: Fabian Meiswinkel <fabianm@microsoft.com>
j82w
added a commit
that referenced
this pull request
Apr 21, 2020
* [Internal] Documentation: Fix text on retry builder extension (#1388) * Autoscale: Fix ThroughputProperties factory names (#1392) * Changed CreateFixedOffer to CreateManualOffer to matcht the portal * Updated contract docs * Fixed contract to use preview version * CreateAutoscaleProvionedThroughput to CreateAutoscaleThroughput * Removed redundant throughput * Updated naming again * Update contract * Client Encryption : Add nuget info to Encryption csproj and compile against preview SDK (#1385) * Add nuget info to Encryption csproj and compile against preview SDK * Remove SourceLink related property unless we need it at first go * Encryption versioning independent of client * Set 3.8.0-preview as minimum client version that would be referenced by Encryption assembly * Add back PREVIEW constant * Internal Query: Add logic to execute some queries as Passthrough when possible (#1319) * added passthrough code path * added another condition * added some sanity tests * moved passthrough creation into pipeline * added test injections to observe whether the query is passthrough or not * missed case where query has top, order by, offset limit * resolved iteration comments * fixed nullable check * fixed typo * [Preview] Change Feed: Add FeedRange and continuation separate (#1355) FeedRange and continuation separate * [Internal] Pipeline: Add Microsoft.Azure.Cosmos.Encryption release pipeline (#1403) * encryption pipeline * removing cred check * Fix path * Apply suggestions from code review Co-Authored-By: j82w <j82w@users.noreply.github.com> Co-authored-by: j82w <j82w@users.noreply.github.com> * [Internal] Direct Version: Add direct version 3.9.0 (#1398) * Bump direct version 3.9.0 * [Internal] Documentation: Add notes and test for memory optimization (#1399) * add test for memorybuffer * changelog * Diagnostics: Add CPU monitoring for .Net Core (#1400) * [Internal] Diagnostics: Add Cpu monitoring for .Net Core * [Internal] Diagnostics: Add Cpu monitoring for .Net Core CI test coverage * Diagnostics: Add Cpu monitoring for .Net Core Diagnostics: Add Cpu monitoring for .Net Core * [Internal]: Diagnostics: Fix for unit tests to address code review comments * Diagnostics: Add CPU monitoring for .Net Core (#1402) * [Internal] Diagnostics: Add Cpu monitoring for .Net Core * [Internal] Diagnostics: Add Cpu monitoring for .Net Core CI test coverage * Diagnostics: Add Cpu monitoring for .Net Core Diagnostics: Add Cpu monitoring for .Net Core * [Internal]: Diagnostics: Fix for unit tests to address code review comments * Update changelog.md Co-authored-by: Matias Quaranta <ealsur@users.noreply.github.com> Co-authored-by: Fabian Meiswinkel <fabianm@microsoft.com> * Fixed changelog and updated api Co-authored-by: Matias Quaranta <ealsur@users.noreply.github.com> Co-authored-by: abhijitpai <abpai@microsoft.com> Co-authored-by: Brandon Chong <bchong95@users.noreply.github.com> Co-authored-by: Fabian Meiswinkel <fabianm@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Pull Request Title
Format
[Internal] Category: (Add|Fix) DescriptionExample
Diagnostics: Add GetElapsedClientLatency to CosmosDiagnosticsPartitionKey: Fix null reference when using default(PartitionKey)[Internal] Query: Add code generator for CosmosNumbers for easy additions in the future.Description
Consuming the latest Direct.dll which contains the changes to support CpuMonitor on .Net Core. Also adding a unit test to close the CI coverage gap (no test was validating that TransportExceptions contained any CPU history yet)
Type of change
Please delete options that are not relevant.
Closing issues
Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).
Assignee
FabianMeiswinkel
Projects
Please add relevant projects so this issue can be properly tracked.