Internal Query: Adds adoption of pagination lib #1812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sboshra
approved these changes
Oct 5, 2020
sboshra
approved these changes
Oct 5, 2020
This was referenced Mar 8, 2021
Merged
1 task
|
Closing due to in-activity, pease feel free to re-open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal Query: Adds adoption of pagination lib
Description
This code migrates the query code to use the new pagination lib. Everything is now part of a query pipeline, which is shown in the QueryPipelineStage class. Some internal benefits is that this code is now fully exceptionless and one ExecuteNextAsync call will correspond to a single fetch of a backend page. This was possible by reworking ORDER BY to have state similar to GROUP BY. At the beginning MoveNext will trigger a single item producer to fetch from the backend and move that item producer from an uninitalized to initalized state. We stall the pipeline back returning an empty page with the corresponding query metrics. This makes the pipeline more responsive and we can handle exceptions easier.
For testing all the pipeline stages are now fully testable without the need for an emulator and with the addition of a query parser and offline engine we are able to run full end to end queries without the need of an emulator for testing.