Query: Fixes TaskCanceledException being converted to InternalServerError and losing diagnostics #2424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j82w
requested review from
ealsur,
FabianMeiswinkel,
khdang,
kirankumarkolli,
kirillg,
leminh98,
neildsh and
sboshra
as code owners
j82w
changed the title
neildsh
previously approved these changes
Apr 23, 2021
ealsur
previously approved these changes
Apr 23, 2021
ealsur
approved these changes
Apr 23, 2021
neildsh
approved these changes
Apr 23, 2021
This was referenced Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This fixes a regression introduced by the pagination library where query is incorrectly converting operation cancelled exceptions into InternalServerErrors, and then does not include the diagnostics. Query now throws the expected CosmosOperationCancelledException which is an OperationCancellationTokenException with CosmosDiagnostics. This PR adds baseline tests, so we can assert the behavior.
Type of change
Please delete options that are not relevant.
Closing issues
closes ##2065 Introduced in 3.14.0 in #1812