Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.18.1-preview: Adds release notes and ports hotfixes for query #2532

Merged
merged 3 commits into from
Jun 14, 2021

Conversation

ealsur
Copy link
Member

@ealsur ealsur commented Jun 11, 2021

Cherry-pick of:

#2510
#2531

Into 3.18.0-preview release branch

neildsh and others added 2 commits June 11, 2021 11:57
…#2510)

* Add support to FlakyDocumentContainer send back 410s based on a delegate

* Fix bug in CrossPartitionRangePageAsyncEnumerator where we dont handle a merge to a single partition

* Fix InvalidOperationException on merge to single partition in OrderByCrossPartitionQueryPipelineStage

* Incorporate CR feedback

* more CR feedback

Co-authored-by: Samer Boshra <sboshra@microsoft.com>
* fix

* fixing inmemorycontainer

* fixing merge test

* undo small change

* OrderBy fix too

* Correct orderby handling

* more tests

* text

Co-authored-by: j82w <j82w@users.noreply.github.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors) Description"

Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.

@@ -147,12 +147,8 @@ public async ValueTask<bool> MoveNextAsync(ITrace trace)
currentPaginator.FeedRangeState.FeedRange,
childTrace,
this.cancellationToken);
if (childRanges.Count == 0)
Copy link
Contributor

@j82w j82w Jun 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we include the following fixes so the diagnostics are actually useful?
#2424
#2375

j82w
j82w previously approved these changes Jun 11, 2021
@j82w j82w changed the title 3.18.1-preview release notes 3.18.1-preview: Add release notes and ports hotfixes for query Jun 11, 2021
@j82w j82w changed the title 3.18.1-preview: Add release notes and ports hotfixes for query 3.18.1-preview: Adds release notes and ports hotfixes for query Jun 11, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors) Description"

Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.

@github-actions github-actions bot dismissed stale reviews from themself June 11, 2021 19:33

All good!

…ent Encryption Policy is not allowed via ReplaceContainer (#2349)

Adds / updates existing tests to verify -
a. Update of Client Encryption Policy is not allowed via ReplaceContainer
b. CreateContainer request ensures that the ClientEncryptionKey exists when creating Client Encryption Policy
@kirankumarkolli kirankumarkolli merged commit e303be9 into releases/3.18.1-preview Jun 14, 2021
@kirankumarkolli kirankumarkolli deleted the users/ealsur3181release branch June 14, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants