-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query: Fixes DllNotFoundException when running on Windows/x64 #3226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j82w
reviewed
Jun 1, 2022
ealsur
requested review from
kirillg,
kirankumarkolli,
FabianMeiswinkel,
khdang,
sboshra,
neildsh and
leminh98
as code owners
June 1, 2022 16:48
kirankumarkolli
approved these changes
Jun 1, 2022
j82w
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR changes the behavior of the SDK on Windows/x64 scenarios when the ServiceInterop.dll is not available.
Currently when it is not available, we throw:
Customers can only fix this by correctly placing the ServiceInterop.dll and its dependencies, on the expected folder (same as SDK DLL).
There are however, some customers for which this is impossible due to deployment constraints (for example, they cannot deploy or pack native DLLs like ServiceInterop).
Proposed solution
This is one of the proposed solutions in #3225 - Automatic fallback.
The SDK will now automatically fallback to Gateway mode if the DLLs are not available on Windows x64.
This obviously poses a latency/performance issue for the user.
This PR adds this information on the diagnostics:
Which with the right documentation enables users (and automation) to detect the case and understand how to mitigate it (copy the DLLs) if possible. If they can't, they are not broken, but know what is the reason.
Closing issues
Closes #3225
Closes #2366