FeedRange: Fixes a NullRef in FeedRangePartitionKey.ToString() #3480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramarag
requested review from
khdang,
adityasa,
neildsh,
kirankumarkolli,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
ramarag
force-pushed
the
users/ramarag/fixReadFeedOfFixedCollection
branch
from
4dd6898
to
a056ea1
Compare
ealsur
changed the title
ealsur
reviewed
Sep 30, 2022
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/ClientTests.cs
Outdated
Show resolved
Hide resolved
…tionKey.ToString()
ramarag
force-pushed
the
users/ramarag/fixReadFeedOfFixedCollection
branch
from
a056ea1
to
84c111f
Compare
ealsur
approved these changes
Oct 3, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
FeedRangePartitionKey.ToString() results in a Null Ref Exception if we give PartitionKey.None
This change checks for PartitionKey.None and returns a valid string. The ToString is used for internal tracing
The issue surfaces when we try to do a ReadFeed with PartitionKey.None
Type of change
Please delete options that are not relevant.