Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PartitionKey: Fixes NullRef in toString handling for None for PartitionKey.ToString() #3498

Merged
merged 4 commits into from
Oct 11, 2022

Conversation

dochollidayxx
Copy link
Contributor

Pull Request Template

Description

Missing ToString() handling for PartitionKey.None results in NullRef Exception as opposed to more useful content. Breaks some logging scenarios. Identified by @ray2k.

This bugfix is similar to the one merged from: #3480

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Closing issues

@ray2k
Copy link

ray2k commented Oct 11, 2022

Obligatory comment to boost visibility on this if possible. This breaks any kind of instrumentation that logs partition keys which is annoying to work around.

@ealsur
Copy link
Member

ealsur commented Oct 11, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ealsur
Copy link
Member

ealsur commented Oct 11, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ealsur ealsur merged commit f679c3b into Azure:master Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants