PartitionKey: Fixes NullRef in toString handling for None for PartitionKey.ToString() #3498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dochollidayxx
requested review from
khdang,
adityasa,
neildsh,
kirankumarkolli,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
|
Obligatory comment to boost visibility on this if possible. This breaks any kind of instrumentation that logs partition keys which is annoying to work around. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kirankumarkolli
previously approved these changes
Oct 11, 2022
ealsur
reviewed
Oct 11, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ealsur
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Missing ToString() handling for PartitionKey.None results in NullRef Exception as opposed to more useful content. Breaks some logging scenarios. Identified by @ray2k.
This bugfix is similar to the one merged from: #3480
Type of change
Please delete options that are not relevant.
Closing issues