-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Internal] ContainerProperties: Adds Vector Embedding and Indexing Policy #4379
Merged
ealsur
merged 20 commits into
master
from
users/kundadebdatta/4364_vector_index_add_collection_properties
Apr 5, 2024
Merged
[Internal] ContainerProperties: Adds Vector Embedding and Indexing Policy #4379
ealsur
merged 20 commits into
master
from
users/kundadebdatta/4364_vector_index_add_collection_properties
Apr 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…collection_properties
…collection_properties
kundadebdatta
changed the title
ContainerProperties: Adds Vector Embedding Policy
ContainerProperties: Adds Vector Embedding and Indexing Policy
Apr 1, 2024
kundadebdatta
commented
Apr 1, 2024
kundadebdatta
requested review from
a team,
khdang,
sboshra,
adityasa,
neildsh,
kirankumarkolli,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
April 1, 2024 22:32
ealsur
reviewed
Apr 2, 2024
Microsoft.Azure.Cosmos/src/Fluent/Settings/VectorEmbeddingPolicyDefinition.cs
Outdated
Show resolved
Hide resolved
...oft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Fluent/ContainerSettingsTests.cs
Show resolved
Hide resolved
ealsur
reviewed
Apr 2, 2024
Microsoft.Azure.Cosmos/src/Fluent/Settings/VectorIndexDefinition.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Apr 2, 2024
ealsur
reviewed
Apr 2, 2024
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/CosmosContainerSettingsTests.cs
Show resolved
Hide resolved
ealsur
reviewed
Apr 2, 2024
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/SettingsContractTests.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Apr 2, 2024
FabianMeiswinkel
previously approved these changes
Apr 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…collection_properties
...oft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Fluent/ContainerSettingsTests.cs
Show resolved
Hide resolved
kundadebdatta
dismissed stale reviews from FabianMeiswinkel and ealsur
via
April 5, 2024 19:15
55e3735
kirankumarkolli
previously approved these changes
Apr 5, 2024
ealsur
previously approved these changes
Apr 5, 2024
FabianMeiswinkel
previously approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kundadebdatta
dismissed stale reviews from FabianMeiswinkel, ealsur, and kirankumarkolli
via
April 5, 2024 20:20
99ea8c0
ealsur
approved these changes
Apr 5, 2024
…collection_properties
NaluTripician
approved these changes
Apr 5, 2024
kirankumarkolli
approved these changes
Apr 5, 2024
kundadebdatta
added
auto-merge
Enables automation to merge PRs
and removed
auto-merge
Enables automation to merge PRs
labels
Apr 5, 2024
ealsur
deleted the
users/kundadebdatta/4364_vector_index_add_collection_properties
branch
April 5, 2024 22:39
1 task
kundadebdatta
changed the title
ContainerProperties: Adds Vector Embedding and Indexing Policy
[Internal] ContainerProperties: Adds Vector Embedding and Indexing Policy
Apr 6, 2024
1 task
microsoft-github-policy-service bot
pushed a commit
that referenced
this pull request
Oct 24, 2024
…nterfaces to Mark Them as Public for GA (#4845) # Pull Request Template ## Description The purpose of this PR is to mark the new `VectorEmbeddingPolicy` in the `ContainerProperties` as a public surface interface for `GA` release, and introducing new `VectorIndexes` in the `IndexingPolicy` to enable Vector Similarity Search in Cosmos DB ecosystem. Relevant PRs for the vector similarity work: - [ContainerProperties: Adds Vector Embedding and Indexing Policy](#4379) - [ContainerProperties: Refactors Vector Embedding and Indexing Policy Interfaces to Mark Them as Public for Preview](#4486) - [VectorIndexDefinition: Adds Support for Partitioned DiskANN](#4792) ## Type of change Please delete options that are not relevant. - [x] New feature (non-breaking change which adds functionality) ## Closing issues To automatically close an issue: closes #4825
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This PR adds a new
VectorEmbeddingPolicy
inContainerProperties
and a newVectorIndexes
in theIndexingPolicy
to enable Vector Similarity Search in Cosmos DB.Vector Embedding Policy is the part of the Container level policy, which has the details about embedding dimensions, data type of the embeddings, and the distance function to be used to calculate the similarity between the embedding vectors.
Vector Indexes in Indexing policy is very similar to that of the composite or spatial indexes, in terms of the specs. It specifies the index path, as well as the new index type.
Below is a sample for the new
ContainerProperties
with Indexing Policy and Vector Embedding Policy highlighted.[Note: Since the public emulator is not ready to support the vector embeddings and indexes yet, some of the emulator tests has been marked as skipped for now. These will be enabled in the future as soon as the emulator changes are available publicly.]
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #4364