Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContainerProperties: Refactors Vector Embedding and Indexing Policy Interfaces to Mark Them as Public for GA #4845

Conversation

kundadebdatta
Copy link
Member

@kundadebdatta kundadebdatta commented Oct 24, 2024

Pull Request Template

Description

The purpose of this PR is to mark the new VectorEmbeddingPolicy in the ContainerProperties as a public surface interface for GA release, and introducing new VectorIndexes in the IndexingPolicy to enable Vector Similarity Search in Cosmos DB ecosystem.

Relevant PRs for the vector similarity work:

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Closing issues

To automatically close an issue: closes #4825

@kundadebdatta kundadebdatta added DO NOT MERGE Do Not Review Marks a PR in "work in progress" state. labels Oct 24, 2024
@kundadebdatta kundadebdatta self-assigned this Oct 24, 2024
@kirankumarkolli
Copy link
Member

LGTM, lets also get review from aditya also.

@kundadebdatta kundadebdatta marked this pull request as ready for review October 24, 2024 03:37
Copy link
Contributor

@adityasa adityasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kundadebdatta kundadebdatta added vector-similarity and removed DO NOT MERGE Do Not Review Marks a PR in "work in progress" state. labels Oct 24, 2024
@kundadebdatta kundadebdatta added the auto-merge Enables automation to merge PRs label Oct 24, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit ed75a42 into master Oct 24, 2024
23 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot deleted the users/kundadebdatta/make_vector_search_public_for_ga branch October 24, 2024 05:02
Copy link
Member

@Pilchie Pilchie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late, but LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Enables automation to merge PRs vector-similarity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDK release (GA and preview)
4 participants