Skip to content

Commit

Permalink
Rev WebJobs Extension to 2.13.6, Rev DTFx.AS dependency to 1.17.5, ma…
Browse files Browse the repository at this point in the history
…ke 1ES build deterministic, increase CI Azurite version (#2914)
  • Loading branch information
davidmrdavid authored Sep 16, 2024
1 parent d498cbb commit 11df732
Show file tree
Hide file tree
Showing 5 changed files with 19 additions and 3 deletions.
1 change: 1 addition & 0 deletions eng/templates/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ jobs:
solution: '**/WebJobs.Extensions.DurableTask.sln'
vsVersion: "16.0"
configuration: Release
msbuildArgs: /p:FileVersionRevision=$(Build.BuildId) /p:ContinuousIntegrationBuild=true # these flags make package build deterministic

- template: ci/sign-files.yml@eng
parameters:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,7 @@ internal AzureStorageOrchestrationServiceSettings GetAzureStorageOrchestrationSe
UseSeparateQueueForEntityWorkItems = this.useSeparateQueueForEntityWorkItems,
EntityMessageReorderWindowInMinutes = this.options.EntityMessageReorderWindowInMinutes,
MaxEntityOperationBatchSize = this.options.MaxEntityOperationBatchSize,
AllowReplayingTerminalInstances = this.azureStorageOptions.AllowReplayingTerminalInstances,
};

if (this.inConsumption)
Expand Down
14 changes: 14 additions & 0 deletions src/WebJobs.Extensions.DurableTask/Options/AzureStorageOptions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,20 @@ public string TrackingStoreConnectionStringName
/// <value>A boolean indicating whether to use the table partition strategy. Defaults to false.</value>
public bool UseTablePartitionManagement { get; set; } = false;

/// <summary>
/// When false, when an orchestrator is in a terminal state (e.g. Completed, Failed, Terminated), events for that orchestrator are discarded.
/// Otherwise, events for a terminal orchestrator induce a replay. This may be used to recompute the state of the orchestrator in the "Instances Table".
/// </summary>
/// <remarks>
/// Transactions across Azure Tables are not possible, so we independently update the "History table" and then the "Instances table"
/// to set the state of the orchestrator.
/// If a crash were to occur between these two updates, the state of the orchestrator in the "Instances table" would be incorrect.
/// By setting this configuration to true, you can recover from these inconsistencies by forcing a replay of the orchestrator in response
/// to a client event like a termination request or an external event, which gives the framework another opportunity to update the state of
/// the orchestrator in the "Instances table". To force a replay after enabling this configuration, just send any external event to the affected instanceId.
/// </remarks>
public bool AllowReplayingTerminalInstances { get; set; } = false;

/// <summary>
/// Throws an exception if the provided hub name violates any naming conventions for the storage provider.
/// </summary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<RootNamespace>Microsoft.Azure.WebJobs.Extensions.DurableTask</RootNamespace>
<MajorVersion>2</MajorVersion>
<MinorVersion>13</MinorVersion>
<PatchVersion>5</PatchVersion>
<PatchVersion>6</PatchVersion>
<VersionSuffix>$(PackageSuffix)</VersionSuffix>
<FileVersion>$(MajorVersion).$(MinorVersion).$(PatchVersion)</FileVersion>
<AssemblyVersion>$(MajorVersion).0.0.0</AssemblyVersion>
Expand Down Expand Up @@ -114,7 +114,7 @@
<!-- Common dependencies across all targets -->
<ItemGroup>
<PackageReference Include="Microsoft.Azure.DurableTask.Core" Version="2.17.1" />
<PackageReference Include="Microsoft.Azure.DurableTask.AzureStorage" Version="1.17.4" />
<PackageReference Include="Microsoft.Azure.DurableTask.AzureStorage" Version="1.17.5" />
<PackageReference Include="Microsoft.Azure.WebJobs.Extensions.DurableTask.Analyzers" Version="0.5.*" />
<!-- Build-time dependencies -->
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.*" PrivateAssets="All" />
Expand Down
2 changes: 1 addition & 1 deletion test/SmokeTests/e2e-test.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ function Exit-OnError() {
}

$ErrorActionPreference = "Stop"
$AzuriteVersion = "3.26.0"
$AzuriteVersion = "3.32.0"

if ($NoSetup -eq $false) {
# Build the docker image first, since that's the most critical step
Expand Down

0 comments on commit 11df732

Please sign in to comment.