Rev WebJobs Extension to 2.13.6, Rev DTFx.AS dependency to 1.17.5, make 1ES build deterministic, increase CI Azurite version #2914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmrdavid
changed the title
bachuv
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was opened primarily to increase the WebJobs extension version to 2.13.6, and increase the DTFx.AS dependency to 1.17.5, which allows us to support the upcoming
AllowReplayingTerminalInstancesDTFx property.However, the CI revealed two more problems:
(1) The Azurite version used in our tests was out of date, creating issues. So we've increased the Azurite version from 3.26 to 3.32.
(2) The 1ES build of the WebJobs extension was being flagged as non-deterministic. I added the determinism flags (
/p:FileVersionRevision=$(Build.BuildId) /p:ContinuousIntegrationBuild=true) in our offficial build yml, which we already use in DTFx and other packages.