Rpc http cookie behavior on V3 (#5331)

* change default to Unspecified * by default, an unspecified SameSite value shouldn't be added * use enum * update test to be more accurate * Add explicit reference to .NET core 3.1 for http features * update reference
Azure · Apr 22, 2020 · 88e523e · 88e523e
1 parent fe1dfee
commit 88e523e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/WebJobs.Script/Workers/Rpc/MessageExtensions/RpcMessageExtensionUtilities.cs b/src/WebJobs.Script/Workers/Rpc/MessageExtensions/RpcMessageExtensionUtilities.cs
@@ -86,11 +86,11 @@ private static SameSiteMode RpcSameSiteEnumConverter(RpcHttpCookie.Types.SameSit
                 case RpcHttpCookie.Types.SameSite.Lax:
                     return SameSiteMode.Lax;
                 case RpcHttpCookie.Types.SameSite.None:
-                    return (SameSiteMode)(-1);
+                    return SameSiteMode.Unspecified;
                 case RpcHttpCookie.Types.SameSite.ExplicitNone:
                     return SameSiteMode.None;
                 default:
-                    return (SameSiteMode)(-1);
+                    return SameSiteMode.Unspecified;
             }
         }
     }

diff --git a/test/WebJobs.Script.Tests/Binding/ActionResults/RawScriptResultTests.cs b/test/WebJobs.Script.Tests/Binding/ActionResults/RawScriptResultTests.cs
@@ -69,7 +69,7 @@ public async Task AddsHttpCookies()
                         Path = "/",
                         HttpOnly = true,
                         MaxAge = TimeSpan.FromSeconds(20),
-                        SameSite = (SameSiteMode)(-1)
+                        SameSite = SameSiteMode.Unspecified
                     }),
                     new Tuple<string, string, CookieOptions>("thirdCookie", "cookieValue3", new CookieOptions()
                     {