Rpc http cookie behavior on V3 #5331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhoeger
commented
Dec 4, 2019
src/WebJobs.Script/Workers/Rpc/MessageExtensions/RpcMessageExtensionUtilities.cs
Show resolved
Hide resolved
fabiocav
reviewed
Dec 5, 2019
| }), | ||
| new Tuple<string, string, CookieOptions>("secondCookie", "cookieValue2", new CookieOptions() | ||
| { | ||
| Path = "/", | ||
| HttpOnly = true, | ||
| MaxAge = TimeSpan.FromSeconds(20) | ||
| MaxAge = TimeSpan.FromSeconds(20), | ||
| SameSite = (SameSiteMode)(-1) |
There was a problem hiding this comment.
We should be able to use the new enum value here instead (you may need to add an explicit reference to the package here)
@brettsam, we may need to go over the projects to make sure we're building against the right versions.
There was a problem hiding this comment.
We were trying to not update Script to use anything from 2.0, if I recall. Only WebHost moved forward.
There was a problem hiding this comment.
Was there a good reason for that? It will lead to behavior like this where we're building against an incorrect API
fabiocav
approved these changes
Dec 5, 2019
fabiocav
pushed a commit
that referenced
this pull request
Apr 22, 2020
* change default to Unspecified * by default, an unspecified SameSite value shouldn't be added * use enum * update test to be more accurate * Add explicit reference to .NET core 3.1 for http features * update reference
yojagad
pushed a commit
that referenced
this pull request
Apr 22, 2020
* change default to Unspecified * by default, an unspecified SameSite value shouldn't be added * use enum * update test to be more accurate * Add explicit reference to .NET core 3.1 for http features * update reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents break but doesn't take full advantage of "samesite=none"
Complete fix here:
Azure/azure-functions-nodejs-worker#270
Addresses:
#4890