Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie Update for .Net 3.1 #270

Closed
wants to merge 9 commits into from
Closed

Conversation

mhoeger
Copy link
Contributor

@mhoeger mhoeger commented Dec 4, 2019

Node.js worker portion of fix for Azure/azure-functions-host#4890

V2 Functions Host:
Setting "Lax" == SameSite.Lax == "SameSite=Lax"
Setting "Strict" == SameSite.Strict == "SameSite=Strict"
Not setting value== SameSite.None == Nothing Added

V3 Functions Host:
Setting "Lax" == SameSite.Lax == "SameSite=Lax"
Setting "Strict" == SameSite.Strict == "SameSite=Strict"
Not setting value== SameSite.None == Nothing Added
Setting "None" == SameSite.ExplicitNone == "SameSite=None"

* updates to make 2.0 worker 1.0 compatible

* split validation logic so it's both v1 and v2 compatible

* hard-coded solution to camelCase timer trigger while proper fix is out of scope for timeline

* added test

* adding unit test

* testing both v1 behavior and v2 behavior

* dont code without intellisense

* remove e2e test until have better test on functions host v2 and v3

* re-add node 8 unit tests
* updates to make 2.0 worker 1.0 compatible

* split validation logic so it's both v1 and v2 compatible

* hard-coded solution to camelCase timer trigger while proper fix is out of scope for timeline

* added test

* adding unit test

* properly convert data when defined as output array

* testing both v1 behavior and v2 behavior

* dont code without intellisense

* remove e2e test until have better test on functions host v2 and v3

* fix worker validation logic and warning message on ts changes

* add tests
* Add support for TypedDataCollection

* change package updates for a separate pr

* make change only for v3 functions host +
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant