Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding runtime site name to valid JWT audiences (slot scenarios). #10186

Merged
merged 1 commit into from
May 30, 2024
Merged

Adding runtime site name to valid JWT audiences (slot scenarios). #10186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions src/WebJobs.Script.WebHost/Security/Authentication/Jwt/ScriptJwtBearerExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ public static AuthenticationBuilder AddScriptJwtBearer(this AuthenticationBuilde
}
});

private static string[] GetValidAudiences()
private static IEnumerable<string> GetValidAudiences()
{
if (SystemEnvironment.Instance.IsPlaceholderModeEnabled()
&& SystemEnvironment.Instance.IsLinuxConsumptionOnAtlas())
Expand All @@ -97,11 +97,22 @@ private static string[] GetValidAudiences()
};
}

return new string[]
string siteName = ScriptSettingsManager.Instance.GetSetting(AzureWebsiteName);
string runtimeSiteName = ScriptSettingsManager.Instance.GetSetting(AzureWebsiteRuntimeSiteName);
var audiences = new List<string>
{
string.Format(SiteAzureFunctionsUriFormat, ScriptSettingsManager.Instance.GetSetting(AzureWebsiteName)),
string.Format(SiteUriFormat, ScriptSettingsManager.Instance.GetSetting(AzureWebsiteName))
string.Format(SiteAzureFunctionsUriFormat, siteName),
string.Format(SiteUriFormat, siteName)
};

if (!string.IsNullOrEmpty(runtimeSiteName) && !string.Equals(siteName, runtimeSiteName, StringComparison.OrdinalIgnoreCase))
{
// on a non-production slot, the runtime site name will differ from the site name
// we allow both for audience
audiences.Add(string.Format(SiteUriFormat, runtimeSiteName));
}

return audiences;
}

public static TokenValidationParameters CreateTokenValidationParameters()
Expand Down
38 changes: 38 additions & 0 deletions test/WebJobs.Script.Tests/Extensions/ScriptJwtBearerExtensionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,5 +67,43 @@ public void CreateTokenValidationParameters_HasExpectedAudience(bool isPlacehold
}
}
}

[Theory]
[InlineData("testsite", "testsite")]
[InlineData("testsite", "testsite__5bb5")]
[InlineData("testsite", null)]
[InlineData("testsite", "")]
public void CreateTokenValidationParameters_NonProductionSlot_HasExpectedAudiences(string siteName, string runtimeSiteName)
{
string azFuncAudience = string.Format(ScriptConstants.SiteAzureFunctionsUriFormat, siteName);
string siteAudience = string.Format(ScriptConstants.SiteUriFormat, siteName);
string runtimeSiteAudience = string.Format(ScriptConstants.SiteUriFormat, runtimeSiteName);

var testEnv = new Dictionary<string, string>(StringComparer.OrdinalIgnoreCase)
{
{ EnvironmentSettingNames.AzureWebsiteName, siteName },
{ EnvironmentSettingNames.AzureWebsiteRuntimeSiteName, runtimeSiteName },
{ ContainerEncryptionKey, Convert.ToBase64String(TestHelpers.GenerateKeyBytes()) }
};

using (new TestScopedSettings(ScriptSettingsManager.Instance, testEnv))
{
var tokenValidationParameters = ScriptJwtBearerExtensions.CreateTokenValidationParameters();
var audiences = tokenValidationParameters.ValidAudiences.ToArray();

Assert.Equal(audiences[0], azFuncAudience);
Assert.Equal(audiences[1], siteAudience);

if (string.Compare(siteName, runtimeSiteName, StringComparison.OrdinalIgnoreCase) == 0)
{
Assert.Equal(2, audiences.Length);
}
else if (!string.IsNullOrEmpty(runtimeSiteName))
{
Assert.Equal(3, audiences.Length);
Assert.Equal(audiences[2], runtimeSiteAudience);
}
}
}
}
}
Loading