Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding runtime site name to valid JWT audiences (slot scenarios). #10186

Merged
merged 1 commit into from
May 30, 2024
Merged

Adding runtime site name to valid JWT audiences (slot scenarios). #10186

merged 1 commit into from
May 30, 2024

Conversation

mathewc
Copy link
Member

@mathewc mathewc commented May 24, 2024

Backport of #10183

@mathewc mathewc mentioned this pull request May 24, 2024
Merged
11 tasks
@mathewc
Copy link
Member Author

mathewc commented May 24, 2024

Looks like CI is failing due to missing Keyvault secrets:

Microsoft.Azure.WebJobs.Script.Tests.SecretsRepositoryTests.WriteAsync_CreatesExpectedFile

Microsoft.Azure.Services.AppAuthentication.AzureServiceTokenProviderException : Parameters: Connection String: RunAs=App;AppId=444681e3-715c-4d22-ae13-ccd7d05ab318;TenantId=72f988bf-86f1-41af-91ab-2d7cd011db47;AppKey=<<Redacted>>, Resource: https://vault.azure.net, Authority: https://login.microsoftonline.com/72f988bf-86f1-41af-91ab-2d7cd011db47. Exception Message: Access token could not be acquired. AADSTS7000215: Invalid client secret provided. Ensure the secret being sent in the request is the client secret value, not the client secret ID, for a secret added to app '444681e3-715c-4d22-ae13-ccd7d05ab318'. Trace ID: 64d9f27d-9188-4a1a-9431-70978c368700 Correlation ID: 160dc836-8873-416a-a368-eed08100d903 Timestamp: 2024-05-24 21:34:45Z

@mathewc mathewc merged commit f3c64e7 into v3.x May 30, 2024
6 checks passed
@mathewc mathewc deleted the audience-slot-fix-v3.x branch May 30, 2024 17:30
v-imohammad pushed a commit that referenced this pull request Jul 16, 2024
@mathewc @v-imohammad
Adding runtime site name to valid JWT audiences (slot scenarios). (#1…
939864c 
…0186)
@v-imohammad v-imohammad mentioned this pull request Jul 16, 2024
Merged
9 tasks
v-imohammad added a commit that referenced this pull request Jul 16, 2024
@v-imohammad @mathewc @jviau
Pushing commit from v3.x to release/3.0 (#10292)
9b771d6 
* Adding runtime site name to valid JWT audiences (slot scenarios). (#10186)

* Defaulting SwtAuthenticationEnabled to False (#10196)

* Regenerate .gitignore via dotnet cli (#10206)

* [v3.x] Add 1ES CI pipelines (#10247)

* Onboard v3.x to 1ES templates

* update nuget feeds

* Revert nuget.config feeds. Remove unused tools

* Fix buildNumber

* Use .net 8 SDK, fix version propagation

* Fix update build number

* Install additional .NET SDKs

* Fix/suppress cred scan hits in test files

* Remove performance app from legacy ci

* update 1es tests

* Test release

* Fix non-e2e env

* Fix webhost bin config path

* fix TestHelpers

* Fix missing variable

* Set AzureWebJobsEventHubPath in test env

* Fix .net 3.1 missing for tests

* Remove test change

* Fix .net 3.1 missing for tests

* Address test secrets being flagged (#10264)

* Release Prep for 3.23.0 (#10291)

---------

Co-authored-by: Mathew Charles <mathewc@microsoft.com>
Co-authored-by: Jacob Viau <javia@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kshyju kshyju kshyju approved these changes

@jviau jviau jviau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathewc @kshyju @jviau