Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pushing commit from v3.x to release/3.0 #10292

Merged
merged 6 commits into from
Jul 16, 2024

Conversation

v-imohammad
Copy link
Contributor

@v-imohammad v-imohammad commented Jul 16, 2024

Issue describing the changes in this PR

cherry-picked below list of commits from v3.x to release/3.0
Adding runtime site name to valid JWT audiences (slot scenarios). (#10186)
Defaulting SwtAuthenticationEnabled to False (#10196)
Regenerate .gitignore via dotnet cli (#10206)
[v3.x] Add 1ES CI pipelines (#10247)
Address test secrets being flagged (#10264)
Release Prep for 3.23.0 (#10291)

resolves #issue_for_this_pr

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

mathewc and others added 6 commits July 16, 2024 13:13
* Onboard v3.x to 1ES templates

* update nuget feeds

* Revert nuget.config feeds. Remove unused tools

* Fix buildNumber

* Use .net 8 SDK, fix version propagation

* Fix update build number

* Install additional .NET SDKs

* Fix/suppress cred scan hits in test files

* Remove performance app from legacy ci

* update 1es tests

* Test release

* Fix non-e2e env

* Fix webhost bin config path

* fix TestHelpers

* Fix missing variable

* Set AzureWebJobsEventHubPath in test env

* Fix .net 3.1 missing for tests

* Remove test change

* Fix .net 3.1 missing for tests
@arroyc
Copy link

arroyc commented Jul 16, 2024

all the commits are there ... so, commit wise looks good ... let's wait for the build to be successful and then we can merge this, if we can't merge this, we probably need to ask for help again

@v-imohammad v-imohammad merged commit 9b771d6 into release/3.0 Jul 16, 2024
10 checks passed
@v-imohammad v-imohammad deleted the developer/v-imohammad/mergingcommitsfromv3.x branch July 16, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants