Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worker termination path update #10367

Merged
merged 21 commits into from
Aug 13, 2024
Merged

Conversation

surgupta-msft
Copy link
Contributor

@surgupta-msft surgupta-msft commented Aug 5, 2024

Issue describing the changes in this PR

resolves #issue_for_this_pr

There will be a follow-up item here to simplify the class Sanitizer.cs for performance - #10383

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@surgupta-msft surgupta-msft requested a review from a team as a code owner August 5, 2024 19:19
@surgupta-msft surgupta-msft marked this pull request as draft August 6, 2024 23:34
@surgupta-msft surgupta-msft marked this pull request as ready for review August 7, 2024 16:14
Copy link
Member

@kshyju kshyju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with 2 open questions.

@surgupta-msft surgupta-msft merged commit 6039bbc into dev Aug 13, 2024
10 checks passed
@surgupta-msft surgupta-msft deleted the surgupta/sanitize-worker-termination branch August 13, 2024 19:07
surgupta-msft added a commit that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants