Allow ServiceBus AutoComplete to be configured #3179

mathewc · 2018-07-24T21:29:13Z

Addresses #2066.

Related SDK PR: Azure/azure-webjobs-sdk#1814. This change is required to enable the actual scenario of disabling AutoComplete and controlling message lifetime yourself.

Will make the same change in dev.

alexjamesbrown · 2018-08-17T08:22:33Z

@mathewc is there a pre-release of this we could try out at all? Checked nuget, but doesn't seem to be published?

It addresses the issues I was having in my StackOverflow post - https://stackoverflow.com/questions/51881103/calling-complete-or-deadletter-on-brokeredmessage-with-azure-functions-service/51889907

braxler · 2018-08-23T13:54:57Z

Looks like it's working for v3.1.0, it didn't work for me for 1.x or 2.x

alexjamesbrown · 2018-08-23T21:01:24Z

@braxler - how can I try v3.1.0 ?
Is it pre-release?

mathewc · 2018-08-24T17:03:48Z

This has been released as part of functions v1 release https://github.com/Azure/azure-functions-host/releases/tag/v1.0.11959. It is also part of our latest v2 beta releases.

tomkuijsten · 2018-08-25T10:14:06Z

How do I use this in my function app? Is it just a matter of updating the nuget package or...?

alexjamesbrown · 2018-08-25T10:33:07Z

@tomkuijsten I have the same question!

mathewc · 2018-08-27T17:10:38Z

If you're on the latest runtime version (v1 or v2) with the change, then you specify autoComplete: false in your host.json file, e.g.:

{
  "serviceBus": {
      "maxConcurrentCalls": 16,
      "prefetchCount": 100,
      "autoComplete": false
    }
}

If you have any problems with this, please log a new issue.

alexjamesbrown · 2018-08-28T11:13:13Z

@mathewc is this just for csx? Not pre-compiled functions?

alexjamesbrown · 2018-08-28T12:06:15Z

@mathewc
Happy for this to be moved to a new issue, but it feels like a duplicate of this, or I'm using the wrong runtime?

using runtime version 1.0.11913.0 this still happens:

The lock supplied is invalid. Either the lock expired, or the message has already been removed from the queue

If we have the following basic function:

[FunctionName("Function1")]
public static async Task Run(
    [ServiceBusTrigger("%Topic%", "%Subscription%", AccessRights.Manage, Connection = "ServiceBus.ConnectionString")]BrokeredMessage msg)
{
    await msg.DeadLetterAsync("reason", "description");
}

Listening on http://localhost:7071/
Hit CTRL-C to exit...
[28/08/2018 11:50:10] Reading host configuration file 'C:\****\bin\Debug\net471\host.json'
[28/08/2018 11:50:10] Host configuration file read:
[28/08/2018 11:50:10] {
[28/08/2018 11:50:10]   "serviceBus": {
[28/08/2018 11:50:10]     "autoComplete": false
[28/08/2018 11:50:10]   }
[28/08/2018 11:50:10] }
[28/08/2018 11:50:14] Starting Host (HostId=asglhwl19969-827647181, Version=1.0.11913.0, InstanceId=5aa426cb-bc7e-4162-ab2e-d6d2a7642bab, ProcessId=135424, AppDomainId=1, Debug=False, ConsecutiveErrors=0, StartupCount=1, FunctionsExtensionVersion=)
[28/08/2018 11:50:15] Loaded custom extension 'BotFrameworkConfiguration'
[28/08/2018 11:50:15] Loaded custom extension 'SendGridConfiguration'
[28/08/2018 11:50:15] Loaded custom extension 'EventGridExtensionConfig'
[28/08/2018 11:50:15] registered EventGrid Endpoint = http://localhost:7071/admin/extensions/EventGridExtensionConfig
[28/08/2018 11:50:15] Generating 2 job function(s)
[28/08/2018 11:50:15] Found the following functions:
[28/08/2018 11:50:15] ****.SubscriptionActivated.Run
[28/08/2018 11:50:15] ****.SubscriptionDecativated.Run
[28/08/2018 11:50:15]
[28/08/2018 11:50:15] Host initialized (6323ms)
[28/08/2018 11:50:16] Host lock lease acquired by instance ID '000000000000000000000000100BA934'.
Debugger listening on [::]:5858
[28/08/2018 11:50:17] Host started (8099ms)
[28/08/2018 11:50:17] Job host started
[28/08/2018 11:50:40] Function started (Id=b335df47-5c74-4638-a85a-8960f5f43b25)
[28/08/2018 11:50:41] Executing 'SubscriptionActivated' (Reason='New ServiceBus message detected on '***/Subscriptions/identity.subscriber'.', Id=b335df47-5c74-4638-a85a-8960f5f43b25)
[28/08/2018 11:50:42] Function completed (Success, Id=b335df47-5c74-4638-a85a-8960f5f43b25, Duration=1890ms)
[28/08/2018 11:50:42] Executed 'SubscriptionActivated' (Succeeded, Id=b335df47-5c74-4638-a85a-8960f5f43b25)
[28/08/2018 11:50:44] A ScriptHost error has occurred
[28/08/2018 11:50:44] Microsoft.ServiceBus: The lock supplied is invalid. Either the lock expired, or the message has already been removed from the queue. TrackingId:ded0e336-c523-48c7-9952-d0d87bf8010b_G33_B10, SystemTracker:****:Topic:***|identity.subscriber, Timestamp:8/28/2018 11:50:43 AM.
[28/08/2018 11:50:44] MessageReceiver error (Action=Complete) : Microsoft.ServiceBus.Messaging.MessageLockLostException: The lock supplied is invalid. Either the lock expired, or the message has already been removed from the queue. TrackingId:ded0e336-c523-48c7-9952-d0d87bf8010b_G33_B10, SystemTracker:****:Topic:***|identity.subscriber, Timestamp:8/28/2018 11:50:43 AM ---> System.ServiceModel.FaultException`1[System.ServiceModel.ExceptionDetail]: The lock supplied is invalid. Either the lock expired, or the message has already been removed from the queue. TrackingId:ded0e336-c523-48c7-9952-d0d87bf8010b_G33_B10, SystemTracker:****:Topic:***|identity.subscriber, Timestamp:8/28/2018 11:50:43 AM
[28/08/2018 11:50:44]    at Microsoft.ServiceBus.Messaging.Sbmp.DuplexRequestBindingElement.DuplexRequestSessionChannel.ThrowIfFaultMessage(Message wcfMessage)
[28/08/2018 11:50:44]    at Microsoft.ServiceBus.Messaging.Sbmp.DuplexRequestBindingElement.DuplexRequestSessionChannel.HandleMessageReceived(IAsyncResult result)
[28/08/2018 11:50:44] --- End of stack trace from previous location where exception was thrown ---
[28/08/2018 11:50:44]    at Microsoft.ServiceBus.Common.AsyncResult.End[TAsyncResult](IAsyncResult result)
[28/08/2018 11:50:44]    at Microsoft.ServiceBus.Messaging.Sbmp.DuplexRequestBindingElement.DuplexRequestSessionChannel.EndRequest(IAsyncResult result)
[28/08/2018 11:50:44]    at Microsoft.ServiceBus.Messaging.Channels.ReconnectBindingElement.ReconnectChannelFactory`1.RequestSessionChannel.RequestAsyncResult.<>c.<GetAsyncSteps>b__9_3(RequestAsyncResult thisPtr, IAsyncResult r)
[28/08/2018 11:50:44]    at Microsoft.ServiceBus.Messaging.IteratorAsyncResult`1.StepCallback(IAsyncResult result)
[28/08/2018 11:50:44] --- End of stack trace from previous location where exception was thrown ---
[28/08/2018 11:50:44]    at Microsoft.ServiceBus.Common.AsyncResult.End[TAsyncResult](IAsyncResult result)
[28/08/2018 11:50:44]    at Microsoft.ServiceBus.Common.AsyncResult`1.End(IAsyncResult asyncResult)
[28/08/2018 11:50:44]    at Microsoft.ServiceBus.Messaging.Channels.ReconnectBindingElement.ReconnectChannelFactory`1.RequestSessionChannel.EndRequest(IAsyncResult result)
[28/08/2018 11:50:44]    at Microsoft.ServiceBus.Messaging.Sbmp.RedirectBindingElement.RedirectContainerChannelFactory`1.RedirectContainerSessionChannel.RequestAsyncResult.<>c__DisplayClass8_1.<GetAsyncSteps>b__4(RequestAsyncResult thisPtr, IAsyncResult r)
[28/08/2018 11:50:44]    at Microsoft.ServiceBus.Messaging.IteratorAsyncResult`1.StepCallback(IAsyncResult result)
[28/08/2018 11:50:44] --- End of stack trace from previous location where exception was thrown ---
[28/08/2018 11:50:44]    at Microsoft.ServiceBus.Common.AsyncResult.End[TAsyncResult](IAsyncResult result)
[28/08/2018 11:50:44]    at Microsoft.ServiceBus.Common.AsyncResult`1.End(IAsyncResult asyncResult)
[28/08/2018 11:50:44]    at Microsoft.ServiceBus.Messaging.Sbmp.RedirectBindingElement.RedirectContainerChannelFactory`1.RedirectContainerSessionChannel.EndRequest(IAsyncResult result)
[28/08/2018 11:50:44]    at Microsoft.ServiceBus.Messaging.Channels.ReconnectBindingElement.ReconnectChannelFactory`1.RequestSessionChannel.RequestAsyncResult.<>c.<GetAsyncSteps>b__9_3(RequestAsyncResult thisPtr, IAsyncResult r)
[28/08/2018 11:50:44]    at Microsoft.ServiceBus.Messaging.IteratorAsyncResult`1.StepCallback(IAsyncResult result)
[28/08/2018 11:50:44] --- End of stack trace from previous location where exception was thrown ---
[28/08/2018 11:50:44]    at Microsoft.ServiceBus.Common.AsyncResult.End[TAsyncResult](IAsyncResult result)
[28/08/2018 11:50:44]    at Microsoft.ServiceBus.Common.AsyncResult`1.End(IAsyncResult asyncResult)
[28/08/2018 11:50:44]    at Microsoft.ServiceBus.Messaging.Channels.ReconnectBindingElement.ReconnectChannelFactory`1.RequestSessionChannel.EndRequest(IAsyncResult result)
[28/08/2018 11:50:44]    at Microsoft.ServiceBus.Messaging.Sbmp.SbmpTransactionalAsyncResult`1.<>c.<GetAsyncSteps>b__18_3(TIteratorAsyncResult thisPtr, IAsyncResult a)
[28/08/2018 11:50:44]    at Microsoft.ServiceBus.Messaging.IteratorAsyncResult`1.StepCallback(IAsyncResult result)
[28/08/2018 11:50:44] --- End of stack trace from previous location where exception was thrown ---
[28/08/2018 11:50:44]    at Microsoft.ServiceBus.Common.AsyncResult.End[TAsyncResult](IAsyncResult result)
[28/08/2018 11:50:44]    at Microsoft.ServiceBus.Messaging.Sbmp.SbmpMessageReceiver.EndUpdateCommand(IAsyncResult result)
[28/08/2018 11:50:44]    --- End of inner exception stack trace ---
[28/08/2018 11:50:44]    at Microsoft.ServiceBus.Common.AsyncResult.End[TAsyncResult](IAsyncResult result)
[28/08/2018 11:50:44]    at Microsoft.ServiceBus.Common.AsyncResult`1.End(IAsyncResult asyncResult)
[28/08/2018 11:50:44]    at Microsoft.ServiceBus.Messaging.IteratorAsyncResult`1.<>c__22`1.<CallParallelAsync>b__22_1(TIteratorAsyncResult thisPtr, IAsyncResult r)
[28/08/2018 11:50:44]    at Microsoft.ServiceBus.Messaging.IteratorAsyncResult`1.StepCallback(IAsyncResult result)
[28/08/2018 11:50:44] Microsoft.ServiceBus: The lock supplied is invalid. Either the lock expired, or the message has already been removed from the queue. TrackingId:ded0e336-c523-48c7-9952-d0d87bf8010b_G33_B10, SystemTracker:****:Topic:***|identity.subscriber, Timestamp:8/28/2018 11:50:43 AM.

tomkuijsten · 2018-08-30T07:43:15Z

@alexjamesbrown you should be on framework 1.0.11959.0 right? See release notes. Would explain why it's not yet working.

tomkuijsten · 2018-08-30T07:48:48Z

@alexjamesbrown answer to my own question on forcing framework version (thanks to @keesschollaart81):

https://docs.microsoft.com/en-us/azure/azure-functions/set-runtime-version

alexjamesbrown · 2018-08-30T08:16:28Z

@tomkuijsten this only explains how to set it when deploying - not on how to set it for the local runtime
What I really want to be able to do is set FUNCTIONS_EXTENSION_VERSION in host.json (maybe??) - but this has no effect

mathewc · 2018-08-30T15:29:52Z

You need to update your Azure Functions Tools to get the new version.

alexjamesbrown · 2018-08-30T15:48:35Z

@mathewc to which version please?

running func from the cmd line shows

Azure Functions Core Tools (1.0.14)
Function Runtime Version: 1.0.11913.0

alexjamesbrown · 2018-08-30T15:52:09Z

@mathewc ... which is weird, since 1.0.12 is listed as the 'latest version'
https://github.com/Azure/azure-functions-core-tools/releases/tag/1.0.12

I've installed via npm

mathewc · 2018-08-30T16:07:17Z

Yes, it appears that we don't have CLI released with these changes, sorry. I'll start an internal thread on that and see why that is.

mhoeger · 2018-08-30T22:11:33Z

The CLI bits will be released shortly. Sorry about that @alexjamesbrown!

alexjamesbrown · 2018-09-21T17:00:49Z

@mhoeger @mathewc
sorry to drag this up again, but was this updated?

I've updated the cli, but VS still reports
ersion=1.0.11913.0

[21/09/2018 16:58:22] Host configuration file read:
[21/09/2018 16:58:22] {
[21/09/2018 16:58:22] "serviceBus": {
[21/09/2018 16:58:22] "autoComplete": false
[21/09/2018 16:58:22] }
[21/09/2018 16:58:22] }
[21/09/2018 16:58:26] Starting Host (HostId=asglhwl19969-827712717, Version=1.0.11913.0, InstanceId=01e2d5f1-96d1-47a2-8198-bd8a1e28eff7, ProcessId=557084, AppDomainId=1, Debug=False, ConsecutiveErrors=0, StartupCount=1, FunctionsExtensionVersion=)

mhoeger · 2018-09-21T17:05:37Z

@alexjamesbrown - The 1.0.11959 bits should have been released on August 30th. Let me double check!

alexjamesbrown · 2018-09-21T17:09:47Z

@mhoeger if I do
func

On cmd line, I get that version.... But visual studio (when hitting f5 in a function project) seems to still be running a previous version.

I've updated the Azure functions extension in vs

mhoeger · 2018-09-21T17:27:05Z

@alexjamesbrown - could you try restarting VS and trying again? It looks like those bits were moved to "pre-release" and never fully released. So sorry about the long delay in getting your fix!

alexjamesbrown · 2018-09-24T10:49:22Z

@mhoeger thanks, it looks like it's working now

mpMelnikov · 2018-10-30T15:19:13Z

Should it work in v.2 functions?
Currently, I get "The lock supplied is invalid". I tried the following two host.json:

{
  "version": "2.0",
  "serviceBus": {
      "autoComplete": false
  }
}

and (as schema in master branch has messageHandlerOptions option)

{
  "version": "2.0",
  "serviceBus": {
    "messageHandlerOptions": {
      "autoComplete": false
    }
  }
}

mpMelnikov · 2018-10-30T15:40:27Z

As it was explained here, "extensions" section is required.
Hosts.json which seems to work:

{
  "version": "2.0",
  "extensions": {
    "serviceBus": {
      "messageHandlerOptions": {
        "autoComplete": false
      }
    }
  }
}

@mathewc thank you again!

mathewc requested a review from paulbatum July 24, 2018 21:29

mathewc mentioned this pull request Jul 24, 2018

[ServiceBus] Adding AutoComplete option to host.json file #2066

Closed

mathewc requested a review from brettsam July 25, 2018 15:55

brettsam approved these changes Jul 25, 2018

View reviewed changes

mathewc force-pushed the sb-options branch from 43fc048 to 5714aef Compare July 26, 2018 17:49

Allow ServiceBus AutoComplete to be configured

f41da7b

mathewc force-pushed the sb-options branch from 5714aef to f41da7b Compare July 26, 2018 17:51

mathewc merged commit f41da7b into v1.x Jul 26, 2018

mathewc mentioned this pull request Jul 26, 2018

ServiceBus Config Options have changed #2828

Closed

alexjamesbrown mentioned this pull request Aug 28, 2018

[Discussion] Azure Functions Runtime 1.0.11959 release Azure/app-service-announcements-discussions#62

Closed

hoffe86 mentioned this pull request Sep 14, 2018

Update documentation for host.json reference MicrosoftDocs/azure-docs#15005

Closed

mpMelnikov mentioned this pull request Oct 30, 2018

How to intentionally deadletter a message in azure functions v2 Azure/azure-webjobs-sdk#1986

Closed

ahmelsayed deleted the sb-options branch July 16, 2019 17:44

brettsam mentioned this pull request Sep 17, 2020

Adding autoComplete to v1 host.json docs MicrosoftDocs/azure-docs#62824

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow ServiceBus AutoComplete to be configured #3179

Allow ServiceBus AutoComplete to be configured #3179

mathewc commented Jul 24, 2018 •

edited

Loading

alexjamesbrown commented Aug 17, 2018

braxler commented Aug 23, 2018

alexjamesbrown commented Aug 23, 2018

mathewc commented Aug 24, 2018

tomkuijsten commented Aug 25, 2018

alexjamesbrown commented Aug 25, 2018

mathewc commented Aug 27, 2018 •

edited

Loading

alexjamesbrown commented Aug 28, 2018

alexjamesbrown commented Aug 28, 2018

tomkuijsten commented Aug 30, 2018 •

edited

Loading

tomkuijsten commented Aug 30, 2018 •

edited

Loading

alexjamesbrown commented Aug 30, 2018

mathewc commented Aug 30, 2018

alexjamesbrown commented Aug 30, 2018

alexjamesbrown commented Aug 30, 2018

mathewc commented Aug 30, 2018

mhoeger commented Aug 30, 2018

alexjamesbrown commented Sep 21, 2018

mhoeger commented Sep 21, 2018

alexjamesbrown commented Sep 21, 2018

mhoeger commented Sep 21, 2018

alexjamesbrown commented Sep 24, 2018

mpMelnikov commented Oct 30, 2018

mpMelnikov commented Oct 30, 2018 •

edited

Loading

Allow ServiceBus AutoComplete to be configured #3179

Allow ServiceBus AutoComplete to be configured #3179

Conversation

mathewc commented Jul 24, 2018 • edited Loading

alexjamesbrown commented Aug 17, 2018

braxler commented Aug 23, 2018

alexjamesbrown commented Aug 23, 2018

mathewc commented Aug 24, 2018

tomkuijsten commented Aug 25, 2018

alexjamesbrown commented Aug 25, 2018

mathewc commented Aug 27, 2018 • edited Loading

alexjamesbrown commented Aug 28, 2018

alexjamesbrown commented Aug 28, 2018

tomkuijsten commented Aug 30, 2018 • edited Loading

tomkuijsten commented Aug 30, 2018 • edited Loading

alexjamesbrown commented Aug 30, 2018

mathewc commented Aug 30, 2018

alexjamesbrown commented Aug 30, 2018

alexjamesbrown commented Aug 30, 2018

mathewc commented Aug 30, 2018

mhoeger commented Aug 30, 2018

alexjamesbrown commented Sep 21, 2018

mhoeger commented Sep 21, 2018

alexjamesbrown commented Sep 21, 2018

mhoeger commented Sep 21, 2018

alexjamesbrown commented Sep 24, 2018

mpMelnikov commented Oct 30, 2018

mpMelnikov commented Oct 30, 2018 • edited Loading

mathewc commented Jul 24, 2018 •

edited

Loading

mathewc commented Aug 27, 2018 •

edited

Loading

tomkuijsten commented Aug 30, 2018 •

edited

Loading

tomkuijsten commented Aug 30, 2018 •

edited

Loading

mpMelnikov commented Oct 30, 2018 •

edited

Loading