Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding autoComplete to v1 host.json docs #62824

Merged
merged 2 commits into from
Nov 17, 2020

Conversation

brettsam
Copy link
Contributor

+@mathewc to confirm the details.

Had an incident today that required autoComplete in V1 and noticed we had no docs on this. This PR added it: Azure/azure-functions-host#3179

@PRMerger18
Copy link
Contributor

@brettsam : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver
Copy link
Contributor

ktoliver commented Sep 17, 2020

Hi @ggailey777 - Would you review the proposed update to your article?

Thanks.

@ktoliver ktoliver removed the triaged label Sep 22, 2020
@cgillum
Copy link
Contributor

cgillum commented Oct 28, 2020

Hey @brettsam is this PR still valid? You may want to consider submitting them to azure-docs-pr in the future so that you can sign off on your own PRs.

@brettsam
Copy link
Contributor Author

Yes it's still valid. Although I'm not sure why the code diff looks weird and red for me... maybe @ggailey777 knows?

Thanks, I didn't know about azure-docs-pr. I've been clicking "edit" from the doc itself and making my changes, which got me here.

@ktoliver
Copy link
Contributor

ktoliver commented Oct 28, 2020

@brettsam Red in the diff view indicates a syntax error in the code. In this case, a closing curly bracket was missing; I added it and it's fixed now. 👍

I'll send you information in email about working in the azure-docs-pr aka private repository.

@brettsam
Copy link
Contributor Author

@ktoliver -- holy cow, I didn't know that! Thanks!

@ggailey777
Copy link
Contributor

Sorry for the delay in #sign-off
@brettsam we recommend that you run the SpineEdit tool in your Chrome browser, which gets to the correct repo automagically. Thanks!

@ktoliver ktoliver merged commit 89c5624 into MicrosoftDocs:master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants