Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating release notes for the AzureStack release 1.6.0 #7924

Closed
wants to merge 105 commits into from

Conversation

bganapa
Copy link
Member

@bganapa bganapa commented Nov 27, 2018

Description

Checklist

praries880 and others added 30 commits November 5, 2018 16:22
Removed storage depedency when inferring storageBlobContainerName
Removed storage depedency when inferring storageBlobContainerName
Update changelog
Jeffrey Robinson and others added 14 commits November 26, 2018 17:08
Fixes the example for New-AzureRmTag, values field was wrongly populated with the value.
Avoid  Get-Location hardcode in AnalysisServices.Test
[Azure Stack] Re-Generate Module Help
…pdate

[RecoveryServices.Backup] Making storage account and RG name optional for AFS restore
Update example in New-AzureRmTag.md
Wrong command used in documentation example
Update Microsoft.DataTransfer.Gateway.Encryption to 3.11.6898.1 to consume nuget.org
@bganapa bganapa requested a review from deathly809 November 27, 2018 19:49
@bganapa
Copy link
Member Author

bganapa commented Nov 27, 2018

Copy link
Member

@deathly809 deathly809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -51,7 +51,7 @@
# ProcessorArchitecture = ''

# Modules that must be imported into the global environment prior to importing this module
RequiredModules = @(@{ModuleName = 'AzureRM.Profile'; ModuleVersion = '5.6.0'; },
RequiredModules = @(@{ModuleName = 'AzureRM.Profile'; RequiredVersion = '5.5.2'; },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bganapa why is this change being made?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this might be because the 2.3.0 module has a RequiredVersion = 5.5.2. We made a mistake there.

RequiredModules = @(@{ModuleName = 'AzureRM.Profile'; RequiredVersion = '5.5.2'; },

You can see it under the Package details as well. I think Mark actually told us to do this, but that might have been another conversation.
https://www.powershellgallery.com/packages/AzureRM/2.3.0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cormacpayne as @deathly809 mentioned above, we have a shipped AzureRM 2.3.0 with RequiredVersion 5.5.2, When we move to a newer AzureRM 2.4.0, we will change it to ModuleVersion dependency for both AZURESTACK and AzureRm modules.

@cormacpayne cormacpayne changed the base branch from preview to AzureRM November 28, 2018 21:47
@cormacpayne
Copy link
Member

@bganapa @deathly809 moving forward, Stack PRs will need to target the AzureRM branch, not preview, so you may need to close this PR and open a new one that is based on the AzureRM branch (since this one is based on the preview branch and is bringing in a bunch of commits from the preview branch into AzureRM). I will work to bring in the Stack changes from the preview branch into AzureRM. It appears to be the following PRs:

@bganapa
Copy link
Member Author

bganapa commented Nov 29, 2018

@cormacpayne This PR has so many commits and it is impossible to review, it looks like you are merging everything from preview to AzureRm?

@markcowl
Copy link
Member

Closing this PR - I think we need a new PR based on the AzureRm branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.