-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating release notes for the AzureStack release 1.6.0 #7924
Conversation
param sets for new-AzVm(ss) cmdlets
…nto 6499_UltraSSD_SIG_Compute
…nto 6499_UltraSSD_SIG_Compute
Removed storage depedency when inferring storageBlobContainerName
Removed storage depedency when inferring storageBlobContainerName
Update changelog
…s880/azure-powershell into 6499_UltraSSD_SIG_Compute
…nsume nuget on nuget.org
Fixes the example for New-AzureRmTag, values field was wrongly populated with the value.
Avoid Get-Location hardcode in AnalysisServices.Test
[Azure Stack] Re-Generate Module Help
…pdate [RecoveryServices.Backup] Making storage account and RG name optional for AFS restore
Update example in New-AzureRmTag.md
Wrong command used in documentation example
Update Microsoft.DataTransfer.Gateway.Encryption to 3.11.6898.1 to consume nuget.org
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -51,7 +51,7 @@ | |||
# ProcessorArchitecture = '' | |||
|
|||
# Modules that must be imported into the global environment prior to importing this module | |||
RequiredModules = @(@{ModuleName = 'AzureRM.Profile'; ModuleVersion = '5.6.0'; }, | |||
RequiredModules = @(@{ModuleName = 'AzureRM.Profile'; RequiredVersion = '5.5.2'; }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bganapa why is this change being made?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this might be because the 2.3.0 module has a RequiredVersion = 5.5.2. We made a mistake there.
RequiredModules = @(@{ModuleName = 'AzureRM.Profile'; RequiredVersion = '5.5.2'; }, |
You can see it under the Package details as well. I think Mark actually told us to do this, but that might have been another conversation.
https://www.powershellgallery.com/packages/AzureRM/2.3.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cormacpayne as @deathly809 mentioned above, we have a shipped AzureRM 2.3.0 with RequiredVersion 5.5.2, When we move to a newer AzureRM 2.4.0, we will change it to ModuleVersion dependency for both AZURESTACK and AzureRm modules.
@bganapa @deathly809 moving forward, Stack PRs will need to target the |
@cormacpayne This PR has so many commits and it is impossible to review, it looks like you are merging everything from preview to AzureRm? |
Closing this PR - I think we need a new PR based on the AzureRm branch |
Description
Checklist
CONTRIBUTING.md
platyPS
module