Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/repairswagger: Adding powershell cmdlet for repair alert #7742

Merged
merged 2 commits into from
Nov 27, 2018
Merged

Feature/repairswagger: Adding powershell cmdlet for repair alert #7742

merged 2 commits into from
Nov 27, 2018

Conversation

sumitabarahmand
Copy link
Contributor

Description

Adding powershell cmdlet for repair alert
Spec PR: Azure/azure-rest-api-specs#4084
SDK PR: Azure/azure-sdk-for-net#5000

Checklist

@sumitabarahmand
Copy link
Contributor Author

@bganapa and @deathly809
Spec: Azure/azure-rest-api-specs#4084
SDK: Azure/azure-sdk-for-net#5000

@adxsdkps
Copy link
Collaborator

adxsdkps commented Nov 4, 2018

Can one of the admins verify this patch?

@deathly809
Copy link
Member

Will review after SDK is merged.

@maddieclayton
Copy link
Contributor

@azuresdkci Add to whitelist

@bganapa
Copy link
Member

bganapa commented Nov 14, 2018

@sumitabarahmand please update this PR once the SDK PR
Azure/azure-sdk-for-net#5000 is merged and published.

@sumitabarahmand sumitabarahmand force-pushed the feature/repairswagger branch 2 times, most recently from 3682b28 to ec97de9 Compare November 15, 2018 05:10
@sumitabarahmand
Copy link
Contributor Author

The SDK is published: https://azuresdkci.westus2.cloudapp.azure.com/view/NetCore-SDK/job/NetCore-SDK-Publish/180/

@deathly809
Copy link
Member

@maddieclayton Seems the website tests failed,

Skipped  Microsoft.Azure.Commands.Websites.Test.ScenarioTests.WebAppBackupRestoreTests.TestRestoreDeletedWebAppToExisting
[xUnit.net 00:00:13.89]     Microsoft.Azure.Commands.Websites.Test.ScenarioTests.WebAppBackupRestoreTests.TestGetDeletedWebApp [FAIL]

and for default

0.9999002s ✘  Microsoft.Azure.Commands.Websites.Test.ScenarioTests.WebAppBackupRestoreTests.TestGetDeletedWebApp

@bganapa
Copy link
Member

bganapa commented Nov 15, 2018

ps-sign https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/ps-sign/1556/console

@bganapa
Copy link
Member

bganapa commented Nov 15, 2018

@sumitabarahmand
can you please edit these files for module version update
https://github.com/Azure/azure-powershell/blob/preview/src/StackAdmin/Azs.InfrastructureInsights.Admin/Module/Azs.InfrastructureInsights.Admin/Azs.Infrastructureinsights.Admin.psd1#L20
https://github.com/Azure/azure-powershell/blob/preview/src/StackAdmin/AzureStack/AzureStack.psd1#L62

otherwise it looks good to me

bganapa
bganapa previously approved these changes Nov 20, 2018
View reviewed changes
@bganapa
Copy link
Member

bganapa commented Nov 20, 2018

ps-sign - https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/ps-sign/1563/console

@maddieclayton
Copy link
Contributor

@bganapa Can you get @deathly809 to approve as well? His request for changes is blocking merge.

@sumitabarahmand sumitabarahmand force-pushed the feature/repairswagger branch 2 times, most recently from f8a6841 to 848f935 Compare November 21, 2018 03:18
@sumitabarahmand
add powershell module and test for alert repair SDK
bb3da11 
fix spacing

add hasvalidremediationaction check for repair tests

add changelog and update assembly version reference

fix typo

update references

Update assembly version and added negative unit tests for repair alert

fix spacing
@sumitabarahmand
Copy link
Contributor Author

Negative tests are added and all versions are updated.

bganapa
bganapa previously approved these changes Nov 21, 2018
View reviewed changes
@bganapa
Copy link
Member

bganapa commented Nov 21, 2018

@maddieclayton Thanks for looking at this PR. @deathly809 is OOF and his concern of adding a negative test case has been addressed now. The previous ps-sign failed due to module version mismatch..
a new one is running now https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/ps-sign/1565/

@deathly809
Copy link
Member

@maddieclayton Could you please merge this? Everything looks fine to us.

@maddieclayton maddieclayton merged commit dd84cdd into Azure:preview Nov 27, 2018
This was referenced Nov 28, 2018
Closed
Closed
cormacpayne added a commit to cormacpayne/azure-powershell that referenced this pull request Nov 28, 2018
@cormacpayne
Move changes from the following PRs into AzureRM branch:
d70895e 
- Azure#7742
- Azure#7762
- Azure#7911
@cormacpayne cormacpayne mentioned this pull request Nov 28, 2018
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deathly809 deathly809 deathly809 approved these changes

@bganapa bganapa bganapa left review comments

Assignees

@deathly809 deathly809

Labels
Azure Stack needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sumitabarahmand @adxsdkps @deathly809 @maddieclayton @bganapa @azuresdkci1x