Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AzureStack] Add help md files for new fabric admin cmdlet #7931

Closed
wants to merge 161 commits into from
Closed

[AzureStack] Add help md files for new fabric admin cmdlet #7931

wants to merge 161 commits into from

Conversation

zyxyoshine
Copy link
Contributor

Description

Checklist

Vini Soto and others added 30 commits September 18, 2018 21:58
cormacpayne and others added 16 commits November 27, 2018 09:20
Avoid  Get-Location hardcode in AnalysisServices.Test
[Azure Stack] Re-Generate Module Help
[RecoveryServices.Backup] Making storage account and RG name optional for AFS restore
Update example in New-AzureRmTag.md
Wrong command used in documentation example
Update Microsoft.DataTransfer.Gateway.Encryption to 3.11.6898.1 to consume nuget.org
Adding -AzureStorageAccounts parameter to Set-AzureRmWebApp and Set-AzureRmWebAppSlot
Fix the trailing slash of the domain of adls account
Tagging #if statements for Az
@zyxyoshine
Copy link
Contributor Author

zyxyoshine commented Nov 28, 2018

@bganapa @deathly809 Please help review.

Copy link
Member

@deathly809 deathly809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is your main module markdown file? It seems these cmdlets are new, and therefore that file should have been updated as well.

Copy link
Member

@deathly809 deathly809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing main module Markdown file.

@cormacpayne cormacpayne changed the base branch from preview to AzureRM November 28, 2018 21:30
@cormacpayne
Copy link
Member

@zyxyoshine @deathly809 moving forward, Stack PRs will need to target the AzureRM branch, not preview, so you may need to close this PR and open a new one that is based on the AzureRM branch (since this one is based on the preview branch and is bringing in a bunch of commits from the preview branch into AzureRM). I will work to bring in the Stack changes from the preview branch into AzureRM. It appears to be the following PRs:

@zyxyoshine
Copy link
Contributor Author

Close this PR and open a new one that is based on the AzureRM branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.