[ReleasePR redisenterprise] [Hub Generated] Review request for Microsoft.Cache to add version preview/2022-11-01-preview #2792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Hub Generated] Review request for Microsoft.Cache to add version preview/2022-11-01-preview (#21026) * Update example value for module argument * Adds base for updating Microsoft.Cache from version stable/2022-01-01 to version 2022-11-01-preview * Updates readme * Updates API version in new specs and examples * Add changes * Changes from feedback * Adding changes to fix checks * fix error * fix error * revert changes * change * Adds base for updating Microsoft.Cache from version stable/2022-01-01 to version 2022-11-01-preview * Updates readme * Updates API version in new specs and examples * Update spec and examples for redisenterprise 2022-11-01-preview * Fix update example by properly defining headers * Add identity to patch to satisfy linter * Improve description of keyId * Switch to v3 types and use ref for location/operation * Change missed v2 types to v3 * change keyId to keyUrl and add "format": "url" for it * Match common api contract This commit changes `encryption` field in the API spec to match the recommendation in the following repository and file: azure-resource-manager-rpc:v1.0/common-api-contracts.md#customer-managed-key-encryption * add identityType with description that states only userAssigned is supported * Update encryption description to say encryption-at-rest * fix(example): use correct API version in SKUs example * fixes for checks * updating from main * fix * change header * add headers subsection * updating 2022-01-01 * removing read only, adding location common types * Update specification/redisenterprise/resource-manager/Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json Co-authored-by: jantache-microsoft <jantache@microsoft.com> * review updates - for linter issues * edit * prettier fix --------- Co-authored-by: Riya Simon <riyasimon@microsoft.com> Co-authored-by: jantache-microsoft <jantache@microsoft.com>
ghost
added
the
ghost
approved these changes
Feb 14, 2023
There was a problem hiding this comment.
This PR has been auto-approved by the @msftbot for the azure-resource-manager-schemas repo.
11 tasks
|
Hello @msftbot[bot]! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 1 minute. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create to sync Azure/azure-rest-api-specs#21026
ReCreate this PR