Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.Cache to add version preview/2022-11-01-preview #21026

Merged
merged 42 commits into from
Feb 14, 2023
Merged

[Hub Generated] Review request for Microsoft.Cache to add version preview/2022-11-01-preview #21026

merged 42 commits into from
Feb 14, 2023

Conversation

riyasimon23
Copy link
Contributor

@riyasimon23 riyasimon23 commented Oct 6, 2022 •
edited
Loading

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @riyasimon23 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Oct 6, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️⚠️Breaking Change(Cross-Version): 4 Warnings warning [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    redisenterprise.json 2022-11-01-preview(e890834) 2022-01-01(main)
    redisenterprise.json 2022-11-01-preview(e890834) 2021-02-01-preview(main)

    The following breaking changes are detected by comparison with the latest preview version:

    Rule Message
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'sasUri' renamed or removed?
    New: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L1773:7
    Old: Microsoft.Cache/preview/2021-02-01-preview/redisenterprise.json#L1671:7
    ⚠️ 1034 - AddedRequiredProperty The new version has new required property 'sasUris' that was not found in the old version.
    New: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L1773:7
    Old: Microsoft.Cache/preview/2021-02-01-preview/redisenterprise.json#L1671:7
    ⚠️ 1034 - AddedRequiredProperty The new version has new required property 'sasUris' that was not found in the old version.
    New: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L808:13
    Old: Microsoft.Cache/preview/2021-02-01-preview/redisenterprise.json#L811:13
    ⚠️ 1034 - AddedRequiredProperty The new version has new required property 'sasUris' that was not found in the old version.
    New: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L1770:5
    Old: Microsoft.Cache/preview/2021-02-01-preview/redisenterprise.json#L1669:5
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️⚠️LintDiff: 2 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-preview-2022-11 package-preview-2022-11(e890834) default(main)

    [must fix]The following errors/warnings are introduced by current PR:

    Rule Message Related RPC [For API reviewers]
    ⚠️ LocationMustHaveXmsMutability Property location must have 'x-ms-mutability':['read', 'create'] extension defined.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L1852    		 RPC-Put-V1-14
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L1899


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L115
    ❌ CreateOperationAsyncResponseValidation An async PUT operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'azure-async-operation' on 'x-ms-long-running-operation-options'
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L116
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L220
    ❌ DeleteOperationAsyncResponseValidation An async DELETE operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options'
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L231
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L264
    ❌ ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L400
    ❌ ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L446
    ❌ ResourceNameRestriction The resource name parameter 'databaseName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L446
    ❌ CreateOperationAsyncResponseValidation An async PUT operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'azure-async-operation' on 'x-ms-long-running-operation-options'
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L447
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L562
    ❌ DeleteOperationAsyncResponseValidation An async DELETE operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options'
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L617
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L654
    ❌ ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L669
    ❌ ResourceNameRestriction The resource name parameter 'databaseName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L669
    ❌ ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L715
    ❌ ResourceNameRestriction The resource name parameter 'databaseName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L715
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L765
    ❌ ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L777
    ❌ ResourceNameRestriction The resource name parameter 'databaseName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L777
    ❌ PostOperationAsyncResponseValidation An async POST operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options'
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L778
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L824
    ❌ ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L836
    ❌ ResourceNameRestriction The resource name parameter 'databaseName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L836
    ❌ PostOperationAsyncResponseValidation An async POST operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options'
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L837
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L883
    ❌ GetCollectionResponseSchema The response in the GET collection operation 'PrivateEndpointConnections_List' does not match the response definition in the individual GET operation 'PrivateEndpointConnections_Get' .
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L895
    ❌ ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L895
    ❌ ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L940
    ❌ ResourceNameRestriction The resource name parameter 'privateEndpointConnectionName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L940
    ❌ CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L984
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️❌~[Staging] ServiceAPIReadinessTest: 23 Errors, 0 Warnings failed [Detail]

    Tag package-preview-2022-11; Prod region: Deployed

    Test run on region: westcentralus; Operation coverage: total: 24, untested: 0, failed: 21, passed: 3

    Service API Readiness Test failed. Check pipeline artifact for detail report.

    Rule Message
    ❌ CLIENT_ERROR statusCode: 403,
    errorCode: LinkedAuthorizationFailed,
    errorMessage: The client has permission to perform action 'Microsoft.ManagedIdentity/userAssignedIdentities/assign/action' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-eDLgks-21026/providers/Microsoft.Cache/redisEnterprise/clusterna8v1kr', however the linked subscription 'your-subscription' was not found.
    Source: runtime
    OperationId: RedisEnterprise_Create
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Cache/redisEnterprise/clusterna8v1kr' under resource group 'apiTest-eDLgks-21026' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: RedisEnterprise_Get
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Cache/redisEnterprise/clusterna8v1kr' under resource group 'apiTest-eDLgks-21026' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: RedisEnterprise_Update
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterna8v1kr' not found.
    Source: runtime
    OperationId: Databases_Create
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterna8v1kr' not found.
    Source: runtime
    OperationId: Databases_ListByCluster
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterna8v1kr' not found.
    Source: runtime
    OperationId: Databases_Get
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterna8v1kr' not found.
    Source: runtime
    OperationId: Databases_Update
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterna8v1kr' not found.
    Source: runtime
    OperationId: Databases_Import
    ❌ CLIENT_ERROR statusCode: 403,
    errorCode: LinkedAuthorizationFailed,
    errorMessage: The client has permission to perform action 'Microsoft.Cache/redisEnterprise/databases/write' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-eDLgks-21026/providers/Microsoft.Cache/redisEnterprise/clusterna8v1kr/databases/databasexqj6im', however the linked subscription 'db5eb68e-73e2-4fa8-b18a-46cd1be4cce52' was not found.
    Source: runtime
    OperationId: Databases_ForceUnlink
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterna8v1kr' not found.
    Source: runtime
    OperationId: Databases_RegenerateKey
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterna8v1kr' not found.
    Source: runtime
    OperationId: Databases_Export
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterna8v1kr' not found.
    Source: runtime
    OperationId: Databases_ListKeys
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterna8v1kr' not found.
    Source: runtime
    OperationId: PrivateEndpointConnections_Put
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterna8v1kr' not found.
    Source: runtime
    OperationId: PrivateEndpointConnections_List
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterna8v1kr' not found.
    Source: runtime
    OperationId: PrivateEndpointConnections_Get
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: properties
    Source: response
    OperationId: Operations_List
    ❌ SERVER_ERROR statusCode: 500,
    errorCode: InternalServerError,
    errorMessage: An error occurred in the resource provider. Please include the following details when you contact support: CorrelationID=50f3b391-7ca5-4df0-8734-fa54cc0e3052 RequestID=c0514e8c-a9fc-4807-a689-aa4c66faaae6 Timestamp=2/9/2023 6:45:46 PM (UTC)
    Source: runtime
    OperationId: OperationsStatus_Get
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: undefined,
    errorMessage: undefined
    Source: runtime
    OperationId: Skus_List
    ❌ INVALID_CONTENT_TYPE Invalid Content-Type (application/octet-stream). These are supported: application/json
    Source: response
    OperationId: Skus_List
    ❌ INVALID_RESPONSE_BODY Body is required in response but not provided
    Source: response
    OperationId: Skus_List
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterna8v1kr' not found.
    Source: runtime
    OperationId: PrivateLinkResources_ListByCluster
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterna8v1kr' not found.
    Source: runtime
    OperationId: PrivateEndpointConnections_Delete
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterna8v1kr' not found.
    Source: runtime
    OperationId: Databases_Delete
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand] 
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Oct 6, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking




    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 1352fc7. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.3 -> 9.4.2
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.4.2>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.4.2` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-redisenterprise [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation group SkusOperations
info	[Changelog]   - Model Cluster has a new parameter encryption
info	[Changelog]   - Model Cluster has a new parameter identity
info	[Changelog]   - Model Cluster has a new parameter system_data
info	[Changelog]   - Model ClusterUpdate has a new parameter encryption
info	[Changelog]   - Model ClusterUpdate has a new parameter identity
info	[Changelog]   - Model Database has a new parameter system_data
info	[Changelog]   - Model PrivateEndpointConnection has a new parameter system_data
info	[Changelog]   - Model PrivateLinkResource has a new parameter system_data
info	[Changelog]   - Model ProxyResource has a new parameter system_data
info	[Changelog]   - Model Resource has a new parameter system_data
info	[Changelog]   - Model TrackedResource has a new parameter system_data
    ️⚠️ azure-sdk-for-java warning [Detail]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 1352fc7. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/redisenterprise/armredisenterprise [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New type alias `CreatedByType` with values `CreatedByTypeApplication`, `CreatedByTypeKey`, `CreatedByTypeManagedIdentity`, `CreatedByTypeUser`
info	[Changelog] - New type alias `ManagedServiceIdentityType` with values `ManagedServiceIdentityTypeNone`, `ManagedServiceIdentityTypeSystemAssigned`, `ManagedServiceIdentityTypeSystemAssignedIdentity`, `ManagedServiceIdentityTypeSystemAssignedUserAssigned`, `ManagedServiceIdentityTypeUserAssigned`, `ManagedServiceIdentityTypeUserAssignedIdentity`
info	[Changelog] - New type alias `Name` with values `NameEnterpriseE10`, `NameEnterpriseE100`, `NameEnterpriseE20`, `NameEnterpriseE50`, `NameEnterpriseFlashF1500`, `NameEnterpriseFlashF300`, `NameEnterpriseFlashF700`
info	[Changelog] - New function `NewSKUsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*SKUsClient, error)`
info	[Changelog] - New function `*SKUsClient.NewListPager(string, *SKUsClientListOptions) *runtime.Pager[SKUsClientListResponse]`
info	[Changelog] - New function `timeRFC3339.MarshalText() ([]byte, error)`
info	[Changelog] - New function `*timeRFC3339.Parse(string) error`
info	[Changelog] - New function `*timeRFC3339.UnmarshalText([]byte) error`
info	[Changelog] - New struct `Capability`
info	[Changelog] - New struct `ClusterPropertiesEncryption`
info	[Changelog] - New struct `ClusterPropertiesEncryptionCustomerManagedKeyEncryption`
info	[Changelog] - New struct `ClusterPropertiesEncryptionCustomerManagedKeyEncryptionKeyIdentity`
info	[Changelog] - New struct `LocationInfo`
info	[Changelog] - New struct `ManagedServiceIdentity`
info	[Changelog] - New struct `RegionSKUDetail`
info	[Changelog] - New struct `RegionSKUDetails`
info	[Changelog] - New struct `SKUDetail`
info	[Changelog] - New struct `SKUsClient`
info	[Changelog] - New struct `SKUsClientListResponse`
info	[Changelog] - New struct `SystemData`
info	[Changelog] - New struct `UserAssignedIdentity`
info	[Changelog] - New field `Identity` in struct `Cluster`
info	[Changelog] - New field `SystemData` in struct `Cluster`
info	[Changelog] - New field `Encryption` in struct `ClusterProperties`
info	[Changelog] - New field `Identity` in struct `ClusterUpdate`
info	[Changelog] - New field `SystemData` in struct `Database`
info	[Changelog] - New field `SystemData` in struct `PrivateEndpointConnection`
info	[Changelog] - New field `SystemData` in struct `PrivateLinkResource`
info	[Changelog] - New field `SystemData` in struct `ProxyResource`
info	[Changelog] - New field `SystemData` in struct `Resource`
info	[Changelog] - New field `SystemData` in struct `TrackedResource`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 60 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 1352fc7. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-redisenterprisecache [View full logs]  [Release SDK Changes] 
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group Skus
info	[Changelog]   - Added Interface Capability
info	[Changelog]   - Added Interface ClusterPropertiesEncryption
info	[Changelog]   - Added Interface ClusterPropertiesEncryptionCustomerManagedKeyEncryption
info	[Changelog]   - Added Interface ClusterPropertiesEncryptionCustomerManagedKeyEncryptionKeyIdentity
info	[Changelog]   - Added Interface LocationInfo
info	[Changelog]   - Added Interface ManagedServiceIdentity
info	[Changelog]   - Added Interface RegionSkuDetail
info	[Changelog]   - Added Interface RegionSkuDetails
info	[Changelog]   - Added Interface SkuDetail
info	[Changelog]   - Added Interface SkusListOptionalParams
info	[Changelog]   - Added Interface SystemData
info	[Changelog]   - Added Interface UserAssignedIdentity
info	[Changelog]   - Added Type Alias CreatedByType
info	[Changelog]   - Added Type Alias ManagedServiceIdentityType
info	[Changelog]   - Added Type Alias Name
info	[Changelog]   - Added Type Alias SkusListResponse
info	[Changelog]   - Interface Cluster has a new optional parameter encryption
info	[Changelog]   - Interface Cluster has a new optional parameter identity
info	[Changelog]   - Interface ClusterUpdate has a new optional parameter encryption
info	[Changelog]   - Interface ClusterUpdate has a new optional parameter identity
info	[Changelog]   - Interface Resource has a new optional parameter systemData
info	[Changelog]   - Added Enum KnownCreatedByType
info	[Changelog]   - Added Enum KnownManagedServiceIdentityType
info	[Changelog]   - Added Enum KnownName
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 1352fc7. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️redisenterprise [View full logs]  [Release Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • ❌Failed [Logs]Release - Generate from 1352fc7. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ❌Az.redisenterprise [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Oct 6, 2022 •
    edited
    Loading

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/redisenterprise/armredisenterprise https://apiview.dev/Assemblies/Review/28e8c067069b4f1cad6ea77afb20c7ae
    .Net Azure.ResourceManager.RedisEnterprise https://apiview.dev/Assemblies/Review/a8c1dad9912644a8ad2cb7577319665d
    Java azure-resourcemanager-redisenterprise https://apiview.dev/Assemblies/Review/01bcbcafad6848b3b6ba16fde6f1e2c6
    JavaScript @azure/arm-redisenterprisecache https://apiview.dev/Assemblies/Review/dd2abea2823946e498c04710331774a4

    TimLovellSmith
    TimLovellSmith reviewed Oct 6, 2022
    View reviewed changes
    ...senterprise/resource-manager/Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json
    "x-ms-enum": {
    "name": "SkuName",
    "modelAsString": true
    }
    Copy link
    Member

    @TimLovellSmith TimLovellSmith Oct 6, 2022 •
    edited
    Loading

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    We should be able to refactor this out into its own definition and reference it in both places:
    `
    "definitions":{

    "SkuName": {
    "type": "string",
    "description": "The type of RedisEnterprise cluster to deploy. Possible values: (Enterprise_E10, EnterpriseFlash_F300 etc.)",
    "enum": [
    "Enterprise_E10",
    "Enterprise_E20",
    "Enterprise_E50",
    "Enterprise_E100",
    "EnterpriseFlash_F300",
    "EnterpriseFlash_F700",
    "EnterpriseFlash_F1500"
    ],
    "x-ms-enum": {
    "name": "SkuName",
    "modelAsString": true
    }
    }`

    and "name": { "$ref": "#Definitions/SkuName } (approx) #Closed

    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Added a new definition Sku Name and changed the two definitions to point to this reference

    TimLovellSmith
    TimLovellSmith requested changes Oct 6, 2022
    View reviewed changes
    Copy link
    Member

    @TimLovellSmith TimLovellSmith left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    🕐

    @openapi-workflow-bot openapi-workflow-bot bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 6, 2022
    @openapi-workflow-bot
    Copy link

    Hi, @riyasimon23 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @riyasimon23 riyasimon23 marked this pull request as ready for review October 6, 2022 23:20
    @openapi-workflow-bot
    Copy link

    Hi @riyasimon23, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
     If you need further help, please feedback via swagger feedback.

    @AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required resource-manager labels Oct 6, 2022
    @openapi-workflow-bot
    Copy link

    Hi @riyasimon23, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @azure-sdk azure-sdk mentioned this pull request Feb 9, 2023
    Draft
    @riyasimon23
    Copy link
    Contributor Author

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @riyasimon23
    Copy link
    Contributor Author

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @jantache-microsoft
    Copy link
    Member

    @akning-ms @TimLovellSmith @raosuhas

    I'm not sure who's the right person to do the merge - please do another review when you can and merge if it looks good.

    Thanks!

    @riyasimon23 riyasimon23 requested review from zizw123 and removed request for zizw123 February 9, 2023 21:36
    @TimLovellSmith
    Copy link
    Member

    @akning-ms ready to merge?

    @akning-ms akning-ms merged commit 1352fc7 into Azure:main Feb 14, 2023
    This was referenced Feb 14, 2023
    Merged
    Closed
    Closed
    Closed
    ghost pushed a commit to Azure/azure-resource-manager-schemas that referenced this pull request Feb 14, 2023
    [ReleasePR redisenterprise] [Hub Generated] Review request for Micros…
    fded924 
    …oft.Cache to add version preview/2022-11-01-preview (#2792)

Create to sync Azure/azure-rest-api-specs#21026
[ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/redisenterprise?expand=1)
    This was referenced Feb 14, 2023
    Closed
    Closed
    Closed
    aviyerMSFT pushed a commit to aviyerMSFT/azure-rest-api-specs that referenced this pull request Mar 22, 2023
    @riyasimon23 @jantache-microsoft @aviyerMSFT
    [Hub Generated] Review request for Microsoft.Cache to add version pre…
    d582bf6 
    …view/2022-11-01-preview (Azure#21026)

* Update example value for module argument

* Adds base for updating Microsoft.Cache from version stable/2022-01-01 to version 2022-11-01-preview

* Updates readme

* Updates API version in new specs and examples

* Add changes

* Changes from feedback

* Adding changes to fix checks

* fix error

* fix error

* revert changes

* change

* Adds base for updating Microsoft.Cache from version stable/2022-01-01 to version 2022-11-01-preview

* Updates readme

* Updates API version in new specs and examples

* Update spec and examples for redisenterprise 2022-11-01-preview

* Fix update example by properly defining headers

* Add identity to patch to satisfy linter

* Improve description of keyId

* Switch to v3 types and use ref for location/operation

* Change missed v2 types to v3

* change keyId to keyUrl and add "format": "url" for it

* Match common api contract

This commit changes `encryption` field in the API spec to match the
recommendation in the following repository and file:

azure-resource-manager-rpc:v1.0/common-api-contracts.md#customer-managed-key-encryption

* add identityType with description that states only userAssigned is supported

* Update encryption description to say encryption-at-rest

* fix(example): use correct API version in SKUs example

* fixes for checks

* updating from main

* fix

* change header

* add headers subsection

* updating 2022-01-01

* removing read only, adding location common types

* Update specification/redisenterprise/resource-manager/Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json

Co-authored-by: jantache-microsoft <jantache@microsoft.com>

* review updates - for linter issues

* edit

* prettier fix

---------

Co-authored-by: Riya Simon <riyasimon@microsoft.com>
Co-authored-by: jantache-microsoft <jantache@microsoft.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @jantache-microsoft jantache-microsoft jantache-microsoft left review comments

    @TimLovellSmith TimLovellSmith TimLovellSmith approved these changes

    @raosuhas raosuhas Awaiting requested review from raosuhas

    Assignees

    @akning-ms akning-ms

    Labels
    ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go CI-BreakingChange-JavaScript new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    6 participants
    @riyasimon23 @TimLovellSmith @akning-ms @jantache-microsoft @raosuhas @AzureRestAPISpecReview