Skip to content

Commit

Permalink
Microsft.Web 2023-12-01: Add int32 format to all number types in the…
Browse files Browse the repository at this point in the history
… scaleAndConcurrency section of the functionAppConfig (#29907)

* Set format to int32 for all number types in the functionAppConfig

* Update types to integer.

* Set format to int32 for all number types in the functionAppConfig

* Update types to integer.

* Add functionAppConfig types

---------

Co-authored-by: Naveed Aziz <naveeda@microsoft.com>
  • Loading branch information
Francisco-Gamino and naveedaz authored Jul 31, 2024
1 parent d886799 commit 52d55e5
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3673,7 +3673,8 @@
"description": "Either a function group or a function name is required. For additional information see https://aka.ms/flexconsumption/alwaysready."
},
"instanceCount": {
"type": "number",
"type": "integer",
"format": "int32",
"description": "Sets the number of 'Always Ready' instances for a given function group or a specific function. For additional information see https://aka.ms/flexconsumption/alwaysready."
}
}
Expand All @@ -3691,11 +3692,13 @@
},
"maximumInstanceCount": {
"description": "The maximum number of instances for the function app.",
"type": "number"
"type": "integer",
"format": "int32"
},
"instanceMemoryMB": {
"description": "Set the amount of memory allocated to each instance of the function app in MB. CPU and network bandwidth are allocated proportionally.",
"type": "number"
"type": "integer",
"format": "int32"
},
"triggers": {
"type": "object",
Expand All @@ -3706,7 +3709,8 @@
"description": "Scale and concurrency settings for the HTTP trigger.",
"properties": {
"perInstanceConcurrency": {
"type": "number",
"type": "integer",
"format": "int32",
"description": "The maximum number of concurrent HTTP trigger invocations per instance."
}
}
Expand Down
6 changes: 5 additions & 1 deletion specification/web/resource-manager/sdk-suppressions.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,8 @@ suppressions:
- Function `*EnvironmentsClient.BeginApproveOrRejectPrivateEndpointConnection` parameter(s) have been changed from `(context.Context, string, string, string, PrivateLinkConnectionApprovalRequestResource, *EnvironmentsClientBeginApproveOrRejectPrivateEndpointConnectionOptions)` to `(context.Context, string, string, string, RemotePrivateEndpointConnectionARMResource, *EnvironmentsClientBeginApproveOrRejectPrivateEndpointConnectionOptions)`
- Function `*StaticSitesClient.BeginApproveOrRejectPrivateEndpointConnection` parameter(s) have been changed from `(context.Context, string, string, string, PrivateLinkConnectionApprovalRequestResource, *StaticSitesClientBeginApproveOrRejectPrivateEndpointConnectionOptions)` to `(context.Context, string, string, string, RemotePrivateEndpointConnectionARMResource, *StaticSitesClientBeginApproveOrRejectPrivateEndpointConnectionOptions)`
- Function `*WebAppsClient.BeginApproveOrRejectPrivateEndpointConnectionSlot` parameter(s) have been changed from `(context.Context, string, string, string, string, PrivateLinkConnectionApprovalRequestResource, *WebAppsClientBeginApproveOrRejectPrivateEndpointConnectionSlotOptions)` to `(context.Context, string, string, string, string, RemotePrivateEndpointConnectionARMResource, *WebAppsClientBeginApproveOrRejectPrivateEndpointConnectionSlotOptions)`
- Function `*WebAppsClient.BeginApproveOrRejectPrivateEndpointConnection` parameter(s) have been changed from `(context.Context, string, string, string, PrivateLinkConnectionApprovalRequestResource, *WebAppsClientBeginApproveOrRejectPrivateEndpointConnectionOptions)` to `(context.Context, string, string, string, RemotePrivateEndpointConnectionARMResource, *WebAppsClientBeginApproveOrRejectPrivateEndpointConnectionOptions)`
- Function `*WebAppsClient.BeginApproveOrRejectPrivateEndpointConnection` parameter(s) have been changed from `(context.Context, string, string, string, PrivateLinkConnectionApprovalRequestResource, *WebAppsClientBeginApproveOrRejectPrivateEndpointConnectionOptions)` to `(context.Context, string, string, string, RemotePrivateEndpointConnectionARMResource, *WebAppsClientBeginApproveOrRejectPrivateEndpointConnectionOptions)`
- Type of `FunctionsAlwaysReadyConfig.InstanceCount` has been changed from `*float32` to `*int32`
- Type of `FunctionsScaleAndConcurrency.InstanceMemoryMB` has been changed from `*float32` to `*int32`
- Type of `FunctionsScaleAndConcurrency.MaximumInstanceCount` has been changed from `*float32` to `*int32`
- Type of `FunctionsScaleAndConcurrencyTriggersHTTP.PerInstanceConcurrency` has been changed from `*float32` to `*int32`

0 comments on commit 52d55e5

Please sign in to comment.