Microsft.Web 2023-12-01: Add int32 format to all number types in the scaleAndConcurrency section of the functionAppConfig #29907

Francisco-Gamino · 2024-07-18T18:42:28Z

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

New resource provider.
New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix OpenAPI spec quality issues in S360.
Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
Other, please clarify:

Update 2023-12-01 API version to add "format": "int32" to all number types in the scaleAndConcurrency section of the functionAppConfig.

In the latest Microsoft.Web API version, 2023-12-01, I introduced the functionAppConfig property bag to specify configuration for a Flex Consumption function app. In the scaleAndConcurrency section, I defined four properties (instanceCount, maximumInstanceCount, instanceMemoryMB, and perInstanceConcurrency) where the expected value is an integer. However, I specified the type as "type": "number" but did not include the "format" property. As a result, the Java SDK defaults to creating a float, while our backend service expects an integer, causing the requests to fail. To fix this issue, I am adding "format": "int32" to each of the four properties. Please note that this is the first time we are generating SDKs that include the functionAppConfig property bag, which is why we would like to fix it in the latest API version 2023-12-01.

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2024-07-18T18:42:32Z

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

openapi-pipeline-app · 2024-07-18T18:42:33Z

Swagger Generation Artifacts

️❌ApiDocPreview: 1 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` RestBuild error	"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=440225&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 "

️⚠️ azure-sdk-for-net-track2 warning [Detail]

FAQ

⚠️Warning in generating from c4bd295b7ac5eb26b76e4b5235a9b57304093e66. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] Get-ChildItem: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:787
cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
cmderr	[Invoke-GenerateAndBuildV2.ps1]  787 |  … rtifacts += Get-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s …
cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Cannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | it does not exist.

️✔️Azure.ResourceManager.AppService [Preview SDK Changes]
```
info	[Changelog]
```

️🔄 azure-sdk-for-python inProgress [Detail]

️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

FAQ

️✔️Succeeded in generating from c4bd295b7ac5eb26b76e4b5235a9b57304093e66. SDK Automation 14.0.0

command	./eng/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-appservice-generated [Preview SDK Changes]
```
info	[Changelog]
```

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

FAQ

️✔️Succeeded in generating from c4bd295b7ac5eb26b76e4b5235a9b57304093e66. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/appservice/armappservice [Preview SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `FunctionsAlwaysReadyConfig.InstanceCount` has been changed from `*float32` to `*int32`
info	[Changelog] - Type of `FunctionsScaleAndConcurrency.InstanceMemoryMB` has been changed from `*float32` to `*int32`
info	[Changelog] - Type of `FunctionsScaleAndConcurrency.MaximumInstanceCount` has been changed from `*float32` to `*int32`
info	[Changelog] - Type of `FunctionsScaleAndConcurrencyTriggersHTTP.PerInstanceConcurrency` has been changed from `*float32` to `*int32`
info	[Changelog]
info	[Changelog] Total 3 breaking change(s), 0 additive change(s).

Present SDK breaking changes suppressions
Function `*EnvironmentsClient.BeginApproveOrRejectPrivateEndpointConnection` parameter(s) have been changed from `(context.Context, string, string, string, PrivateLinkConnectionApprovalRequestResource, *EnvironmentsClientBeginApproveOrRejectPrivateEndpointConnectionOptions)` to `(context.Context, string, string, string, RemotePrivateEndpointConnectionARMResource, *EnvironmentsClientBeginApproveOrRejectPrivateEndpointConnectionOptions)`
Function `*StaticSitesClient.BeginApproveOrRejectPrivateEndpointConnection` parameter(s) have been changed from `(context.Context, string, string, string, PrivateLinkConnectionApprovalRequestResource, *StaticSitesClientBeginApproveOrRejectPrivateEndpointConnectionOptions)` to `(context.Context, string, string, string, RemotePrivateEndpointConnectionARMResource, *StaticSitesClientBeginApproveOrRejectPrivateEndpointConnectionOptions)`
Function `*WebAppsClient.BeginApproveOrRejectPrivateEndpointConnectionSlot` parameter(s) have been changed from `(context.Context, string, string, string, string, PrivateLinkConnectionApprovalRequestResource, *WebAppsClientBeginApproveOrRejectPrivateEndpointConnectionSlotOptions)` to `(context.Context, string, string, string, string, RemotePrivateEndpointConnectionARMResource, *WebAppsClientBeginApproveOrRejectPrivateEndpointConnectionSlotOptions)`
Function `*WebAppsClient.BeginApproveOrRejectPrivateEndpointConnection` parameter(s) have been changed from `(context.Context, string, string, string, PrivateLinkConnectionApprovalRequestResource, *WebAppsClientBeginApproveOrRejectPrivateEndpointConnectionOptions)` to `(context.Context, string, string, string, RemotePrivateEndpointConnectionARMResource, *WebAppsClientBeginApproveOrRejectPrivateEndpointConnectionOptions)`
Type of `FunctionsAlwaysReadyConfig.InstanceCount` has been changed from `*float32` to `*int32`
Type of `FunctionsScaleAndConcurrency.InstanceMemoryMB` has been changed from `*float32` to `*int32`
Type of `FunctionsScaleAndConcurrency.MaximumInstanceCount` has been changed from `*float32` to `*int32`
Type of `FunctionsScaleAndConcurrencyTriggersHTTP.PerInstanceConcurrency` has been changed from `*float32` to `*int32`

Please refer to the guidance for suppressing SDK breaking changes.

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

FAQ

️✔️Succeeded in generating from c4bd295b7ac5eb26b76e4b5235a9b57304093e66. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	Warning: File azure-sdk-for-js_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
cmderr	[automation_generate.sh] [ERROR] Cannot generate changelog because the codes of local and npm may be the same.

️✔️@azure/arm-appservice [Preview SDK Changes]
```
info	[Changelog]
```

️❌ azure-resource-manager-schemas failed [Detail]

FAQ

❌Code Generator Failed in generating from c4bd295b7ac5eb26b76e4b5235a9b57304093e66. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
cmderr	[initScript.sh] npm notice
cmderr	[initScript.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.2
cmderr	[initScript.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.2
cmderr	[initScript.sh] npm notice To update run: npm install -g npm@10.8.2
cmderr	[initScript.sh] npm notice
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
warn	Warning: File azure-resource-manager-schemas_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500
cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
cmderr	[generateScript.sh]            ^
cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500:12)
cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:504:19)
cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:739:36)
cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:955:32)
cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1043:43)
cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1046:12)
cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
warn	Warning: Package processing is skipped as the SDK generation fails. Please look into the above generation errors or report this issue through https://aka.ms/azsdk/support/specreview-channel.

️⚠️ azure-powershell warning [Detail]

FAQ

⚠️Warning in generating from c4bd295b7ac5eb26b76e4b5235a9b57304093e66. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

⚠️Az.web.DefaultTag [Preview SDK Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-07-18T18:42:33Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/appservice/armappservice	https://apiview.dev/Assemblies/Review/c727c406be7543caa08a79ce56dda352?revisionId=27297e9ddcff4c1883a0cf3c089fac6f
Java	azure-resourcemanager-appservice-generated	https://apiview.dev/Assemblies/Review/a2b80e4fbd144844bca0c504ef8c3337?revisionId=55e04f8f155546a19d81f8ff0423b335
JavaScript	@azure/arm-appservice	There is no API change compared with the previous version
.Net	Azure.ResourceManager.AppService	https://apiview.dev/Assemblies/Review/130e1fafd480482f83e1bdc3f68649a0?revisionId=ee358b2bf75b4c86bec895d0af4e7b23

Francisco-Gamino · 2024-07-18T18:43:45Z

/cc @naveedaz @nzthiago @pragnagopa @CooperLink

mikekistler

You should also change the type to integer.

specification/web/resource-manager/Microsoft.Web/stable/2023-12-01/CommonDefinitions.json

….com/Francisco-Gamino/azure-rest-api-specs into update-functionAppConfig-type-format

Francisco-Gamino · 2024-07-19T16:20:27Z

Hello @mikekistler -- Are there any more changes required for this PR? If not, when can we merge it? Thank you.

Francisco-Gamino · 2024-07-20T02:30:57Z

Hello @mikekistler -- Are there any more changes required for this PR? If not, when can we merge it? Thank you.

Thank you for the review @mikekistler. I will follow up with the SDK owners on the breaking changes.

weidongxu-microsoft · 2024-07-24T09:04:32Z

Java will take in the break, as previous float type won't be accepted by backend.

Alancere · 2024-07-29T05:56:16Z

Hi @raych1, please approve BreakingChange-Go-Sdk-Suppression, the current PR leads to the following Go SDK BreakingChange: (type form *float32 to *int32)

- Type of `FunctionsAlwaysReadyConfig.InstanceCount` has been changed from `*float32` to `*int32`
- Type of `FunctionsScaleAndConcurrency.InstanceMemoryMB` has been changed from `*float32` to `*int32`
- Type of `FunctionsScaleAndConcurrency.MaximumInstanceCount` has been changed from `*float32` to `*int32`
- Type of `FunctionsScaleAndConcurrencyTriggersHTTP.PerInstanceConcurrency` has been changed from `*float32` to `*int32`

Francisco-Gamino · 2024-07-29T16:23:41Z

Hello @mikekistler -- The SDK breaking changes have been approved. Could you please approve this PR? Thank you.

mikekistler

Looks good. 👍

Francisco-Gamino · 2024-07-30T20:21:37Z

Hello @mikekistler -- Could you please merge this PR since we are not authorized to merge it? Thanks in advance.

mikekistler · 2024-07-30T21:33:14Z

@Francisco-Gamino I do not have merge permissions. You can post in the Service API Toolset Teams channel for help with merging.

Francisco-Gamino · 2024-07-30T21:46:18Z

@Francisco-Gamino I do not have merge permissions. You can post in the Service API Toolset Teams channel for help with merging.

Will do. Thank you, @mikekistler.

Francisco-Gamino · 2024-07-30T22:15:05Z

/pr RequestMerge

ms-bogdan-rotaru · 2024-07-31T08:39:40Z

/azp run

azure-pipelines · 2024-07-31T08:39:57Z

Azure Pipelines successfully started running 3 pipeline(s).

… scaleAndConcurrency section of the functionAppConfig (Azure#29907) * Set format to int32 for all number types in the functionAppConfig * Update types to integer. --------- Co-authored-by: Naveed Aziz <naveeda@microsoft.com>

…scaleAndConcurrency section of the functionAppConfig (#30050) * Microsft.Web 2023-12-01: Add int32 format to all number types in the scaleAndConcurrency section of the functionAppConfig (#29907) * Set format to int32 for all number types in the functionAppConfig * Update types to integer. --------- Co-authored-by: Naveed Aziz <naveeda@microsoft.com> * Update types to integer and set format to int32 for all number types in the functionAppConfig --------- Co-authored-by: Naveed Aziz <naveeda@microsoft.com>

* Release web 2024 04 01 (#28952) * Copy files from stable/2023-12-01 Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to stable/2024-04-01 Updated the API version from stable/2023-12-01 to stable/2024-04-01. * Added tag for 2024-04-01 in readme file * Copy files from stable/2023-12-01 Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to stable/2024-04-01 Updated the API version from stable/2023-12-01 to stable/2024-04-01. * Added tag for 2024-04-01 in readme file * Copy files from stable/2023-12-01 Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to stable/2024-04-01 Updated the API version from stable/2023-12-01 to stable/2024-04-01. * Added tag for 2024-04-01 in readme file * Fix RP merge issue * Fix prettier failute * Fix spellcheck for sitecontainers * Fix prettier check failures * Fix ALL prettier check failures * Add LeastRequestsWithTieBreaker (#29128) * Add LeastRequestsWithTieBreaker * Change to target 2024-04-01 --------- Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com> * Update 2023-12-01 Microsoft.Web functionAppConfig definition (#29226) (#29350) * Update 2023-12-01 Microsoft.Web functionAppConfig definition (#29226) * Rename enum to functionsDeploymentStorageType * Update enum name to camel case * Update enum names to camel case * Port changes to 2024-04-01 API version * Rename storageType to FunctionsDeploymentStorageType * Update enum name's to use amelcase casing --------- Co-authored-by: Naveed Aziz <naveeda@microsoft.com> * Add SKU property to site. Add description for supported values of kin… (#29354) * Add SKU property to site. Add description for supported values of kind property on app * Fix typo * Fix prettier * User/rohinisharma/update instance info (#29333) * Adding parameter to Website Instance Info obj * Prettier --------- Co-authored-by: Rohini Sharma <rohinisharma@microsoft.com> Co-authored-by: Naveed Aziz <naveeda@microsoft.com> * [AppServices] Add AutoGeneratedDomainNameLabelScope to Websites (#29649) * [DNL] Add AutoGeneratedDomainNameLabelScope to Websites * fix casing * fix prettier * Add e2e tls to latest releases (#29904) Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com> * Add updatemachinekey api (#29730) * Add updatemachinekey api * fix json formatting * Change api version * Add machinekey to allowed words * action verb at end of address * Change post address to conform to arm --------- Co-authored-by: Naveed Aziz <naveeda@microsoft.com> * Developer/nineela/autogenerateddomainnamelabelscope edit 2 (#30047) * [DNL] Add AutoGeneratedDomainNameLabelScope to Websites * Minor comment update * Add IP Mode to Websites (#29089) * Add IP Mode to Websites * Target 2024-04-01 * Fix linter --------- Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com> Co-authored-by: Naveed Aziz <naveeda@microsoft.com> * Microsft.Web 2023-12-01: Add int32 format to all number types in the scaleAndConcurrency section of the functionAppConfig (#30050) * Microsft.Web 2023-12-01: Add int32 format to all number types in the scaleAndConcurrency section of the functionAppConfig (#29907) * Set format to int32 for all number types in the functionAppConfig * Update types to integer. --------- Co-authored-by: Naveed Aziz <naveeda@microsoft.com> * Update types to integer and set format to int32 for all number types in the functionAppConfig --------- Co-authored-by: Naveed Aziz <naveeda@microsoft.com> * Add CipherSuites object to support discoverability API (#30067) Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com> Co-authored-by: Naveed Aziz <naveeda@microsoft.com> --------- Co-authored-by: Chris Rosenblatt <rosench13@gmail.com> Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com> Co-authored-by: Francisco Gamino <Francisco-Gamino@users.noreply.github.com> Co-authored-by: rohinisharma <rohini2@illinois.edu> Co-authored-by: Rohini Sharma <rohinisharma@microsoft.com> Co-authored-by: nineela <82120829+nineela@users.noreply.github.com> Co-authored-by: andrewschuck <115187222+andrewschuck@users.noreply.github.com>

Set format to int32 for all number types in the functionAppConfig

67dcb8b

Francisco-Gamino requested a review from naveedaz as a code owner July 18, 2024 18:42

azure-sdk mentioned this pull request Jul 18, 2024

[AutoPR sdk/resourcemanager/appservice/armappservice] Microsft.Web 2023-12-01: Add int32 format to all number types in the scaleAndConcurrency section of the functionAppConfig azure-sdk/azure-sdk-for-go#10616

Closed

azure-sdk added the BreakingChange-Go-Sdk label Jul 18, 2024

azure-sdk mentioned this pull request Jul 18, 2024

[AutoPR azure-resourcemanager-appservice-generated] Microsft.Web 2023-12-01: Add int32 format to all number types in the scaleAndConcurrency section of the functionAppConfig azure-sdk/azure-sdk-for-java#11315

Closed

mikekistler requested changes Jul 19, 2024

View reviewed changes

specification/web/resource-manager/Microsoft.Web/stable/2023-12-01/CommonDefinitions.json Outdated Show resolved Hide resolved

Update types to integer.

1f4bf22

mikekistler added the BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior label Jul 19, 2024

Francisco-Gamino added 3 commits July 19, 2024 09:10

Set format to int32 for all number types in the functionAppConfig

e965c92

Update types to integer.

df2bd2c

Merge branch 'update-functionAppConfig-type-format' of https://github…

2d8b474

….com/Francisco-Gamino/azure-rest-api-specs into update-functionAppConfig-type-format

AzureRestAPISpecReview added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview labels Jul 19, 2024

Add functionAppConfig types

aadecf2

Francisco-Gamino force-pushed the update-functionAppConfig-type-format branch from 9eef57a to aadecf2 Compare July 19, 2024 19:01

openapi-pipeline-app bot added the BreakingChange-Go-Sdk-Suppression label Jul 19, 2024

azure-sdk removed the BreakingChange-Go-Sdk label Jul 19, 2024

razvanbadea-msft added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jul 23, 2024

openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 23, 2024

weidongxu-microsoft mentioned this pull request Jul 29, 2024

mgmt, support webapp flex one deploy Azure/azure-sdk-for-java#41328

Merged

6 tasks

raych1 added the BreakingChange-Go-Sdk-Suppression-Approved label Jul 29, 2024

mikekistler approved these changes Jul 29, 2024

View reviewed changes

Merge branch 'main' into update-functionAppConfig-type-format

f4fbad1

naveedaz approved these changes Jul 29, 2024

View reviewed changes

naveedaz added 2 commits July 29, 2024 16:41

Merge branch 'main' into update-functionAppConfig-type-format

4dec3ec

Merge branch 'main' into update-functionAppConfig-type-format

54bb333

naveedaz self-assigned this Jul 30, 2024

Merge branch 'main' into update-functionAppConfig-type-format

cd1c0ac

microsoft-github-policy-service bot added the MergeRequested label Jul 30, 2024

Merge branch 'main' into update-functionAppConfig-type-format

f9be68c

ms-bogdan-rotaru merged commit 52d55e5 into Azure:main Jul 31, 2024
26 of 30 checks passed

Francisco-Gamino mentioned this pull request Aug 1, 2024

Microsft.Web 2023-12-01: Add int32 format to all number types in the scaleAndConcurrency section of the functionAppConfig #30050

Merged

8 tasks

Alancere mentioned this pull request Aug 8, 2024

[Release] sdk/resourcemanager/appservice/armappservice/4.0.0 Azure/azure-sdk-for-go#23296

Merged

naveedaz mentioned this pull request Sep 9, 2024

Release web 2024 04 01 #30415

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Microsft.Web 2023-12-01: Add int32 format to all number types in the scaleAndConcurrency section of the functionAppConfig #29907

Microsft.Web 2023-12-01: Add int32 format to all number types in the scaleAndConcurrency section of the functionAppConfig #29907

Francisco-Gamino commented Jul 18, 2024

openapi-pipeline-app bot commented Jul 18, 2024 •

edited

Loading

openapi-pipeline-app bot commented Jul 18, 2024 •

edited

Loading

openapi-pipeline-app bot commented Jul 18, 2024 •

edited

Loading

Francisco-Gamino commented Jul 18, 2024

mikekistler left a comment

Francisco-Gamino commented Jul 19, 2024 •

edited

Loading

Francisco-Gamino commented Jul 20, 2024

weidongxu-microsoft commented Jul 24, 2024

Alancere commented Jul 29, 2024

Francisco-Gamino commented Jul 29, 2024

mikekistler left a comment

Francisco-Gamino commented Jul 30, 2024

mikekistler commented Jul 30, 2024

Francisco-Gamino commented Jul 30, 2024

Francisco-Gamino commented Jul 30, 2024

ms-bogdan-rotaru commented Jul 31, 2024

azure-pipelines bot commented Jul 31, 2024

Microsft.Web 2023-12-01: Add int32 format to all number types in the scaleAndConcurrency section of the functionAppConfig #29907

Microsft.Web 2023-12-01: Add int32 format to all number types in the scaleAndConcurrency section of the functionAppConfig #29907

Conversation

Francisco-Gamino commented Jul 18, 2024

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Additional information

Getting help

openapi-pipeline-app bot commented Jul 18, 2024 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Jul 18, 2024 • edited Loading

Swagger Generation Artifacts

openapi-pipeline-app bot commented Jul 18, 2024 • edited Loading

Generated ApiView

Francisco-Gamino commented Jul 18, 2024

mikekistler left a comment

Choose a reason for hiding this comment

Francisco-Gamino commented Jul 19, 2024 • edited Loading

Francisco-Gamino commented Jul 20, 2024

weidongxu-microsoft commented Jul 24, 2024

Alancere commented Jul 29, 2024

Francisco-Gamino commented Jul 29, 2024

mikekistler left a comment

Choose a reason for hiding this comment

Francisco-Gamino commented Jul 30, 2024

mikekistler commented Jul 30, 2024

Francisco-Gamino commented Jul 30, 2024

Francisco-Gamino commented Jul 30, 2024

ms-bogdan-rotaru commented Jul 31, 2024

azure-pipelines bot commented Jul 31, 2024

openapi-pipeline-app bot commented Jul 18, 2024 •

edited

Loading

openapi-pipeline-app bot commented Jul 18, 2024 •

edited

Loading

openapi-pipeline-app bot commented Jul 18, 2024 •

edited

Loading

Francisco-Gamino commented Jul 19, 2024 •

edited

Loading