[AppServices] Add AutoGeneratedDomainNameLabelScope to Websites #29649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nineela
requested review from
msyyc,
tadelesh,
jsntcy,
qiaozha and
naveedaz
as code owners
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Validation Report
|
| Compared specs (v0.10.12) | new version | base version |
|---|---|---|
| CommonDefinitions.json | 2024-04-01(33e0e52) | 2023-12-01(main) |
️⚠️LintDiff: 0 Warnings warning [Detail]
| Compared specs (v2.2.2) | new version | base version |
|---|---|---|
| package-2024-04 | package-2024-04(33e0e52) | package-2024-04(release-web-2024-04-01) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The response in the GET collection operation 'Recommendations_ListRecommendedRulesForHostingEnvironment' does not match the response definition in the individual GET operation 'Recommendations_GetRuleDetailsByHostingEnvironment' . Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L17 |
|
The response in the GET collection operation 'Recommendations_ListRecommendedRulesForWebApp' does not match the response definition in the individual GET operation 'Recommendations_GetRuleDetailsByWebApp' . Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L17 |
|
The response in the GET collection operation 'WebApps_ListRelayServiceConnections' does not match the response definition in the individual GET operation 'WebApps_GetRelayServiceConnection' . Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L17 |
|
The response in the GET collection operation 'WebApps_ListRelayServiceConnectionsSlot' does not match the response definition in the individual GET operation 'WebApps_GetRelayServiceConnectionSlot' . Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L17 |
|
The response in the GET collection operation 'WebApps_ListPremierAddOns' does not match the response definition in the individual GET operation 'WebApps_GetPremierAddOn' . Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L17 |
|
The response in the GET collection operation 'WebApps_ListPremierAddOnsSlot' does not match the response definition in the individual GET operation 'WebApps_GetPremierAddOnSlot' . Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L17 |
|
Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L684 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L713 |
|
ProvisioningState must have terminal states: Succeeded, Failed and Canceled. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L981 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L1024 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L1800 |
|
The nested resource 'HybridConnection' does not have list operation, please add it. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L1819 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L1978 |
|
Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L2252 |
|
Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L3097 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L3619 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L4161 |
|
The nested resource 'VnetGateway' does not have list operation, please add it. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L4328 |
|
The nested resource 'VnetInfoResource' does not have list operation, please add it. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L4405 |
|
The nested resource 'VnetRoute' does not have list operation, please add it. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L4422 |
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L125 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L147 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L190 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L286 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L291 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L306 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L325 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L334 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L343 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Web/stable/2024-04-01/CommonDefinitions.json#L382 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
nineela
changed the title
AzureRestAPISpecReview
added
ARMReview
CI-RpaaSRPNotInPrivateRepo
data-plane
new-api-version
new-rp-namespace
NotReadyForARMReview
resource-manager
RPaaS
SuppressionReviewRequired
TypeSpec
AzureRestAPISpecReview
added
WaitForARMFeedback
|
specification/web/resource-manager/Microsoft.Web/stable/2024-04-01/CommonDefinitions.json
Outdated
Show resolved
Hide resolved
dipeshbhakat-microsoft
requested changes
Jul 2, 2024
nineela
added
IDCDevDiv
ARMSignedOff
openapi-pipeline-app
bot
removed
the
WaitForARMFeedback
nineela
added
WaitForARMFeedback
dipeshbhakat-microsoft
added
the
ARMSignedOff
openapi-pipeline-app
bot
removed
the
WaitForARMFeedback
dipeshbhakat-microsoft
approved these changes
Jul 8, 2024
dipeshbhakat-microsoft
merged commit b119dc3
into
Azure:release-web-2024-04-01
23 of 29 checks passed
naveedaz
added a commit
that referenced
this pull request
Sep 26, 2024
* Release web 2024 04 01 (#28952) * Copy files from stable/2023-12-01 Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to stable/2024-04-01 Updated the API version from stable/2023-12-01 to stable/2024-04-01. * Added tag for 2024-04-01 in readme file * Copy files from stable/2023-12-01 Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to stable/2024-04-01 Updated the API version from stable/2023-12-01 to stable/2024-04-01. * Added tag for 2024-04-01 in readme file * Copy files from stable/2023-12-01 Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to stable/2024-04-01 Updated the API version from stable/2023-12-01 to stable/2024-04-01. * Added tag for 2024-04-01 in readme file * Fix RP merge issue * Fix prettier failute * Fix spellcheck for sitecontainers * Fix prettier check failures * Fix ALL prettier check failures * Add LeastRequestsWithTieBreaker (#29128) * Add LeastRequestsWithTieBreaker * Change to target 2024-04-01 --------- Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com> * Update 2023-12-01 Microsoft.Web functionAppConfig definition (#29226) (#29350) * Update 2023-12-01 Microsoft.Web functionAppConfig definition (#29226) * Rename enum to functionsDeploymentStorageType * Update enum name to camel case * Update enum names to camel case * Port changes to 2024-04-01 API version * Rename storageType to FunctionsDeploymentStorageType * Update enum name's to use amelcase casing --------- Co-authored-by: Naveed Aziz <naveeda@microsoft.com> * Add SKU property to site. Add description for supported values of kin… (#29354) * Add SKU property to site. Add description for supported values of kind property on app * Fix typo * Fix prettier * User/rohinisharma/update instance info (#29333) * Adding parameter to Website Instance Info obj * Prettier --------- Co-authored-by: Rohini Sharma <rohinisharma@microsoft.com> Co-authored-by: Naveed Aziz <naveeda@microsoft.com> * [AppServices] Add AutoGeneratedDomainNameLabelScope to Websites (#29649) * [DNL] Add AutoGeneratedDomainNameLabelScope to Websites * fix casing * fix prettier * Add e2e tls to latest releases (#29904) Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com> * Add updatemachinekey api (#29730) * Add updatemachinekey api * fix json formatting * Change api version * Add machinekey to allowed words * action verb at end of address * Change post address to conform to arm --------- Co-authored-by: Naveed Aziz <naveeda@microsoft.com> * Developer/nineela/autogenerateddomainnamelabelscope edit 2 (#30047) * [DNL] Add AutoGeneratedDomainNameLabelScope to Websites * Minor comment update * Add IP Mode to Websites (#29089) * Add IP Mode to Websites * Target 2024-04-01 * Fix linter --------- Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com> Co-authored-by: Naveed Aziz <naveeda@microsoft.com> * Microsft.Web 2023-12-01: Add int32 format to all number types in the scaleAndConcurrency section of the functionAppConfig (#30050) * Microsft.Web 2023-12-01: Add int32 format to all number types in the scaleAndConcurrency section of the functionAppConfig (#29907) * Set format to int32 for all number types in the functionAppConfig * Update types to integer. --------- Co-authored-by: Naveed Aziz <naveeda@microsoft.com> * Update types to integer and set format to int32 for all number types in the functionAppConfig --------- Co-authored-by: Naveed Aziz <naveeda@microsoft.com> * Add CipherSuites object to support discoverability API (#30067) Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com> Co-authored-by: Naveed Aziz <naveeda@microsoft.com> --------- Co-authored-by: Chris Rosenblatt <rosench13@gmail.com> Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com> Co-authored-by: Francisco Gamino <Francisco-Gamino@users.noreply.github.com> Co-authored-by: rohinisharma <rohini2@illinois.edu> Co-authored-by: Rohini Sharma <rohinisharma@microsoft.com> Co-authored-by: nineela <82120829+nineela@users.noreply.github.com> Co-authored-by: andrewschuck <115187222+andrewschuck@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.