-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ServiceBus : Swagger Split and Added PrivateEndPointConnection API #10071
ServiceBus : Swagger Split and Added PrivateEndPointConnection API #10071
Conversation
[Staging] Swagger Validation Report
️✔️ |
Rule | Message |
---|---|
INCONSISTENT_API_VERSION |
The API version of the swagger is inconsistent with its file path. readme: specification/servicebus/resource-manager/readme.md json: resource-manager/common/v1/definitions.json |
️️✔️
ModelValidation [Detail]
️✔️
Validation passes for ModelValidation.
️️✔️
SemanticValidation [Detail]
️✔️
Validation passes for SemanticValidation.
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-java - Release
|
azure-sdk-for-go - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-js - Release
|
azure-sdk-for-net - Release
|
Can one of the admins verify this patch? |
@v-Ajnava, could you please fix all the errors from tool check? |
In case there is no new API been added ARM API review is not required. Removing the tag, please add with details why ARM API review is required. |
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure Pipelines successfully started running 1 pipeline(s). |
4 similar comments
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
…into SBSplitSwaggerPrivateEndpoint
Azure Pipelines successfully started running 1 pipeline(s). |
@lirenhe all required CI have passed, can you please review the PR ? |
@@ -1,1437 +0,0 @@ | |||
{ | |||
"swagger": "2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
swagger [](start = 3, length = 7)
Was the deleted file split into all the files in the same directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"swagger": "2.0",
Was the deleted file split into all the files in the same directory?
Refers to: specification/servicebus/resource-manager/Microsoft.ServiceBus/stable/2017-04-01/servicebus.json:2 in 792f037. [](commit_id = 792f037, deletion_comment = True)
yes, the deleted file is split in all the files in the same directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed off from ARM side.
…into SBSplitSwaggerPrivateEndpoint # Conflicts: # custom-words.txt
Azure Pipelines successfully started running 1 pipeline(s). |
@lirenhe , can you please review the PR |
…zure#10071) * Swagger Split and Added PrivateEndPointConnection API * updated custom-words.txt * prettier check fix * updated Readme * removed the ub-referenced file * Operations API * fix avocado * fix for UniqueXmsEnumName * updated description * update * updated resource * fix for modelvalidation * version update in definition * added examples * updated examples * fix for avocado - INCONSISTENT_API_VERSION * updated azureresourceschema.md
…into formrecognizer_regeneration * 'master' of https://github.com/Azure/azure-rest-api-specs: (545 commits) Changes for new api version sdk generate (Azure#10685) Update batch sdk comments (Azure#10517) Dev StreamAnalytics 2017-04-01-preview version for streaming job and 2020-03-01-preview version for dedicated cluster (Azure#10673) Bump node-fetch from 2.6.0 to 2.6.1 in /.azure-pipelines-preproduction (Azure#10762) Spark Compute Isolation enabled (Azure#10726) [Hub Generated] Review request for Microsoft.BareMetalInfrastructure to add version preview/2020-08-06-preview (Azure#10677) PostgreSQL Flexible Server New API Swagger Changes (Azure#10586) Bump node-fetch from 2.6.0 to 2.6.1 (Azure#10760) Swagger changes. Remove weekly and monthly options from replicationSchedule enum (Azure#10752) modify description of properties to be self consistent (Azure#10711) Adding ComputeInstance to preview swagger (Azure#10654) remove unsupported reversproxy and useTestExtension (Azure#10728) Dev deviceprovisioningservices microsoft.devices 2020 09 01 preview (Azure#10735) FR v2.1-preview.1 update (Azure#10747) ServiceBus : Swagger Split and Added PrivateEndPointConnection API (Azure#10071) Eventhub: Added PrivateEndpointConnection API (Azure#10635) codegen onboard df for cli (Azure#8531) Update swagger for outbound public ip feature (Azure#10713) 2020-09-01-hybrid profile for AzureStack (Azure#10295) Update pull_request_assignment.yml (Azure#10724) ...
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.