Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceBus : Swagger Split and Added PrivateEndPointConnection API #10071

Merged
merged 20 commits into from
Sep 10, 2020

Conversation

v-Ajnava
Copy link
Member

@v-Ajnava v-Ajnava commented Jul 8, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
    • adding/removing APIs.
    • adding/removing properties.
    • adding/removing API-version.
    • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@v-Ajnava v-Ajnava added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 8, 2020
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 8, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
Avocado: 1 Errors, 0 Warnings [Detail] [Expand]
Rule Message
INCONSISTENT_API_VERSION The API version of the swagger is inconsistent with its file path.
readme: specification/servicebus/resource-manager/readme.md
json: resource-manager/common/v1/definitions.json
️✔️ModelValidation [Detail]
 Validation passes for ModelValidation. 
️✔️SemanticValidation [Detail]
 Validation passes for SemanticValidation. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 8, 2020

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 5892437 with merge commit 3f4d11b. SDK Automation 13.0.17.20200909.5
    Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-java/pull/3790: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 10 Sep 2020 08:22:36 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"0404:2837:231574B:4E55D98:5F59E24B","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4746","x-ratelimit-reset":"1599726632","x-ratelimit-used":"254","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-java/git/refs/heads/sdkAutomation/sdk_servicebus_mgmt-v2017_04_01@10071","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest/reference/git#delete-a-reference"}
    Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-java/pull/3433: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 10 Sep 2020 08:22:37 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"0405:3D17:21A0474:4BDA321:5F59E24C","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4743","x-ratelimit-reset":"1599726632","x-ratelimit-used":"257","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-java/git/refs/heads/sdkAutomation/sdk_servicebus_mgmt-v2018_01_01_preview@10071","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest/reference/git#delete-a-reference"}
  • ️✔️sdk/servicebus/mgmt-v2015_08_01 [View full logs]  [Release SDK Changes]
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 10 Sep 2020 08:29:39 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0400:B506:230A7421:2A493476:5F59E3F2","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
  • ⚠️sdk/servicebus/mgmt-v2017_04_01 [View full logs]  [Release SDK Changes]
      [mvn] [ERROR] COMPILATION ERROR : 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/servicebus/mgmt-v2017_04_01/src/main/java/com/microsoft/azure/management/servicebus/v2017_04_01/implementation/PremiumMessagingRegionImpl.java:[16,92] type argument com.microsoft.azure.management.servicebus.v2017_04_01.implementation.PremiumMessagingRegionInner is not within bounds of type-variable InnerModelT
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/servicebus/mgmt-v2017_04_01/src/main/java/com/microsoft/azure/management/servicebus/v2017_04_01/implementation/PremiumMessagingRegionsImpl.java:[21,122] type argument com.microsoft.azure.management.servicebus.v2017_04_01.implementation.PremiumMessagingRegionInner is not within bounds of type-variable InnerT
      [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-servicebus: Compilation failure: Compilation failure: 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/servicebus/mgmt-v2017_04_01/src/main/java/com/microsoft/azure/management/servicebus/v2017_04_01/implementation/PremiumMessagingRegionImpl.java:[16,92] type argument com.microsoft.azure.management.servicebus.v2017_04_01.implementation.PremiumMessagingRegionInner is not within bounds of type-variable InnerModelT
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/servicebus/mgmt-v2017_04_01/src/main/java/com/microsoft/azure/management/servicebus/v2017_04_01/implementation/PremiumMessagingRegionsImpl.java:[21,122] type argument com.microsoft.azure.management.servicebus.v2017_04_01.implementation.PremiumMessagingRegionInner is not within bounds of type-variable InnerT
      [mvn] [ERROR] -> [Help 1]
      [mvn] [ERROR] 
      [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
      [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
      [mvn] [ERROR] 
      [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
      [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 10 Sep 2020 08:29:50 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0402:6DAD:2693D1D:59EF8E1:5F59E3FE","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
    • ⚠️sdk/servicebus/mgmt-v2018_01_01_preview [View full logs]  [Release SDK Changes]
        [mvn] [ERROR] COMPILATION ERROR : 
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/servicebus/mgmt-v2018_01_01_preview/src/main/java/com/microsoft/azure/management/servicebus/v2018_01_01_preview/implementation/PremiumMessagingRegionsImpl.java:[21,122] type argument com.microsoft.azure.management.servicebus.v2018_01_01_preview.implementation.PremiumMessagingRegionInner is not within bounds of type-variable InnerT
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/servicebus/mgmt-v2018_01_01_preview/src/main/java/com/microsoft/azure/management/servicebus/v2018_01_01_preview/implementation/PremiumMessagingRegionImpl.java:[16,92] type argument com.microsoft.azure.management.servicebus.v2018_01_01_preview.implementation.PremiumMessagingRegionInner is not within bounds of type-variable InnerModelT
        [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-servicebus: Compilation failure: Compilation failure: 
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/servicebus/mgmt-v2018_01_01_preview/src/main/java/com/microsoft/azure/management/servicebus/v2018_01_01_preview/implementation/PremiumMessagingRegionsImpl.java:[21,122] type argument com.microsoft.azure.management.servicebus.v2018_01_01_preview.implementation.PremiumMessagingRegionInner is not within bounds of type-variable InnerT
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/servicebus/mgmt-v2018_01_01_preview/src/main/java/com/microsoft/azure/management/servicebus/v2018_01_01_preview/implementation/PremiumMessagingRegionImpl.java:[16,92] type argument com.microsoft.azure.management.servicebus.v2018_01_01_preview.implementation.PremiumMessagingRegionInner is not within bounds of type-variable InnerModelT
        [mvn] [ERROR] -> [Help 1]
        [mvn] [ERROR] 
        [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
        [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
        [mvn] [ERROR] 
        [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
        [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
        Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 10 Sep 2020 08:30:00 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0401:11AD:60B33B:10CBFFA:5F59E408","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Jul 8, 2020

      azure-sdk-for-go - Release

      failed [Logs] [Expand Details]
      • Generate from 5892437 with merge commit 3f4d11b. SDK Automation 13.0.17.20200909.5
        [AutoRest] FATAL: System.InvalidOperationException: output-folder must not be under a preview subdirectory for stable swagger set Microsoft.ServiceBus/preview/2018-01-01-preview/IPFilterRules-preview.json, Microsoft.ServiceBus/preview/2018-01-01-preview/namespace-preview.json, Microsoft.ServiceBus/preview/2018-01-01-preview/NetworkRuleSet-preview.json, Microsoft.ServiceBus/preview/2018-01-01-preview/VirtualNetworkRules-preview.json, Microsoft.ServiceBus/preview/2018-01-01-preview/operationlist-preview.json, Microsoft.ServiceBus/stable/2017-04-01/AuthorizationRules.json, Microsoft.ServiceBus/stable/2017-04-01/CheckNameAvailability.json, Microsoft.ServiceBus/stable/2017-04-01/DisasterRecoveryConfig.json, Microsoft.ServiceBus/stable/2017-04-01/eventhubs.json, Microsoft.ServiceBus/stable/2017-04-01/migrate.json, Microsoft.ServiceBus/stable/2017-04-01/migrationconfigs.json, Microsoft.ServiceBus/stable/2017-04-01/PremiumMessagingRegions.json, Microsoft.ServiceBus/stable/2017-04-01/Queue.json, Microsoft.ServiceBus/stable/2017-04-01/sku.json, Microsoft.ServiceBus/stable/2017-04-01/subscriptions.json, Microsoft.ServiceBus/stable/2017-04-01/topics.json, Microsoft.ServiceBus/stable/2017-04-01/Rules.json
        [AutoRest]    at AutoRest.Go.CodeGeneratorGo.PreviewCheck(String folder) in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 186
        [AutoRest]    at AutoRest.Go.CodeGeneratorGo.d__7.MoveNext() in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 60
        [AutoRest] --- End of stack trace from previous location where exception was thrown ---
        [AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
        [AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
        [AutoRest]    at AutoRest.Go.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 107
        [AutoRest] --- End of stack trace from previous location where exception was thrown ---
        [AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
        [AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
        [AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
        [AutoRest]    at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
        [AutoRest] FATAL: go/generate - FAILED
        [AutoRest] FATAL: Error: Plugin go reported failure.
        [AutoRest] Failure during batch task - {"tag":"package-2018-01-preview"} -- Error: Plugin go reported failure..
        [AutoRest]   Error: Plugin go reported failure.
        Failed to run autorest.
        Error: /z/node_modules/.bin/autorest --use=@microsoft.azure/autorest.go@~2.1.155 --go --verbose --multiapi --use-onever --preview-chk --version=V2 --go-sdk-folder=/z/work/src/github.com/Azure/azure-sdk-for-go /z/work/azure-rest-api-specs/specification/servicebus/resource-manager/readme.md FATAL: System.InvalidOperationException: output-folder must not be under a preview subdirectory for stable swagger set Microsoft.ServiceBus/preview/2018-01-01-preview/IPFilterRules-preview.json, Microsoft.ServiceBus/preview/2018-01-01-preview/namespace-preview.json, Microsoft.ServiceBus/preview/2018-01-01-preview/NetworkRuleSet-preview.json, Microsoft.ServiceBus/preview/2018-01-01-preview/VirtualNetworkRules-preview.json, Microsoft.ServiceBus/preview/2018-01-01-preview/operationlist-preview.json, Microsoft.ServiceBus/stable/2017-04-01/AuthorizationRules.json, Microsoft.ServiceBus/stable/2017-04-01/CheckNameAvailability.json, Microsoft.ServiceBus/stable/2017-04-01/DisasterRecoveryConfig.json, Microsoft.ServiceBus/stable/2017-04-01/eventhubs.json, Microsoft.ServiceBus/stable/2017-04-01/migrate.json, Microsoft.ServiceBus/stable/2017-04-01/migrationconfigs.json, Microsoft.ServiceBus/stable/2017-04-01/PremiumMessagingRegions.json, Microsoft.ServiceBus/stable/2017-04-01/Queue.json, Microsoft.ServiceBus/stable/2017-04-01/sku.json, Microsoft.ServiceBus/stable/2017-04-01/subscriptions.json, Microsoft.ServiceBus/stable/2017-04-01/topics.json, Microsoft.ServiceBus/stable/2017-04-01/Rules.json
           at AutoRest.Go.CodeGeneratorGo.PreviewCheck(String folder) in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 186
           at AutoRest.Go.CodeGeneratorGo.d__7.MoveNext() in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 60
        --- End of stack trace from previous location where exception was thrown ---
           at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
           at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
           at AutoRest.Go.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 107
        --- End of stack trace from previous location where exception was thrown ---
           at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
           at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
           at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
           at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
        FATAL: go/generate - FAILED
        FATAL: Error: Plugin go reported failure.
        Failure during batch task - {"tag":"package-2018-01-preview"} -- Error: Plugin go reported failure..
          Error: Plugin go reported failure.
        , {} 
        Failed to find any diff after autorest so no changed packages was found.

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Jul 8, 2020

      Trenton Generation - Release

      No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Jul 8, 2020

      Azure CLI Extension Generation - Release

      No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Jul 8, 2020

      azure-sdk-for-python - Release

      - Breaking Change detected in SDK

      ⚠️ warning [Logs] [Expand Details]
      • ⚠️ Generate from 5892437 with merge commit 3f4d11b. SDK Automation 13.0.17.20200909.5
        Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-python/pull/1946: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 10 Sep 2020 08:22:16 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"07C1:B2ED:1DC58FBD:23FE5F35:5F59E237","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4797","x-ratelimit-reset":"1599726632","x-ratelimit-used":"203","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-python/git/refs/heads/sdkAutomation/azure-mgmt-servicebus@10071","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest/reference/git#delete-a-reference"}
      • ⚠️azure-mgmt-servicebus [View full logs]  [Release SDK Changes] Breaking Change Detected
        [build_conf] INFO:packaging_tools:Building template azure-mgmt-servicebus
        [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
        [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
        [build_conf] INFO:packaging_tools:Template done azure-mgmt-servicebus
        [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
        [build_package]   warnings.warn(msg)
        [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
        [build_package]   warnings.warn(msg)
        Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 10 Sep 2020 08:23:27 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"07C2:59C4:9551875:B487C3A:5F59E27F","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
        [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
        [ChangeLog] Size of delta 21.739% size of original (original: 62335 chars, delta: 13551 chars)
        [ChangeLog] **Features**
        [ChangeLog] 
        [ChangeLog]   - Model SBNamespaceUpdateParameters has a new parameter zone_redundant
        [ChangeLog]   - Model SBNamespaceUpdateParameters has a new parameter encryption
        [ChangeLog]   - Model SBNamespaceUpdateParameters has a new parameter identity
        [ChangeLog]   - Model SBNamespace has a new parameter zone_redundant
        [ChangeLog]   - Model SBNamespace has a new parameter encryption
        [ChangeLog]   - Added operation NamespacesOperations.create_or_update_virtual_network_rule
        [ChangeLog]   - Added operation NamespacesOperations.delete_virtual_network_rule
        [ChangeLog]   - Added operation NamespacesOperations.delete_ip_filter_rule
        [ChangeLog]   - Added operation NamespacesOperations.list_ip_filter_rules
        [ChangeLog]   - Added operation NamespacesOperations.get_virtual_network_rule
        [ChangeLog]   - Added operation NamespacesOperations.get_ip_filter_rule
        [ChangeLog]   - Added operation NamespacesOperations.list_virtual_network_rules
        [ChangeLog]   - Added operation NamespacesOperations.create_or_update_ip_filter_rule
        [ChangeLog]   - Added operation group PrivateEndpointConnectionsOperations
        [ChangeLog]   - Added operation group PrivateLinkResourcesOperations
        [ChangeLog] 
        [ChangeLog] **Breaking changes**
        [ChangeLog] 
        [ChangeLog]   - Model ErrorResponse has a new signature

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Jul 8, 2020

      azure-sdk-for-js - Release

      ️✔️ succeeded [Logs] [Expand Details]
      • ️✔️ Generate from 5892437 with merge commit 3f4d11b. SDK Automation 13.0.17.20200909.5
        Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-js/pull/1513: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 10 Sep 2020 08:21:28 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"0409:720E:CFBC0D:216621C:5F59E207","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4941","x-ratelimit-reset":"1599726632","x-ratelimit-used":"59","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-js/git/refs/heads/sdkAutomation/@azure_arm-servicebus@10071","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest/reference/git#delete-a-reference"}
      • ️✔️@azure/arm-servicebus [View full logs]  [Release SDK Changes]
        Only show 100 items here, please refer to log for details.
        [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
        [npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
        [npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
        [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
        [npmPack] loaded rollup.config.js with warnings
        [npmPack] (!) Unused external imports
        [npmPack] default imported from external module 'rollup' but never used
        [npmPack] 
        [npmPack] ./esm/serviceBusManagementClient.js → ./dist/arm-servicebus.js...
        [npmPack] created ./dist/arm-servicebus.js in 579ms
        [npmPack] npm notice 
        [npmPack] npm notice package: @azure/arm-servicebus@4.0.0
        [npmPack] npm notice === Tarball Contents === 
        [npmPack] npm notice 241.8kB dist/arm-servicebus.js                                      
        [npmPack] npm notice 90.3kB  dist/arm-servicebus.min.js                                  
        [npmPack] npm notice 14.1kB  esm/operations/disasterRecoveryConfigs.js                   
        [npmPack] npm notice 1.2kB   esm/models/disasterRecoveryConfigsMappers.js                
        [npmPack] npm notice 2.7kB   esm/operations/eventHubs.js                                 
        [npmPack] npm notice 1.1kB   esm/models/eventHubsMappers.js                              
        [npmPack] npm notice 345B    esm/models/index.js                                         
        [npmPack] npm notice 795B    esm/operations/index.js                                     
        [npmPack] npm notice 64.6kB  esm/models/mappers.js                                       
        [npmPack] npm notice 9.4kB   esm/operations/migrationConfigs.js                          
        [npmPack] npm notice 1.1kB   esm/models/migrationConfigsMappers.js                       
        [npmPack] npm notice 34.3kB  esm/operations/namespaces.js                                
        [npmPack] npm notice 1.3kB   esm/models/namespacesMappers.js                             
        [npmPack] npm notice 2.3kB   esm/operations/operations.js                                
        [npmPack] npm notice 499B    esm/models/operationsMappers.js                             
        [npmPack] npm notice 5.9kB   esm/models/parameters.js                                    
        [npmPack] npm notice 2.6kB   esm/operations/premiumMessagingRegionsOperations.js         
        [npmPack] npm notice 1.1kB   esm/models/premiumMessagingRegionsOperationsMappers.js      
        [npmPack] npm notice 7.9kB   esm/operations/privateEndpointConnections.js                
        [npmPack] npm notice 1.1kB   esm/models/privateEndpointConnectionsMappers.js             
        [npmPack] npm notice 2.0kB   esm/operations/privateLinkResources.js                      
        [npmPack] npm notice 512B    esm/models/privateLinkResourcesMappers.js                   
        [npmPack] npm notice 14.7kB  esm/operations/queues.js                                    
        [npmPack] npm notice 1.1kB   esm/models/queuesMappers.js                                 
        [npmPack] npm notice 2.4kB   esm/operations/regions.js                                   
        [npmPack] npm notice 1.1kB   esm/models/regionsMappers.js                                
        [npmPack] npm notice 992B    rollup.config.js                                            
        [npmPack] npm notice 7.0kB   esm/operations/rules.js                                     
        [npmPack] npm notice 1.1kB   esm/models/rulesMappers.js                                  
        [npmPack] npm notice 2.5kB   esm/serviceBusManagementClient.js                           
        [npmPack] npm notice 2.6kB   esm/serviceBusManagementClientContext.js                    
        [npmPack] npm notice 6.7kB   esm/operations/subscriptions.js                             
        [npmPack] npm notice 1.1kB   esm/models/subscriptionsMappers.js                          
        [npmPack] npm notice 14.7kB  esm/operations/topics.js                                    
        [npmPack] npm notice 1.1kB   esm/models/topicsMappers.js                                 
        [npmPack] npm notice 1.7kB   package.json                                                
        [npmPack] npm notice 457B    tsconfig.json                                               
        [npmPack] npm notice 544.2kB dist/arm-servicebus.js.map                                  
        [npmPack] npm notice 69.6kB  dist/arm-servicebus.min.js.map                              
        [npmPack] npm notice 6.3kB   esm/operations/disasterRecoveryConfigs.d.ts.map             
        [npmPack] npm notice 8.1kB   esm/operations/disasterRecoveryConfigs.js.map               
        [npmPack] npm notice 698B    esm/models/disasterRecoveryConfigsMappers.d.ts.map          
        [npmPack] npm notice 711B    esm/models/disasterRecoveryConfigsMappers.js.map            
        [npmPack] npm notice 1.2kB   esm/operations/eventHubs.d.ts.map                           
        [npmPack] npm notice 1.5kB   esm/operations/eventHubs.js.map                             
        [npmPack] npm notice 621B    esm/models/eventHubsMappers.d.ts.map                        
        [npmPack] npm notice 634B    esm/models/eventHubsMappers.js.map                          
        [npmPack] npm notice 30.1kB  esm/models/index.d.ts.map                                   
        [npmPack] npm notice 401B    esm/operations/index.d.ts.map                               
        [npmPack] npm notice 126B    esm/models/index.js.map                                     
        [npmPack] npm notice 416B    esm/operations/index.js.map                                 
        [npmPack] npm notice 3.2kB   esm/models/mappers.d.ts.map                                 
        [npmPack] npm notice 35.4kB  esm/models/mappers.js.map                                   
        [npmPack] npm notice 3.3kB   esm/operations/migrationConfigs.d.ts.map                    
        [npmPack] npm notice 4.9kB   esm/operations/migrationConfigs.js.map                      
        [npmPack] npm notice 635B    esm/models/migrationConfigsMappers.d.ts.map                 
        [npmPack] npm notice 648B    esm/models/migrationConfigsMappers.js.map                   
        [npmPack] npm notice 13.8kB  esm/operations/namespaces.d.ts.map                          
        [npmPack] npm notice 19.2kB  esm/operations/namespaces.js.map                            
        [npmPack] npm notice 724B    esm/models/namespacesMappers.d.ts.map                       
        [npmPack] npm notice 737B    esm/models/namespacesMappers.js.map                         
        [npmPack] npm notice 1.0kB   esm/operations/operations.d.ts.map                          
        [npmPack] npm notice 1.4kB   esm/operations/operations.js.map                            
        [npmPack] npm notice 241B    esm/models/operationsMappers.d.ts.map                       
        [npmPack] npm notice 254B    esm/models/operationsMappers.js.map                         
        [npmPack] npm notice 1.2kB   esm/models/parameters.d.ts.map                              
        [npmPack] npm notice 4.5kB   esm/models/parameters.js.map                                
        [npmPack] npm notice 1.1kB   esm/operations/premiumMessagingRegionsOperations.d.ts.map   
        [npmPack] npm notice 1.5kB   esm/operations/premiumMessagingRegionsOperations.js.map     
        [npmPack] npm notice 669B    esm/models/premiumMessagingRegionsOperationsMappers.d.ts.map
        [npmPack] npm notice 682B    esm/models/premiumMessagingRegionsOperationsMappers.js.map  
        [npmPack] npm notice 2.7kB   esm/operations/privateEndpointConnections.d.ts.map          
        [npmPack] npm notice 4.0kB   esm/operations/privateEndpointConnections.js.map            
        [npmPack] npm notice 655B    esm/models/privateEndpointConnectionsMappers.d.ts.map       
        [npmPack] npm notice 668B    esm/models/privateEndpointConnectionsMappers.js.map         
        [npmPack] npm notice 817B    esm/operations/privateLinkResources.d.ts.map                
        [npmPack] npm notice 1.1kB   esm/operations/privateLinkResources.js.map                  
        [npmPack] npm notice 251B    esm/models/privateLinkResourcesMappers.d.ts.map             
        [npmPack] npm notice 264B    esm/models/privateLinkResourcesMappers.js.map               
        [npmPack] npm notice 6.7kB   esm/operations/queues.d.ts.map                              
        [npmPack] npm notice 8.5kB   esm/operations/queues.js.map                                
        [npmPack] npm notice 651B    esm/models/queuesMappers.d.ts.map                           
        [npmPack] npm notice 664B    esm/models/queuesMappers.js.map                             
        [npmPack] npm notice 1.1kB   esm/operations/regions.d.ts.map                             
        [npmPack] npm notice 1.5kB   esm/operations/regions.js.map                               
        [npmPack] npm notice 617B    esm/models/regionsMappers.d.ts.map                          
        [npmPack] npm notice 630B    esm/models/regionsMappers.js.map                            

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Jul 8, 2020

      azure-sdk-for-net - Release

      ️✔️ succeeded [Logs] [Expand Details]
      • ️✔️ Generate from 5892437 with merge commit 3f4d11b. SDK Automation 13.0.17.20200909.5
        Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-net/pull/1630: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 10 Sep 2020 08:22:05 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"0407:27BD:436433F:742DA58:5F59E22D","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4830","x-ratelimit-reset":"1599726632","x-ratelimit-used":"170","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-net/git/refs/heads/sdkAutomation/Microsoft.Azure.Management.ServiceBus@10071","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest/reference/git#delete-a-reference"}
        [AutoRest] realpath(): Permission denied
        [AutoRest] realpath(): Permission denied
        [AutoRest] realpath(): Permission denied
        [AutoRest] realpath(): Permission denied
        [AutoRest] realpath(): Permission denied
        [AutoRest] realpath(): Permission denied
      • ️✔️Microsoft.Azure.Management.ServiceBus [View full logs]  [Release SDK Changes]
        Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 10 Sep 2020 08:25:24 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0400:14B5:11C9108:3062893:5F59E2F4","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

      @azuresdkci
      Copy link
      Contributor

      Can one of the admins verify this patch?

      @lirenhe
      Copy link
      Member

      lirenhe commented Jul 14, 2020

      @v-Ajnava, could you please fix all the errors from tool check?

      @lirenhe lirenhe added the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Jul 14, 2020
      @chiragg4u
      Copy link
      Contributor

      In case there is no new API been added ARM API review is not required. Removing the tag, please add with details why ARM API review is required.

      @chiragg4u chiragg4u removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 15, 2020
      @openapi-assignment-bot openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 17, 2020
      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Jul 17, 2020

      azure-sdk-for-python-track2 - Release

      No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      4 similar comments
      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      Ajit Maruti Navasare (MINDTREE LIMITED) added 2 commits September 2, 2020 17:42
      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @v-Ajnava
      Copy link
      Member Author

      v-Ajnava commented Sep 3, 2020

      @lirenhe all required CI have passed, can you please review the PR ?

      @@ -1,1437 +0,0 @@
      {
      "swagger": "2.0",
      Copy link
      Member

      Choose a reason for hiding this comment

      The reason will be displayed to describe this comment to others. Learn more.

      swagger [](start = 3, length = 7)

      Was the deleted file split into all the files in the same directory?

      Copy link
      Member Author

      Choose a reason for hiding this comment

      The reason will be displayed to describe this comment to others. Learn more.

      "swagger": "2.0",

      Was the deleted file split into all the files in the same directory?

      Refers to: specification/servicebus/resource-manager/Microsoft.ServiceBus/stable/2017-04-01/servicebus.json:2 in 792f037. [](commit_id = 792f037, deletion_comment = True)

      yes, the deleted file is split in all the files in the same directory.

      @majastrz
      Copy link
      Member

      majastrz commented Sep 4, 2020

      "swagger": "2.0",

      Was the deleted file split into all the files in the same directory?


      Refers to: specification/servicebus/resource-manager/Microsoft.ServiceBus/stable/2017-04-01/servicebus.json:2 in 792f037. [](commit_id = 792f037, deletion_comment = True)

      @majastrz majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 4, 2020
      Copy link
      Member

      @majastrz majastrz left a comment

      Choose a reason for hiding this comment

      The reason will be displayed to describe this comment to others. Learn more.

      Signed off from ARM side.

      @v-Ajnava v-Ajnava removed the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Sep 8, 2020
      …into SBSplitSwaggerPrivateEndpoint
      
      # Conflicts:
      #	custom-words.txt
      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @v-Ajnava
      Copy link
      Member Author

      @lirenhe , can you please review the PR

      @lirenhe lirenhe merged commit 3f4d11b into Azure:master Sep 10, 2020
      nitegupt pushed a commit to nitegupt/azure-rest-api-specs that referenced this pull request Sep 25, 2020
      …zure#10071)
      
      * Swagger Split and Added PrivateEndPointConnection API
      
      * updated custom-words.txt
      
      * prettier check fix
      
      * updated Readme
      
      * removed the ub-referenced file
      
      * Operations API
      
      * fix avocado
      
      * fix for UniqueXmsEnumName
      
      * updated description
      
      * update
      
      * updated resource
      
      * fix for modelvalidation
      
      * version update in definition
      
      * added examples
      
      * updated examples
      
      * fix for avocado - INCONSISTENT_API_VERSION
      
      * updated azureresourceschema.md
      iscai-msft added a commit to iscai-msft/azure-rest-api-specs that referenced this pull request Oct 14, 2020
      …into formrecognizer_regeneration
      
      * 'master' of https://github.com/Azure/azure-rest-api-specs: (545 commits)
        Changes for new api version sdk generate (Azure#10685)
        Update batch sdk comments (Azure#10517)
        Dev StreamAnalytics 2017-04-01-preview version for streaming job and 2020-03-01-preview version for dedicated cluster (Azure#10673)
        Bump node-fetch from 2.6.0 to 2.6.1 in /.azure-pipelines-preproduction (Azure#10762)
        Spark Compute Isolation enabled (Azure#10726)
        [Hub Generated] Review request for Microsoft.BareMetalInfrastructure to add version preview/2020-08-06-preview (Azure#10677)
        PostgreSQL Flexible Server New API Swagger Changes (Azure#10586)
        Bump node-fetch from 2.6.0 to 2.6.1 (Azure#10760)
        Swagger changes. Remove weekly and monthly options from replicationSchedule enum (Azure#10752)
        modify description of properties to be self consistent (Azure#10711)
        Adding ComputeInstance to preview swagger (Azure#10654)
        remove unsupported reversproxy and useTestExtension (Azure#10728)
        Dev deviceprovisioningservices microsoft.devices 2020 09 01 preview (Azure#10735)
        FR v2.1-preview.1 update (Azure#10747)
        ServiceBus : Swagger Split and Added PrivateEndPointConnection API (Azure#10071)
        Eventhub: Added PrivateEndpointConnection API (Azure#10635)
        codegen onboard df for cli (Azure#8531)
        Update swagger for outbound public ip feature (Azure#10713)
        2020-09-01-hybrid profile for AzureStack (Azure#10295)
        Update pull_request_assignment.yml (Azure#10724)
        ...
      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Labels
      ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Python
      Projects
      None yet
      Development

      Successfully merging this pull request may close these issues.

      5 participants