2020-09-01-hybrid profile for AzureStack #10295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Staging] Swagger Validation Report
️✔️ |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-go - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
Can one of the admins verify this patch? |
bganapa
reviewed
Jul 31, 2020
bganapa
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
azure-sdk-for-net - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-resource-manager-schemas - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
bganapa
reviewed
Aug 21, 2020
bganapa
reviewed
Aug 21, 2020
bganapa
reviewed
Aug 21, 2020
Juliehzl
reviewed
Aug 21, 2020
bganapa
reviewed
Aug 21, 2020
bganapa
reviewed
Aug 21, 2020
bganapa
reviewed
Aug 21, 2020
|
Azure Pipelines successfully started running 1 pipeline(s). |
bganapa
changed the title
bganapa
approved these changes
Sep 2, 2020
|
Azure Pipelines successfully started running 1 pipeline(s). |
HarveyLink
reviewed
Sep 2, 2020
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@sijuman Could you explain why adding the profile file and how it's going to be used? |
|
@leni-msft We work with the Azure SDK team to produce API profile specific SDK for variaous languages. The SDK team uses this file as a reference. There are no SDK generation directly comes from this file. It is very safe to merge. To learn about profile, pls look at our documentation here https://docs.microsoft.com/en-us/azure-stack/user/azure-stack-version-profiles?view=azs-2005 there is also a readme under the profile folder Thanks for the queries. Could you please merge this PR? |
HarveyLink
reviewed
Sep 15, 2020
| "2017-04-01": [ | ||
| { | ||
| "resourceType": "checkNameAvailability", | ||
| "path":"https://raw.githubusercontent.com/Azure/azure-rest-api-specs/master/specification/eventhub/resource-manager/Microsoft.EventHub/stable/2017-04-01/EventHub.json" |
There was a problem hiding this comment.
There is no such file path, get 404.
There was a problem hiding this comment.
it looks like they renamed the file
There was a problem hiding this comment.
it should be individual file names under
https://github.com/Azure/azure-rest-api-specs/tree/master/specification/eventhub/resource-manager/Microsoft.EventHub/stable/2017-04-01
instead of EventHub.json
Could you please unblock yourself with this change? I will make a PR to correct this
HarveyLink
reviewed
Sep 16, 2020
| "2015-08-01": [ | ||
| { | ||
| "resourceType": "checkNamespaceAvailability", | ||
| "path":"https://raw.githubusercontent.com/Azure/azure-rest-api-specs/master/specification/eventhub/resource-manager/Microsoft.EventHub/stable/2015-08-01/EventHub.json" |
There was a problem hiding this comment.
There is no "checkNamespaceAvailability" related content in this file. It only exists in version 2014-09-01.
nitegupt
pushed a commit
to nitegupt/azure-rest-api-specs
that referenced
this pull request
Sep 25, 2020
* Rough draft of new profile for ignite * Addressing the review comments by updating the api versions * Fixing issues in Eventhub specs paths Co-authored-by: bganapa <bganapa@microsoft.com>
iscai-msft
added a commit
to iscai-msft/azure-rest-api-specs
that referenced
this pull request
Oct 14, 2020
…into formrecognizer_regeneration * 'master' of https://github.com/Azure/azure-rest-api-specs: (545 commits) Changes for new api version sdk generate (Azure#10685) Update batch sdk comments (Azure#10517) Dev StreamAnalytics 2017-04-01-preview version for streaming job and 2020-03-01-preview version for dedicated cluster (Azure#10673) Bump node-fetch from 2.6.0 to 2.6.1 in /.azure-pipelines-preproduction (Azure#10762) Spark Compute Isolation enabled (Azure#10726) [Hub Generated] Review request for Microsoft.BareMetalInfrastructure to add version preview/2020-08-06-preview (Azure#10677) PostgreSQL Flexible Server New API Swagger Changes (Azure#10586) Bump node-fetch from 2.6.0 to 2.6.1 (Azure#10760) Swagger changes. Remove weekly and monthly options from replicationSchedule enum (Azure#10752) modify description of properties to be self consistent (Azure#10711) Adding ComputeInstance to preview swagger (Azure#10654) remove unsupported reversproxy and useTestExtension (Azure#10728) Dev deviceprovisioningservices microsoft.devices 2020 09 01 preview (Azure#10735) FR v2.1-preview.1 update (Azure#10747) ServiceBus : Swagger Split and Added PrivateEndPointConnection API (Azure#10071) Eventhub: Added PrivateEndpointConnection API (Azure#10635) codegen onboard df for cli (Azure#8531) Update swagger for outbound public ip feature (Azure#10713) 2020-09-01-hybrid profile for AzureStack (Azure#10295) Update pull_request_assignment.yml (Azure#10724) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.