[SQL][V20200801] Adding new API version with named replica and maintenance #10432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Staging] Swagger Validation Report
️✔️ |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
|
|
Can one of the admins verify this patch? |
ruowan
added
the
NotReadyForReview
|
No commit pushedDate could be found for PR 10432 in repo Azure/azure-rest-api-specs |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-resource-manager-schemas - Release
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
This was referenced Sep 1, 2020
|
Azure Pipelines successfully started running 1 pipeline(s). |
openapi-assignment-bot
bot
added
the
WaitForARMFeedback
ruowan
removed
NotReadyForReview
openapi-assignment-bot
bot
added
the
WaitForARMFeedback
ruowan
approved these changes
Sep 10, 2020
|
Azure Pipelines successfully started running 1 pipeline(s). |
2 similar comments
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
failover APIs are being added which look good. The inaccessibleDatabases APIs were added accidentally and are being removed. they are not live yet and no customers. So not a breaking change. Signing off from ARM side. |
ravbhatnagar
added
ARMSignedOff
hotsnr
commented
Sep 17, 2020
| @@ -335,6 +338,68 @@ | |||
| } | |||
| } | |||
| }, | |||
| "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Sql/servers/{serverName}/databases/{databaseName}/failover": { | |||
There was a problem hiding this comment.
This is being merged from FailoverDatabases.json
| @@ -533,110 +598,6 @@ | |||
| } | |||
| } | |||
| } | |||
| }, | |||
| "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Sql/servers/{serverName}/inaccessibleDatabases": { | |||
There was a problem hiding this comment.
This is what has been added to previous API version by mistake, removing it from this one
| } | ||
| }, | ||
| "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Sql/servers/{serverName}/elasticPools/{elasticPoolName}/failover": { | ||
| "post": { |
There was a problem hiding this comment.
This is being merged from FailoverElasticPools.json
jamestao
approved these changes
Sep 17, 2020
bcham
approved these changes
Sep 18, 2020
|
@ruowan can you please merge this? Thank you. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
No commit pushedDate could be found for PR 10432 in repo Azure/azure-rest-api-specs |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
nitegupt
pushed a commit
to nitegupt/azure-rest-api-specs
that referenced
this pull request
Sep 25, 2020
…nance (Azure#10432) * [SQL][V20200801] Adding new API version with named replica and maintenance * Various fixed and enhancements * Removed extra examples * Removing last extra example * AsBefore * AsAfter + restart CI
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.