-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add package-composite-v4 #11063
Add package-composite-v4 #11063
Conversation
[Staging] Swagger Validation Report
️✔️ |
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-java - Release
|
azure-sdk-for-go - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
|
azure-sdk-for-net - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-resource-manager-schemas - Release
|
@bradrich-msft It looks like there are breaking change when swtiching the default tag from v3 to v4 (as shouwn in the pythion client breaking changes in the comments above). Is this expected? How do we plan to keep this from breaking customers? |
Hi @markcowl it's not expected that bumping default tag version would break python client. However, I admit to limited knowledge of the python client or a documented process of default tag change to avoid it. Do you have any info to share on that? We are in process of also updating .NET SDK to consume this change which will be followed by powershell and CLI clients. Is that sufficient? |
I took a look at azure-sdk-for-python breaking changes logs and these changes are correct and expected. In fact, we introduced v4 package for the very reason of these breaking changes. If this is not the correct way to introduce breaking changes for python client, what is? |
No pipelines are associated with this pull request. |
@markcowl one more thing. We introduced a new API version, 2020-08-01-preview, which is the only API version with the breaking change. Versions prior to 20200801 will continue to have old functionality and existing clients will work. I have the change ready which updates .NET SDK to a new version consuming this change. This was our plan to deal with the breaking change. New API version and new versions for composite, SDK, clients. A related change that has already been merged: #10432 |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@bradrich-msft Generally, breaking changes are heavily discouraged / not allowed, we will need to get the sdk team to sign off on the breaking changes. Included you in an email to the SDK owners for signoff. |
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.