Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operationalinsights/data export delete all tables param #10775

Merged
merged 8 commits into from
Sep 23, 2020
Merged

Operationalinsights/data export delete all tables param #10775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6b543ce
microsoft.operationalinsights_add_data_export
hohershk Jan 12, 2020
4d0c28d
fix
hohershk Jan 12, 2020
3d16a91
fix
hohershk Jan 12, 2020
71175a6
fix
Jun 16, 2020
e05e606
Merge remote-tracking branch 'upstream/master'
Jul 14, 2020
4344d96
Merge remote-tracking branch 'upstream/master'
Jul 16, 2020
7cd1f79
Merge remote-tracking branch 'upstream/master'
Sep 13, 2020
c85c368
delete_unneeded_property
Sep 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...oft.OperationalInsights/preview/2019-08-01-preview/examples/DataExportCreateOrUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
"resourceId": "/subscriptions/192b9f85-a39a-4276-b96d-d5cd351703f9/resourceGroups/OIAutoRest1234/providers/Microsoft.EventHub/namespaces/test",
"type": "EventHub"
},
"allTables": false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you need to delete this field? This change would impact Azure CLI as well. Please share more context about this change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had a discussion with OBO service which is using this API. They needs to know the specific table names which should be exported, otherwise they can be break. So we decided to delete "AllTables" field so customer must supply a list a table names that they want to exported.
I am aware of the change CLI issue. I will change it too after you will approve it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if customers use AllTables, since server would create tables for them, why doesn't OBO know the table names? It would be a breaking change for customers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OBO cannot do that.
We are still in preview mode. Our PM in contact with all the customers that use it. They already got notice with this change so they are aware.

"tableNames": [
"Heartbeat"
],
Expand Down
1 change: 0 additions & 1 deletion ...ager/Microsoft.OperationalInsights/preview/2019-08-01-preview/examples/DataExportGet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
"resourceId": "/subscriptions/192b9f85-a39a-4276-b96d-d5cd351703f9/resourceGroups/OIAutoRest1234/providers/Microsoft.EventHub/namespaces/test",
"type": "EventHub"
},
"allTables": false,
"tableNames": [
"Heartbeat"
],
Expand Down
1 change: 0 additions & 1 deletion ...ft.OperationalInsights/preview/2019-08-01-preview/examples/DataExportListByWorkspace.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
"resourceId": "/subscriptions/192b9f85-a39a-4276-b96d-d5cd351703f9/resourceGroups/OIAutoRest1234/providers/Microsoft.EventHub/namespaces/test",
"type": "EventHub"
},
"allTables": false,
"tableNames": [
"Heartbeat"
],
Expand Down
4 changes: 0 additions & 4 deletions ...esource-manager/Microsoft.OperationalInsights/preview/2020-03-01-preview/DataExports.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,10 +276,6 @@
"type": "string",
"description": "The data export rule ID."
},
"allTables": {
"type": "boolean",
"description": "When ‘true’, all workspace's tables are exported."
},
"tableNames": {
"type": "array",
"items": {
Expand Down
2 changes: 0 additions & 2 deletions ...oft.OperationalInsights/preview/2020-03-01-preview/examples/DataExportCreateOrUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
"resourceId": "/subscriptions/192b9f85-a39a-4276-b96d-d5cd351703f9/resourceGroups/OIAutoRest1234/providers/Microsoft.EventHub/namespaces/test",
"type": "EventHub"
},
"allTables": false,
"tableNames": [
"Heartbeat"
],
Expand All @@ -46,7 +45,6 @@
"resourceId": "/subscriptions/192b9f85-a39a-4276-b96d-d5cd351703f9/resourceGroups/OIAutoRest1234/providers/Microsoft.EventHub/namespaces/test",
"type": "EventHub"
},
"allTables": false,
"tableNames": [
"Heartbeat"
],
Expand Down
1 change: 0 additions & 1 deletion ...ager/Microsoft.OperationalInsights/preview/2020-03-01-preview/examples/DataExportGet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
"resourceId": "/subscriptions/192b9f85-a39a-4276-b96d-d5cd351703f9/resourceGroups/OIAutoRest1234/providers/Microsoft.EventHub/namespaces/test",
"type": "EventHub"
},
"allTables": false,
"tableNames": [
"Heartbeat"
],
Expand Down
1 change: 0 additions & 1 deletion ...ft.OperationalInsights/preview/2020-03-01-preview/examples/DataExportListByWorkspace.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
"resourceId": "/subscriptions/192b9f85-a39a-4276-b96d-d5cd351703f9/resourceGroups/OIAutoRest1234/providers/Microsoft.EventHub/namespaces/test",
"type": "EventHub"
},
"allTables": false,
"tableNames": [
"Heartbeat"
],
Expand Down