Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operationalinsights/data export delete all tables param #10775

Conversation

hohershk
Copy link
Contributor

@hohershk hohershk commented Sep 13, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 13, 2020

[Staging] Swagger Validation Report

BreakingChange: 2 Errors, 0 Warnings [Detail] [Expand]
Rule Message
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'allTables' renamed or removed?
New: Microsoft.OperationalInsights/preview/2020-03-01-preview/DataExports.json#L274:7
Old: Microsoft.OperationalInsights/preview/2020-03-01-preview/DataExports.json#L274:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'allTables' renamed or removed?
New: Microsoft.OperationalInsights/preview/2020-03-01-preview/DataExports.json#L274:7
Old: Microsoft.OperationalInsights/preview/2020-03-01-preview/DataExports.json#L274:7
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
️✔️ModelValidation [Detail]
 Validation passes for ModelValidation. 
️✔️SemanticValidation [Detail]
 Validation passes for SemanticValidation. 
Posted by Swagger Pipeline | How to fix these errors?

@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Sep 13, 2020
@ghost
Copy link

ghost commented Sep 13, 2020

Thank you for your contribution hohershk! We will review the pull request and get back to you soon.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-assignment-bot openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 13, 2020
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 13, 2020

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from c85c368 with merge commit 7a555b8. SDK Automation 13.0.17.20200918.2
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 13, 2020

azure-sdk-for-go - Release

failed [Logs] [Expand Details]
  • Generate from c85c368 with merge commit 7a555b8. SDK Automation 13.0.17.20200918.2
    [AutoRest] FATAL: System.InvalidOperationException: output-folder /z/work/src/github.com/Azure/azure-sdk-for-go/services/preview/operationalinsights/mgmt/2020-08-01/operationalinsights of tag package-2020-08 must not be under a preview subdirectory for a stable swagger set. Please refer the sample for readme.go.md file here https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/samplefiles/readme.go.md for more information
    [AutoRest]    at AutoRest.Go.CodeGeneratorGo.PreviewCheck(String folder) in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 187
    [AutoRest]    at AutoRest.Go.CodeGeneratorGo.d__7.MoveNext() in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 60
    [AutoRest] --- End of stack trace from previous location where exception was thrown ---
    [AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
    [AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    [AutoRest]    at AutoRest.Go.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 107
    [AutoRest] --- End of stack trace from previous location where exception was thrown ---
    [AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
    [AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    [AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
    [AutoRest]    at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
    [AutoRest] FATAL: go/generate - FAILED
    [AutoRest] FATAL: Error: Plugin go reported failure.
    [AutoRest] Failure during batch task - {"tag":"package-2020-08"} -- Error: Plugin go reported failure..
    [AutoRest]   Error: Plugin go reported failure.
    Failed to run autorest.
    Error: /z/node_modules/.bin/autorest --use=@microsoft.azure/autorest.go@~2.1.155 --go --verbose --multiapi --use-onever --preview-chk --version=V2 --go-sdk-folder=/z/work/src/github.com/Azure/azure-sdk-for-go /z/work/azure-rest-api-specs/specification/operationalinsights/resource-manager/readme.md FATAL: System.InvalidOperationException: output-folder /z/work/src/github.com/Azure/azure-sdk-for-go/services/preview/operationalinsights/mgmt/2020-08-01/operationalinsights of tag package-2020-08 must not be under a preview subdirectory for a stable swagger set. Please refer the sample for readme.go.md file here https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/samplefiles/readme.go.md for more information
       at AutoRest.Go.CodeGeneratorGo.PreviewCheck(String folder) in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 187
       at AutoRest.Go.CodeGeneratorGo.d__7.MoveNext() in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 60
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
       at AutoRest.Go.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 107
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
       at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
       at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
    FATAL: go/generate - FAILED
    FATAL: Error: Plugin go reported failure.
    Failure during batch task - {"tag":"package-2020-08"} -- Error: Plugin go reported failure..
      Error: Plugin go reported failure.
    , {} 
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 13, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 13, 2020

azure-resource-manager-schemas - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from c85c368 with merge commit 7a555b8. Schema Automation 13.0.17.20200918.2
    [operationalinsights][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
    [operationalinsights][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
    [operationalinsights][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
  • ️✔️operationalinsights [View full logs]  [Release Schema Changes]
      [after_scripts|node] PostProcessor finished successfully.
      [after_scripts|node]   5727 passing (1m)
      AzureResourceSchema has no registered package commands.
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 23 Sep 2020 05:56:54 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0500:5039:6588179:A303ED8:5F6AE3A6","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Sep 13, 2020

    Trenton Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Sep 13, 2020

    azure-sdk-for-js - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from c85c368 with merge commit 7a555b8. SDK Automation 13.0.17.20200918.2
      Failed to find any diff after autorest so no changed packages was found.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Sep 13, 2020

    azure-sdk-for-java - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from c85c368 with merge commit 7a555b8. SDK Automation 13.0.17.20200918.2
    • ️✔️sdk/loganalytics/mgmt-v2015_03_20 [View full logs]  [Release SDK Changes]
      Error: spawn bundle ENOENT
      Error: spawn rake ENOENT
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 23 Sep 2020 05:54:58 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"04C0:D39C:BEADEAF:E628FC2:5F6AE332","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
    • ️✔️sdk/loganalytics/mgmt-v2015_11_01_preview [View full logs]  [Release SDK Changes]
      Error: spawn bundle ENOENT
      Error: spawn rake ENOENT
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 23 Sep 2020 05:55:07 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"04C2:2D7D:489EF57:9C5969F:5F6AE33B","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
    • ⚠️sdk/loganalytics/mgmt-v2020_03_01_preview [View full logs]  [Release SDK Changes]
        Error: spawn bundle ENOENT
        Error: spawn rake ENOENT
        [mvn] [ERROR] COMPILATION ERROR : 
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/loganalytics/mgmt-v2020_03_01_preview/src/main/java/com/microsoft/azure/management/loganalytics/v2020_03_01_preview/implementation/LinkedStorageAccountsImpl.java:[64,111] cannot find symbol
        [mvn]   symbol:   class DataSourceType
        [mvn]   location: class com.microsoft.azure.management.loganalytics.v2020_03_01_preview.implementation.LinkedStorageAccountsImpl
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/loganalytics/mgmt-v2020_03_01_preview/src/main/java/com/microsoft/azure/management/loganalytics/v2020_03_01_preview/implementation/LinkedStorageAccountsImpl.java:[80,84] cannot find symbol
        [mvn]   symbol:   class DataSourceType
        [mvn]   location: class com.microsoft.azure.management.loganalytics.v2020_03_01_preview.implementation.LinkedStorageAccountsImpl
        [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-loganalytics: Compilation failure: Compilation failure: 
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/loganalytics/mgmt-v2020_03_01_preview/src/main/java/com/microsoft/azure/management/loganalytics/v2020_03_01_preview/implementation/LinkedStorageAccountsImpl.java:[64,111] cannot find symbol
        [mvn] [ERROR]   symbol:   class DataSourceType
        [mvn] [ERROR]   location: class com.microsoft.azure.management.loganalytics.v2020_03_01_preview.implementation.LinkedStorageAccountsImpl
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/loganalytics/mgmt-v2020_03_01_preview/src/main/java/com/microsoft/azure/management/loganalytics/v2020_03_01_preview/implementation/LinkedStorageAccountsImpl.java:[80,84] cannot find symbol
        [mvn] [ERROR]   symbol:   class DataSourceType
        [mvn] [ERROR]   location: class com.microsoft.azure.management.loganalytics.v2020_03_01_preview.implementation.LinkedStorageAccountsImpl
        [mvn] [ERROR] -> [Help 1]
        [mvn] [ERROR] 
        [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
        [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
        [mvn] [ERROR] 
        [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
        [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
        Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 23 Sep 2020 05:55:17 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"04C1:0F75:DFC595:1821206:5F6AE345","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
      • ⚠️sdk/loganalytics/mgmt-v2020_08_01 [View full logs]  [Release SDK Changes]
          Error: spawn bundle ENOENT
          Error: spawn rake ENOENT
          [mvn] [ERROR] COMPILATION ERROR : 
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/loganalytics/mgmt-v2020_08_01/src/main/java/com/microsoft/azure/management/loganalytics/v2020_08_01/implementation/LinkedStorageAccountsImpl.java:[64,111] cannot find symbol
          [mvn]   symbol:   class DataSourceType
          [mvn]   location: class com.microsoft.azure.management.loganalytics.v2020_08_01.implementation.LinkedStorageAccountsImpl
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/loganalytics/mgmt-v2020_08_01/src/main/java/com/microsoft/azure/management/loganalytics/v2020_08_01/implementation/LinkedStorageAccountsImpl.java:[80,84] cannot find symbol
          [mvn]   symbol:   class DataSourceType
          [mvn]   location: class com.microsoft.azure.management.loganalytics.v2020_08_01.implementation.LinkedStorageAccountsImpl
          [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-loganalytics: Compilation failure: Compilation failure: 
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/loganalytics/mgmt-v2020_08_01/src/main/java/com/microsoft/azure/management/loganalytics/v2020_08_01/implementation/LinkedStorageAccountsImpl.java:[64,111] cannot find symbol
          [mvn] [ERROR]   symbol:   class DataSourceType
          [mvn] [ERROR]   location: class com.microsoft.azure.management.loganalytics.v2020_08_01.implementation.LinkedStorageAccountsImpl
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/loganalytics/mgmt-v2020_08_01/src/main/java/com/microsoft/azure/management/loganalytics/v2020_08_01/implementation/LinkedStorageAccountsImpl.java:[80,84] cannot find symbol
          [mvn] [ERROR]   symbol:   class DataSourceType
          [mvn] [ERROR]   location: class com.microsoft.azure.management.loganalytics.v2020_08_01.implementation.LinkedStorageAccountsImpl
          [mvn] [ERROR] -> [Help 1]
          [mvn] [ERROR] 
          [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
          [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
          [mvn] [ERROR] 
          [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
          [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
          Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 23 Sep 2020 05:55:30 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"04C1:FACF:B6A6193:DC6B458:5F6AE352","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Sep 13, 2020

        azure-sdk-for-net - Release

        ️✔️ succeeded [Logs] [Expand Details]
        • ️✔️ Generate from c85c368 with merge commit 7a555b8. SDK Automation 13.0.17.20200918.2
          [AutoRest] realpath(): Permission denied
          [AutoRest] realpath(): Permission denied
          [AutoRest] realpath(): Permission denied
          [AutoRest] realpath(): Permission denied
          [AutoRest] realpath(): Permission denied
          [AutoRest] realpath(): Permission denied
        • ️✔️Microsoft.Azure.Management.OperationalInsights [View full logs]  [Release SDK Changes]
          Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 23 Sep 2020 05:53:16 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0481:A4E0:63B112D:7820D1D:5F6AE2CB","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

        @hohershk
        Copy link
        Contributor Author

        The Data export api is on private preview.
        Before it become a public preview we need to delete "allTables" property.

        @@ -25,7 +25,6 @@
        "resourceId": "/subscriptions/192b9f85-a39a-4276-b96d-d5cd351703f9/resourceGroups/OIAutoRest1234/providers/Microsoft.EventHub/namespaces/test",
        "type": "EventHub"
        },
        "allTables": false,
        Copy link
        Contributor

        Choose a reason for hiding this comment

        The reason will be displayed to describe this comment to others. Learn more.

        why do you need to delete this field? This change would impact Azure CLI as well. Please share more context about this change

        Copy link
        Contributor Author

        Choose a reason for hiding this comment

        The reason will be displayed to describe this comment to others. Learn more.

        We had a discussion with OBO service which is using this API. They needs to know the specific table names which should be exported, otherwise they can be break. So we decided to delete "AllTables" field so customer must supply a list a table names that they want to exported.
        I am aware of the change CLI issue. I will change it too after you will approve it.

        Copy link
        Contributor

        Choose a reason for hiding this comment

        The reason will be displayed to describe this comment to others. Learn more.

        Even if customers use AllTables, since server would create tables for them, why doesn't OBO know the table names? It would be a breaking change for customers.

        Copy link
        Contributor Author

        Choose a reason for hiding this comment

        The reason will be displayed to describe this comment to others. Learn more.

        OBO cannot do that.
        We are still in preview mode. Our PM in contact with all the customers that use it. They already got notice with this change so they are aware.

        @mmyyrroonn mmyyrroonn added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Sep 23, 2020
        @mmyyrroonn mmyyrroonn merged commit 7a555b8 into Azure:master Sep 23, 2020
        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Sep 23, 2020

        azure-sdk-for-python-track2 - Release

        No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

        nitegupt pushed a commit to nitegupt/azure-rest-api-specs that referenced this pull request Sep 25, 2020
        * microsoft.operationalinsights_add_data_export
        
        * fix
        
        * fix
        
        * delete_unneeded_property
        
        Co-authored-by: Hodaya Hershkovich <hohershk@microsoft.com>
        iscai-msft added a commit to iscai-msft/azure-rest-api-specs that referenced this pull request Oct 14, 2020
        …into formrecognizer_regeneration
        
        * 'master' of https://github.com/Azure/azure-rest-api-specs: (52 commits)
          rename synapse model in java (Azure#10911)
          [Microsoft.Storage] Adding support for ResourceAccessRules (Azure#10868)
          add fix (Azure#10906)
          Revert "[Do Not Merge][Really To Review] add a new apis (Azure#10756)" (Azure#10908)
          [Do Not Merge][Really To Review] add a new apis (Azure#10756)
          Add documentation for downloading invoices through Microsoft.Billing API (Azure#10585)
          Add api-version of 2019-10-01/comsuption to go SDK (Azure#10749)
          Add location info for cross region compute feature (Azure#10816)
          Operationalinsights/data export delete all tables param (Azure#10775)
          Update SDKAutomation.yml for Azure Pipelines (Azure#10904)
          [Hub Generated] Review request for Microsoft.DigitalTwins to add version stable/2020-10-31 (Azure#10902)
          [Hub Generated] Review request for Microsoft.Insights to add version preview/2020-05-01-preview (Azure#10891)
          Add readme.azureresourceschema.md for sample rp (Azure#10764)
          [Hub Generated] Review request for Microsoft.Security to add version preview/2020-08-06-preview (Azure#10773)
          DataFactory: Update Rest Sink properties based on ship room comments. (Azure#10815)
          Bring up ACS eventgrid events swagger (Azure#10880)
          Assignment config (Azure#10850)
          .md for python (Azure#10881)
          Fixed ActionRule's polymorphism via discriminator (Azure#10829)
          Fixed S360 issues related to ARM & SDK swagger linting errors for Microsoft.Solutions. (Azure#10804)
          ...
        Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
        Labels
        Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 customer-reported Issues that are reported by GitHub users external to the Azure organization. WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
        Projects
        None yet
        Development

        Successfully merging this pull request may close these issues.

        2 participants