-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Operationalinsights/data export delete all tables param #10775
Operationalinsights/data export delete all tables param #10775
Conversation
[Staging] Swagger Validation Report
❌ |
Rule | Message |
---|---|
1033 - RemovedProperty |
The new version is missing a property found in the old version. Was 'allTables' renamed or removed? New: Microsoft.OperationalInsights/preview/2020-03-01-preview/DataExports.json#L274:7 Old: Microsoft.OperationalInsights/preview/2020-03-01-preview/DataExports.json#L274:7 |
1033 - RemovedProperty |
The new version is missing a property found in the old version. Was 'allTables' renamed or removed? New: Microsoft.OperationalInsights/preview/2020-03-01-preview/DataExports.json#L274:7 Old: Microsoft.OperationalInsights/preview/2020-03-01-preview/DataExports.json#L274:7 |
️️✔️
LintDiff [Detail]
️✔️
Validation passes for LintDiff.
️️✔️
Avocado [Detail]
️✔️
Validation passes for Avocado.
️️✔️
ModelValidation [Detail]
️✔️
Validation passes for ModelValidation.
️️✔️
SemanticValidation [Detail]
️✔️
Validation passes for SemanticValidation.
Thank you for your contribution hohershk! We will review the pull request and get back to you soon. |
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-go - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-resource-manager-schemas - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java - Release
|
azure-sdk-for-net - Release
|
The Data export api is on private preview. |
@@ -25,7 +25,6 @@ | |||
"resourceId": "/subscriptions/192b9f85-a39a-4276-b96d-d5cd351703f9/resourceGroups/OIAutoRest1234/providers/Microsoft.EventHub/namespaces/test", | |||
"type": "EventHub" | |||
}, | |||
"allTables": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do you need to delete this field? This change would impact Azure CLI as well. Please share more context about this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had a discussion with OBO service which is using this API. They needs to know the specific table names which should be exported, otherwise they can be break. So we decided to delete "AllTables" field so customer must supply a list a table names that they want to exported.
I am aware of the change CLI issue. I will change it too after you will approve it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if customers use AllTables
, since server would create tables for them, why doesn't OBO know the table names? It would be a breaking change for customers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OBO cannot do that.
We are still in preview mode. Our PM in contact with all the customers that use it. They already got notice with this change so they are aware.
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
* microsoft.operationalinsights_add_data_export * fix * fix * delete_unneeded_property Co-authored-by: Hodaya Hershkovich <hohershk@microsoft.com>
…into formrecognizer_regeneration * 'master' of https://github.com/Azure/azure-rest-api-specs: (52 commits) rename synapse model in java (Azure#10911) [Microsoft.Storage] Adding support for ResourceAccessRules (Azure#10868) add fix (Azure#10906) Revert "[Do Not Merge][Really To Review] add a new apis (Azure#10756)" (Azure#10908) [Do Not Merge][Really To Review] add a new apis (Azure#10756) Add documentation for downloading invoices through Microsoft.Billing API (Azure#10585) Add api-version of 2019-10-01/comsuption to go SDK (Azure#10749) Add location info for cross region compute feature (Azure#10816) Operationalinsights/data export delete all tables param (Azure#10775) Update SDKAutomation.yml for Azure Pipelines (Azure#10904) [Hub Generated] Review request for Microsoft.DigitalTwins to add version stable/2020-10-31 (Azure#10902) [Hub Generated] Review request for Microsoft.Insights to add version preview/2020-05-01-preview (Azure#10891) Add readme.azureresourceschema.md for sample rp (Azure#10764) [Hub Generated] Review request for Microsoft.Security to add version preview/2020-08-06-preview (Azure#10773) DataFactory: Update Rest Sink properties based on ship room comments. (Azure#10815) Bring up ACS eventgrid events swagger (Azure#10880) Assignment config (Azure#10850) .md for python (Azure#10881) Fixed ActionRule's polymorphism via discriminator (Azure#10829) Fixed S360 issues related to ARM & SDK swagger linting errors for Microsoft.Solutions. (Azure#10804) ...
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.