Fixed ActionRule's polymorphism via discriminator #10829

EranGon · 2020-09-17T13:35:06Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2020-09-17T13:35:11Z

[Staging] Swagger Validation Report

️❌BreakingChange: 2 Errors, 0 Warnings [Detail] [Expand]

Rule	Message
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'suppressionConfig' renamed or removed? Old: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L856:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'actionGroupId' renamed or removed? Old: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L877:7

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

️️✔️ModelValidation [Detail]

 Validation passes for ModelValidation.

️️✔️SemanticValidation [Detail]

 Validation passes for SemanticValidation.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-09-17T13:35:23Z

Azure Pipelines successfully started running 1 pipeline(s).

EranGon · 2020-09-17T13:36:27Z

Note to reviewers: This PR is a do-over of #10028
The original change was overrun because of another change that was introduced at the same time

openapi-sdkautomation · 2020-09-17T13:36:43Z

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-09-17T13:36:43Z

azure-resource-manager-schemas

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 2d75ca9 with merge commit a01a48239d87987c501ca0ec231a11d5008c2b86. Schema Automation 13.0.17.20200916.11
⚠️alertsmanagement [View full logs] [Preview Schema Changes]
```
AzureResourceSchema has no registered package commands.
```

openapi-sdkautomation · 2020-09-17T13:36:44Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 2d75ca9 with merge commit 38907c9. SDK Automation 13.0.17.20200918.2

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.AlertsManagement [View full logs] [Release SDK Changes]

Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 22 Sep 2020 06:16:20 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0480:74E2:8AB51:18AB1D:5F6996B4","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

openapi-sdkautomation · 2020-09-17T13:36:45Z

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-09-17T13:36:45Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 2d75ca9 with merge commit 38907c9. SDK Automation 13.0.17.20200918.2

️✔️azure-mgmt-alertsmanagement [View full logs] [Release SDK Changes]

[build_conf] INFO:packaging_tools:Building template azure-mgmt-alertsmanagement
[build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
[build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
[build_conf] INFO:packaging_tools:Template done azure-mgmt-alertsmanagement
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 22 Sep 2020 06:14:56 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"07C1:5F1B:3F80DF:6E3EAC:5F699660","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[ChangeLog] Size of delta 2.320% size of original (original: 35165 chars, delta: 816 chars)
[ChangeLog]

openapi-sdkautomation · 2020-09-17T13:36:45Z

Trenton Generation - Release

Installation instruction for service alertsmanagement [Preview Changes]
az artifacts universal download --organization "https://dev.azure.com/azure-sdk/" --project "internal" --scope project --feed "sdk-automation-test" --name terraform-provider-azurerm --version 0.546838.1 --path .

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 2d75ca9 with merge commit 38907c9. Trenton Automation 13.0.17.20200918.2

[AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'Diagnostics' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'errorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'errorResponseBody' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ManagedResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ManagedResource-tags' with an undefined type and additionalProperties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ActionRule' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ActionRuleProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ActionRulesList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PatchProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PatchObject' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'operation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'operationsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'errorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'errorResponseBody' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'alert' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'alertsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'alertModification' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'alertModificationItem' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'alertsSummary' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'alertsMetaData' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'alertsMetaDataProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'MonitorServiceList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'MonitorServiceDetails' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'errorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'errorResponseBody' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'smartGroupModification' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'smartGroupModificationProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'smartGroupModificationItem' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'smartGroupsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'smartGroup' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ActionGroupsInformation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ThrottlingInformation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AlertRule' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AlertRulesList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AlertRulePatchObject' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Detector' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AlertRuleProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AlertRulePatchProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/EmptyParentSchemaWarning): Schema 'MonitorServiceList' has an allOf list with an empty object schema as a parent, removing it.
[AutoRest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
[AutoRest] WARNING (PreCheck/DuplicateSchema): Duplicate Schema named errorResponse -- properties.error.$ref: undefined => "#/components/schemas/schemas:106" 
[AutoRest] WARNING (PreCheck/DuplicateSchema): Duplicate Schema named errorResponseBody -- properties.details.$ref: undefined => "#/components/schemas/schemas:110" 
[AutoRest] WARNING (): 'cli.flatten.cli-flatten-set-enabled' is not set to true, skip flattenSetter
[AutoRest] WARNING (PreNamer/DeduplicateName): Deduplicating schema name: 'error_response' -> 'error_responseAutoGenerated'
[AutoRest] WARNING (PreNamer/DeduplicateName): Deduplicating schema name: 'error_response_body' -> 'error_response_bodyAutoGenerated'
[AutoRest] WARNING (PreNamer/DeduplicateName): Deduplicating schema name: 'error_response' -> 'error_responseAutoGenerated2'
[AutoRest] WARNING (PreNamer/DeduplicateName): Deduplicating schema name: 'error_response_body' -> 'error_response_bodyAutoGenerated2'
[AutoRest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner

️✔️alertsmanagement [View full logs] [Release Trenton Changes]

[build_package] go get golang.org/x/tools/cmd/goimports: open /usr/local/go/bin/goimports: permission denied
[build_package] Ignoring --cache-directory because the cache is not yet supported on OS "Linux 5.4.0-1025-azure #25~18.04.1-Ubuntu SMP Sat Sep 5 15:28:57 UTC 2020".
Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 22 Sep 2020 06:15:40 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0482:4174:2900E75:5C06B00:5F69968C","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

openapi-sdkautomation · 2020-09-17T13:36:45Z

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-09-17T13:36:47Z

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 2d75ca9 with merge commit 38907c9. SDK Automation 13.0.17.20200918.2
⚠️alertsmanagement/mgmt/2018-05-05 [View full logs]
- alertsmanagement.mgmt.2018-05-05.zip
```
No file is changed.
```

️✔️alertsmanagement/mgmt/2019-03-01 [View full logs] [Release SDK Changes]

alertsmanagement.mgmt.2019-03-01.zip

Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 22 Sep 2020 06:20:43 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0404:FC03:A2D21BB:C3FB33F:5F6997BB","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

⚠️preview/alertsmanagement/mgmt/2018-05-05-preview [View full logs]
- preview.alertsmanagement.mgmt.2018-05-05-preview.zip
```
No file is changed.
```

️✔️preview/alertsmanagement/mgmt/2019-05-05 [View full logs] [Release SDK Changes]

preview.alertsmanagement.mgmt.2019-05-05.zip

Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 22 Sep 2020 06:21:05 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0404:FBFB:42C7C:5EC20:5F6997D1","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

openapi-sdkautomation · 2020-09-17T13:36:51Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

yungezz · 2020-09-21T03:35:35Z

hi @EranGon does that mean this PR is fixing of Swagger: to fix previous merging conflict issue? Otherwise this is a breaking change to end users.

EranGon · 2020-09-21T05:49:04Z

@yungezz you are correct - this PR is fixing of merge problems that cause change #10028 to over overrun. This is not a breaking change as it's documenting the current state

EranGon · 2020-09-21T08:40:58Z

@yungezz Thanks for approving! What's the process of merging this PR? Who's authorized to do it?

yungezz · 2020-09-22T05:53:58Z

@yungezz Thanks for approving! What's the process of merging this PR? Who's authorized to do it?

hi @EranGon for bug fixing, still need to understand customer impact. Is there existing usage on the wrong API version, does it work now?

EranGon · 2020-09-22T06:02:50Z

@yungezz as I've mentioned - this is a do-over of another PR that was already approved and merged, but was overrun by a later change. The original PR is here: #10028 and it was approved by @akning-ms

To copy the main comment:
"I've reviewed the Breaking Change policy, wiki and form. I don't believe this commit is rightly considered a breaking change. Currently, there are missing fields in the responses due to a wrongly structured definition of inheritance by use of a discriminator. This PR fixes this: the only effect of this change is the returning in the response of expected fields which are currently missing. This change is aligning the behavior with the customer's current expectation."

…into formrecognizer_regeneration * 'master' of https://github.com/Azure/azure-rest-api-specs: (52 commits) rename synapse model in java (Azure#10911) [Microsoft.Storage] Adding support for ResourceAccessRules (Azure#10868) add fix (Azure#10906) Revert "[Do Not Merge][Really To Review] add a new apis (Azure#10756)" (Azure#10908) [Do Not Merge][Really To Review] add a new apis (Azure#10756) Add documentation for downloading invoices through Microsoft.Billing API (Azure#10585) Add api-version of 2019-10-01/comsuption to go SDK (Azure#10749) Add location info for cross region compute feature (Azure#10816) Operationalinsights/data export delete all tables param (Azure#10775) Update SDKAutomation.yml for Azure Pipelines (Azure#10904) [Hub Generated] Review request for Microsoft.DigitalTwins to add version stable/2020-10-31 (Azure#10902) [Hub Generated] Review request for Microsoft.Insights to add version preview/2020-05-01-preview (Azure#10891) Add readme.azureresourceschema.md for sample rp (Azure#10764) [Hub Generated] Review request for Microsoft.Security to add version preview/2020-08-06-preview (Azure#10773) DataFactory: Update Rest Sink properties based on ship room comments. (Azure#10815) Bring up ACS eventgrid events swagger (Azure#10880) Assignment config (Azure#10850) .md for python (Azure#10881) Fixed ActionRule's polymorphism via discriminator (Azure#10829) Fixed S360 issues related to ARM & SDK swagger linting errors for Microsoft.Solutions. (Azure#10804) ...

Fixed ActionRule's polymorphism via discriminator

2d75ca9

EranGon requested review from ofirmanor and orieldar as code owners September 17, 2020 13:35

openapi-assignment-bot bot assigned yungezz Sep 17, 2020

yungezz added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Sep 21, 2020

yungezz approved these changes Sep 21, 2020

View reviewed changes

yungezz merged commit 38907c9 into Azure:master Sep 22, 2020

nitegupt pushed a commit to nitegupt/azure-rest-api-specs that referenced this pull request Sep 25, 2020

Fixed ActionRule's polymorphism via discriminator (Azure#10829)

7737935

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed ActionRule's polymorphism via discriminator #10829

Fixed ActionRule's polymorphism via discriminator #10829

EranGon commented Sep 17, 2020

openapi-pipeline-app bot commented Sep 17, 2020 •

edited

Loading

azure-pipelines bot commented Sep 17, 2020

EranGon commented Sep 17, 2020

openapi-sdkautomation bot commented Sep 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 17, 2020 •

edited

Loading

yungezz commented Sep 21, 2020

EranGon commented Sep 21, 2020

EranGon commented Sep 21, 2020

yungezz commented Sep 22, 2020

EranGon commented Sep 22, 2020

Fixed ActionRule's polymorphism via discriminator #10829

Fixed ActionRule's polymorphism via discriminator #10829

Conversation

EranGon commented Sep 17, 2020

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-pipeline-app bot commented Sep 17, 2020 • edited Loading

[Staging] Swagger Validation Report

azure-pipelines bot commented Sep 17, 2020

EranGon commented Sep 17, 2020

openapi-sdkautomation bot commented Sep 17, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Sep 17, 2020 • edited Loading

azure-resource-manager-schemas

openapi-sdkautomation bot commented Sep 17, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Sep 17, 2020 • edited Loading

Azure CLI Extension Generation - Release

openapi-sdkautomation bot commented Sep 17, 2020 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Sep 17, 2020 • edited Loading

Trenton Generation - Release

openapi-sdkautomation bot commented Sep 17, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Sep 17, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Sep 17, 2020 • edited Loading

azure-sdk-for-python-track2 - Release

yungezz commented Sep 21, 2020

EranGon commented Sep 21, 2020

EranGon commented Sep 21, 2020

yungezz commented Sep 22, 2020

EranGon commented Sep 22, 2020

openapi-pipeline-app bot commented Sep 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 17, 2020 •

edited

Loading