-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev billing microsoft.billing 2019 10 01 preview #10585
Dev billing microsoft.billing 2019 10 01 preview #10585
Conversation
[Staging] Swagger Validation Report
️✔️ |
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-go - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-java - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-net - Release
|
8046add
to
bb8c5af
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
bb8c5af
to
3c7e062
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
@bradenwatkins , please remove the 'NotReadyForReview' label when this PR is ready for reveiw. |
3c7e062
to
7bc7ea7
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
7bc7ea7
to
964860a
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
964860a
to
2baf93b
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
2baf93b
to
13aa9d5
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
13aa9d5
to
6c12615
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
6c12615
to
37141d4
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
@bradenwatkins , can you change PR to normal state instead of |
Done! |
1d01280
to
597c2bb
Compare
Comment was made before the most recent commit for PR 10585 in repo Azure/azure-rest-api-specs |
/azp run automation - sdk |
Azure Pipelines successfully started running 1 pipeline(s). |
- 2019-10-01-preview - POST Multiple Modern Invoice Download - 2019-10-01-preview - POST Multiple EA Invoice Download - 2019-10-01-preview - POST Multiple Legacy Invoice Download - 2019-10-01-preview - Changed ErrorResponse and ErrorDetails - 2020-05-01 - POST Multiple Invoice Download (Modern & EA) - 2020-05-01 - POST Multiple Legacy Invoice Download - 2020-05-01 - Changed ErrorResponse and ErrorDetails
597c2bb
to
af57d5d
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
"type": "string" | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am assuming this takes only URLs of documents under requested billingAccountName. Is there any validation performed to guarantee that?
Additionally, what happens if I pass invoice URL to which I do not have access to? Will it fail? #Closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, there is validation that checks that the documents are under the requested billingAccountName as well as whether or not you have access to an invoice. It will fail if you are unauthorized to request any invoice listed.
"type": "string" | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am assuming only URLs under the current subscription are allowed here. Is that correct? #Closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...urce-manager/Microsoft.Billing/stable/2020-05-01/examples/MultipleModernInvoiceDownload.json
Show resolved
Hide resolved
…API (Azure#10585) - 2019-10-01-preview - POST Multiple Modern Invoice Download - 2019-10-01-preview - POST Multiple EA Invoice Download - 2019-10-01-preview - POST Multiple Legacy Invoice Download - 2019-10-01-preview - Changed ErrorResponse and ErrorDetails - 2020-05-01 - POST Multiple Invoice Download (Modern & EA) - 2020-05-01 - POST Multiple Legacy Invoice Download - 2020-05-01 - Changed ErrorResponse and ErrorDetails Co-authored-by: Braden Watkins <brwatkin@microsoft.com>
…into formrecognizer_regeneration * 'master' of https://github.com/Azure/azure-rest-api-specs: (52 commits) rename synapse model in java (Azure#10911) [Microsoft.Storage] Adding support for ResourceAccessRules (Azure#10868) add fix (Azure#10906) Revert "[Do Not Merge][Really To Review] add a new apis (Azure#10756)" (Azure#10908) [Do Not Merge][Really To Review] add a new apis (Azure#10756) Add documentation for downloading invoices through Microsoft.Billing API (Azure#10585) Add api-version of 2019-10-01/comsuption to go SDK (Azure#10749) Add location info for cross region compute feature (Azure#10816) Operationalinsights/data export delete all tables param (Azure#10775) Update SDKAutomation.yml for Azure Pipelines (Azure#10904) [Hub Generated] Review request for Microsoft.DigitalTwins to add version stable/2020-10-31 (Azure#10902) [Hub Generated] Review request for Microsoft.Insights to add version preview/2020-05-01-preview (Azure#10891) Add readme.azureresourceschema.md for sample rp (Azure#10764) [Hub Generated] Review request for Microsoft.Security to add version preview/2020-08-06-preview (Azure#10773) DataFactory: Update Rest Sink properties based on ship room comments. (Azure#10815) Bring up ACS eventgrid events swagger (Azure#10880) Assignment config (Azure#10850) .md for python (Azure#10881) Fixed ActionRule's polymorphism via discriminator (Azure#10829) Fixed S360 issues related to ARM & SDK swagger linting errors for Microsoft.Solutions. (Azure#10804) ...
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.