Update QnAMaker.json - response code correction #10828

sahithikkss-zz · 2020-09-17T11:22:27Z

Correct PATCH EndpointSettings response code from 200 to 204
Not a breaking change but a correction in response code in docs.

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

Correct PATCH EndpointSettings response code from 200 to 204

AutorestCI · 2020-09-17T11:22:30Z

You don't have permission to trigger SDK Automation.
Please add yourself to Azure group from opensource portal if you are MSFT employee,
or please ask reviewer to add comment *** /openapibot sdkautomation ***.
Please ask tih@microsoft.com (or NullMDR in github) for additional help.

openapi-pipeline-app · 2020-09-17T11:22:31Z

[Staging] Swagger Validation Report

️❌BreakingChange: 2 Errors, 0 Warnings [Detail] [Expand]

Rule	Message
`❌` 1011 - AddingResponseCode	The new version adds a response code '204'. New: QnAMaker/stable/v4.0/QnAMaker.json#L80:11
`❌` 1012 - RemovedResponseCode	The new version removes the response code '200' Old: QnAMaker/stable/v4.0/QnAMaker.json#L80:11

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

️️✔️ModelValidation [Detail]

 Validation passes for ModelValidation.

️️✔️SemanticValidation [Detail]

 Validation passes for SemanticValidation.

_{Posted by Swagger Pipeline | How to fix these errors?}

ghost · 2020-09-17T11:22:33Z

Thank you for your contribution sahithikkss! We will review the pull request and get back to you soon.

Update example response set endpoint

azure-pipelines · 2020-09-17T12:59:27Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-09-17T13:00:52Z

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-09-17T13:00:52Z

azure-sdk-for-js - Release

❌ failed [Logs] [Expand Details]

❌ Generate from 58ddb84 with merge commit 1aaf3c1. SDK Automation 13.0.17.20200918.2

❌@azure/cognitiveservices-qnamaker [View full logs] [Release SDK Changes]

[npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve. [npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated [npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file. [npmPack] npm ERR! code ELIFECYCLE [npmPack] npm ERR! errno 2 [npmPack] npm ERR! @azure/cognitiveservices-qnamaker@3.1.1 build: `tsc && rollup -c rollup.config.js && npm run minify` [npmPack] npm ERR! Exit status 2 [npmPack] npm ERR! [npmPack] npm ERR! Failed at the @azure/cognitiveservices-qnamaker@3.1.1 build script. [npmPack] npm ERR! This is probably not a problem with npm. There is likely additional logging output above. [npmPack] [npmPack] npm ERR! A complete log of this run can be found in: [npmPack] npm ERR! /home/sdk/.npm/_logs/2020-09-28T20_22_13_885Z-debug.log [npmPack] npm ERR! code ELIFECYCLE [npmPack] npm ERR! errno 2 [npmPack] npm ERR! @azure/cognitiveservices-qnamaker@3.1.1 prepack: `npm install && npm run build` [npmPack] npm ERR! Exit status 2 [npmPack] npm ERR! [npmPack] npm ERR! Failed at the @azure/cognitiveservices-qnamaker@3.1.1 prepack script. [npmPack] npm ERR! This is probably not a problem with npm. There is likely additional logging output above. [npmPack] [npmPack] npm ERR! A complete log of this run can be found in: [npmPack] npm ERR! /home/sdk/.npm/_logs/2020-09-28T20_22_13_906Z-debug.log Failed to create the package @azure/cognitiveservices-qnamaker. Error: npm pack npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve. npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated npm notice created a lockfile as package-lock.json. You should commit this file. npm ERR! code ELIFECYCLE npm ERR! errno 2 npm ERR! @azure/cognitiveservices-qnamaker@3.1.1 build: `tsc && rollup -c rollup.config.js && npm run minify` npm ERR! Exit status 2 npm ERR! npm ERR! Failed at the @azure/cognitiveservices-qnamaker@3.1.1 build script. npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR! /home/sdk/.npm/_logs/2020-09-28T20_22_13_885Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! @azure/cognitiveservices-qnamaker@3.1.1 prepack: npm install && npm run build
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the @azure/cognitiveservices-qnamaker@3.1.1 prepack script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR! /home/sdk/.npm/_logs/2020-09-28T20_22_13_906Z-debug.log
, {}
Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Mon, 28 Sep 2020 20:22:15 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"07C0:11A05:582B8AB:688F7F4:5F7245F7","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

openapi-sdkautomation · 2020-09-17T13:00:53Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 58ddb84 with merge commit 1aaf3c1. SDK Automation 13.0.17.20200918.2

️✔️cognitiveservices/v4.0 [View full logs] [Release SDK Changes]

cognitiveservices.v4.0.zip

Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Mon, 28 Sep 2020 20:26:29 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"07C4:1EAC:6371AF:FEFE25:5F7246F4","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

openapi-sdkautomation · 2020-09-17T13:00:54Z

azure-resource-manager-schemas - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-09-17T13:00:55Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 58ddb84 with merge commit 1aaf3c1. SDK Automation 13.0.17.20200918.2

️✔️azure-cognitiveservices-knowledge-qnamaker [View full logs] [Release SDK Changes]

[build_conf] INFO:packaging_tools:Building template azure-cognitiveservices-knowledge-qnamaker
[build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
[build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
[build_conf] INFO:packaging_tools:Template done azure-cognitiveservices-knowledge-qnamaker
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Mon, 28 Sep 2020 20:22:42 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0401:0C13:42BBBA:BDAB17:5F724612","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[ChangeLog] Size of delta 1.679% size of original (original: 20850 chars, delta: 350 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Model QueryDTO has a new parameter strict_filters_compound_operation_type

openapi-sdkautomation · 2020-09-17T13:00:56Z

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-09-17T13:00:58Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-09-17T13:01:01Z

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 58ddb84 with merge commit 1aaf3c1. SDK Automation 13.0.17.20200918.2

Failed to find any changed packages. Please check the changed file list.
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/Alterations.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/EndpointKeys.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/EndpointSettings.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/Knowledgebases.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/Operations.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/QnAMakerClient.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/QnAMakerRuntimeClient.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/Runtimes.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/implementation/AlterationsImpl.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/implementation/EndpointKeysImpl.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/implementation/EndpointSettingsImpl.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/implementation/KnowledgebasesImpl.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/implementation/OperationsImpl.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/implementation/QnAMakerClientImpl.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/implementation/QnAMakerRuntimeClientImpl.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/implementation/RuntimesImpl.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/implementation/package-info.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/ActiveLearningSettingsDTO.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/AlterationsDTO.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/ContextDTO.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/CreateKbDTO.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/CreateKbInputDTO.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/DeleteKbContentsDTO.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/EndpointKeysDTO.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/EndpointSettingsDTO.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/EndpointSettingsDTOActiveLearning.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/EnvironmentType.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/Error.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/ErrorCodeType.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/ErrorResponse.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/ErrorResponseError.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/ErrorResponseException.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/FeedbackRecordDTO.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/FeedbackRecordsDTO.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/FileDTO.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/InnerErrorModel.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/KnowledgebaseDTO.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/KnowledgebaseUpdateHeaders.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/KnowledgebasesDTO.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/MetadataDTO.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/Operation.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/OperationStateType.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/OperationsGetDetailsHeaders.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/PromptDTO.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/PromptDTOQna.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/QnADTO.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/QnADTOContext.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/QnADocumentsDTO.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/QnASearchResult.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/QnASearchResultContext.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/QnASearchResultList.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/QueryContextDTO.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/QueryDTO.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/QueryDTOContext.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/ReplaceKbDTO.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/StrictFiltersCompoundOperationType.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/UpdateContextDTO.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/UpdateKbContentsDTO.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/UpdateKbOperationDTO.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/UpdateKbOperationDTOAdd.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/UpdateKbOperationDTODelete.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/UpdateKbOperationDTOUpdate.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/UpdateMetadataDTO.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/UpdateQnaDTO.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/UpdateQnaDTOContext.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/UpdateQnaDTOMetadata.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/UpdateQnaDTOQuestions.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/UpdateQuestionsDTO.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/WordAlterationsDTO.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/models/package-info.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/knowledge/qnamaker/src/main/java/com/microsoft/azure/cognitiveservices/knowledge/qnamaker/package-info.java

johanste · 2020-09-17T20:32:48Z

This is not a Service API breaking change - it is fixing an incorrect description of the service. It may/will be a breaking change for client libraries. Teams may decide to update the return value using readme transforms to avoid new major version of the client library (if the library is not in preview)

sahithikkss-zz · 2020-09-21T12:57:18Z

@johanste , could you please guide us on how to unblock merge for this PR?

sahithikkss-zz · 2020-09-22T10:03:08Z

@yangyuan, could you please review, approve and merge this PR?

azure-pipelines · 2020-09-24T09:17:50Z

Azure Pipelines successfully started running 1 pipeline(s).

Need to add it as a whole Active learning swagger update

azure-pipelines · 2020-09-24T09:46:20Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-09-24T10:15:02Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

sahithikkss-zz · 2020-09-24T10:59:43Z

@bingisbestest @johanste resolved model validation errors. Please review and merge as applicable. Thanks.

sahithikkss-zz · 2020-09-24T11:15:53Z

azure-sdk-for-python
- Breaking Change detected in SDK
⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 303c5ca with merge commit a4e98cb. SDK Automation 13.0.17.20200918.2

⚠️azure-cognitiveservices-knowledge-qnamaker
[View full logs]
[Preview SDK Changes]
Breaking Change Detected* azure-cognitiveservices-knowledge-qnamaker-0.2.0.zip* azure_cognitiveservices_knowledge_qnamaker-0.2.0-py2.py3-none-any.whl[build_conf] INFO:packaging_tools:Building template azure-cognitiveservices-knowledge-qnamaker
[build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
[build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
[build_conf] INFO:packaging_tools:Template done azure-cognitiveservices-knowledge-qnamaker
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package] warnings.warn(msg)
[build_package] warning: no files found matching '.py' under directory 'tests'
[build_package] warning: no files found matching '.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package] warnings.warn(msg)
[build_package] warning: no files found matching '.py' under directory 'tests'
[build_package] warning: no files found matching '.yaml' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[ChangeLog] Size of delta 2.863% size of original (original: 20850 chars, delta: 597 chars)
[ChangeLog] Features
[ChangeLog]
[ChangeLog] - Model QueryDTO has a new parameter strict_filters_compound_operation_type
[ChangeLog]
[ChangeLog] Breaking changes
[ChangeLog]
[ChangeLog] - Operation KnowledgebaseOperations.replace has a new signature
[ChangeLog] - Model ReplaceKbDTO has a new signature

strict_filters_compound_operation_type is an optional parameter in QueryDTO
In ReplaceKbDTO , change is qnAList -> qnaList a correction to resolve model validation and to be consistent across examples.
@johanste , could you please see if this can be labelled as "not a breaking change".

azure-pipelines · 2020-09-25T13:15:15Z

Azure Pipelines successfully started running 1 pipeline(s).

sahithikkss-zz · 2020-09-25T13:38:36Z

@johanste Resolved model validation error by changing the example. Please review.

sahithikkss-zz · 2020-09-28T17:59:33Z

@yangyuan, Could you please merge this PR?

…into fix_kv_python_readme * 'master' of https://github.com/Azure/azure-rest-api-specs: (364 commits) Update pull_request_assignment.yml (Azure#11026) [Ready For Review] a new version with changes on compute instance/vm sizes (Azure#10542) correct the description (Azure#11009) [Data plane][Azure Cognitive Search] Add encryptionKey property to indexer, datasource and skillset metadata (Azure#10839) Adding reseller Id (Azure#11013) Update Phone Number Administration Swagger to remove unnecessary parameters, and adjust API responses. (Azure#11010) update all swaggers to 2020-05-01 API version (Azure#10960) Changed the Instance Field Description to Support Primitive Data type (Azure#10995) Fix the acronym casing for ACSSMS (Azure#10988) Update pull_request_assignment.yml (Azure#10974) Add sdk_customization.md (Azure#10861) [Hub Generated] Review request for Microsoft.DataMigration to add version preview/2018-07-15-preview (Azure#10494) Make version int64 (Azure#10984) Microsoft.Security/iotDefenderSettings (2020-08-06-preview) (Azure#10810) added incident alerts and incident bookmarks APIs (Azure#10806) add publicNetworkAccess property to datafactory (Azure#10956) Fix CDN matchValues and selector fields to be optional (Azure#10950) [Microsoft.StorageSync] Introduce 2020-09-01 API version (Azure#10836) strings update (Azure#10969) Update QnAMaker.json - response code correction (Azure#10828) ...

Update QnAMaker.json

5586847

Correct PATCH EndpointSettings response code from 200 to 204

openapi-assignment-bot bot assigned anuchandy Sep 17, 2020

ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Sep 17, 2020

Update example response set endpoint

1679241

Update example response set endpoint

sahithikkss-zz marked this pull request as ready for review September 17, 2020 14:02

sahithikkss-zz requested a review from yangyuan as a code owner September 17, 2020 14:02

johanste added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Sep 17, 2020

sahithikkss added 3 commits September 24, 2020 14:33

Prettier validation fix

025e295

required propery validation fix

5e5ae55

remove alternateQuestionClusters from example

89c4876

removed alternateQuestionClusters across the example

303c5ca

Need to add it as a whole Active learning swagger update

openapi-sdkautomation bot added the CI-BreakingChange-Python label Sep 24, 2020

ModelValidation fixed in example instead of spec - non breaking change

58ddb84

openapi-sdkautomation bot removed the CI-BreakingChange-Python label Sep 25, 2020

johanste approved these changes Sep 28, 2020

View reviewed changes

johanste added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Sep 28, 2020

sahithikkss-zz mentioned this pull request Sep 28, 2020

Update documentation with more details #10889

Closed

10 tasks

anuchandy approved these changes Sep 28, 2020

View reviewed changes

anuchandy merged commit 1aaf3c1 into Azure:master Sep 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update QnAMaker.json - response code correction #10828

Update QnAMaker.json - response code correction #10828

sahithikkss-zz commented Sep 17, 2020

AutorestCI commented Sep 17, 2020

openapi-pipeline-app bot commented Sep 17, 2020 •

edited

Loading

ghost commented Sep 17, 2020

azure-pipelines bot commented Sep 17, 2020

openapi-sdkautomation bot commented Sep 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 17, 2020 •

edited

Loading

johanste commented Sep 17, 2020

sahithikkss-zz commented Sep 21, 2020

sahithikkss-zz commented Sep 22, 2020

azure-pipelines bot commented Sep 24, 2020

azure-pipelines bot commented Sep 24, 2020

openapi-sdkautomation bot commented Sep 24, 2020 •

edited

Loading

sahithikkss-zz commented Sep 24, 2020

sahithikkss-zz commented Sep 24, 2020

azure-sdk-for-python

azure-pipelines bot commented Sep 25, 2020

sahithikkss-zz commented Sep 25, 2020

sahithikkss-zz commented Sep 28, 2020

Update QnAMaker.json - response code correction #10828

Update QnAMaker.json - response code correction #10828

Conversation

sahithikkss-zz commented Sep 17, 2020

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

AutorestCI commented Sep 17, 2020

openapi-pipeline-app bot commented Sep 17, 2020 • edited Loading

[Staging] Swagger Validation Report

ghost commented Sep 17, 2020

azure-pipelines bot commented Sep 17, 2020

openapi-sdkautomation bot commented Sep 17, 2020 • edited Loading

Azure CLI Extension Generation - Release

openapi-sdkautomation bot commented Sep 17, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Sep 17, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Sep 17, 2020 • edited Loading

azure-resource-manager-schemas - Release

openapi-sdkautomation bot commented Sep 17, 2020 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Sep 17, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Sep 17, 2020 • edited Loading

Trenton Generation - Release

openapi-sdkautomation bot commented Sep 17, 2020 • edited Loading

azure-sdk-for-java - Release

johanste commented Sep 17, 2020

sahithikkss-zz commented Sep 21, 2020

sahithikkss-zz commented Sep 22, 2020

azure-pipelines bot commented Sep 24, 2020

azure-pipelines bot commented Sep 24, 2020

openapi-sdkautomation bot commented Sep 24, 2020 • edited Loading

azure-sdk-for-python-track2 - Release

sahithikkss-zz commented Sep 24, 2020

sahithikkss-zz commented Sep 24, 2020

azure-sdk-for-python

azure-pipelines bot commented Sep 25, 2020

sahithikkss-zz commented Sep 25, 2020

sahithikkss-zz commented Sep 28, 2020

openapi-pipeline-app bot commented Sep 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 24, 2020 •

edited

Loading