Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the Instance Field Description to Support Primitive Data type #10995

Conversation

Sandip-Raiyani
Copy link
Contributor

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

sandshadow and others added 30 commits January 9, 2018 17:03
Fix R2016 by making PATCH body properties optional. Suppress the remaining 4 violations that are confirmed as false positives.
…Prop

Added dataStringComparisonBehavior parameter to reference data put/update spec
…onKeyProperty

Adding partitionKeyProperty to EnvironmentCreate and EnvironmentGet request.
…lingAsString

changing modelAsString for partitionKeyPRoperties
Introduce longterm environment to TSI resource hierarchy
@AutorestCI
Copy link

You don't have permission to trigger SDK Automation.
Please add yourself to Azure group from opensource portal if you are MSFT employee,
or please ask reviewer to add comment *** /openapibot sdkautomation ***.
Please ask tih@microsoft.com (or NullMDR in github) for additional help.

@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Sep 30, 2020
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 30, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
️✔️ModelValidation [Detail]
 Validation passes for ModelValidation. 
️✔️SemanticValidation [Detail]
 Validation passes for SemanticValidation. 
Posted by Swagger Pipeline | How to fix these errors?

@ghost
Copy link

ghost commented Sep 30, 2020

Thank you for your contribution Sandip-Raiyani! We will review the pull request and get back to you soon.

@jhendrixMSFT
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 1, 2020

azure-sdk-for-go - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 1, 2020

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 1, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 1, 2020

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 1, 2020

azure-sdk-for-python - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 1, 2020

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 1, 2020

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 1, 2020

azure-resource-manager-schemas - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 1, 2020

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@jhendrixMSFT jhendrixMSFT merged commit 9a6510d into Azure:master Oct 1, 2020
iscai-msft added a commit to iscai-msft/azure-rest-api-specs that referenced this pull request Oct 5, 2020
…into fix_kv_python_readme

* 'master' of https://github.com/Azure/azure-rest-api-specs: (364 commits)
  Update pull_request_assignment.yml (Azure#11026)
  [Ready For Review] a new version with changes on compute instance/vm sizes (Azure#10542)
  correct the description (Azure#11009)
  [Data plane][Azure Cognitive Search] Add encryptionKey property to indexer, datasource and skillset metadata (Azure#10839)
  Adding reseller Id (Azure#11013)
  Update Phone Number Administration Swagger to remove unnecessary parameters, and adjust API responses. (Azure#11010)
  update all swaggers to 2020-05-01 API version (Azure#10960)
  Changed the Instance Field Description to Support Primitive Data type (Azure#10995)
  Fix the acronym casing for ACSSMS (Azure#10988)
  Update pull_request_assignment.yml (Azure#10974)
  Add sdk_customization.md (Azure#10861)
  [Hub Generated] Review request for Microsoft.DataMigration to add version preview/2018-07-15-preview (Azure#10494)
  Make version int64 (Azure#10984)
  Microsoft.Security/iotDefenderSettings (2020-08-06-preview) (Azure#10810)
  added incident alerts and incident bookmarks APIs (Azure#10806)
  add publicNetworkAccess property to datafactory (Azure#10956)
  Fix CDN matchValues and selector fields to be optional (Azure#10950)
  [Microsoft.StorageSync] Introduce 2020-09-01 API version (Azure#10836)
  strings update (Azure#10969)
  Update QnAMaker.json - response code correction (Azure#10828)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants