-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add last access time and smb multichannel feature into Aug2020 preview #10993
Conversation
[Staging] Swagger Validation Report
❌ |
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-go - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-python-track2 - Release
- Breaking Change detected in SDK
|
azure-resource-manager-schemas - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure Pipelines successfully started running 1 pipeline(s). |
@ZFChen Please fill out the checkboxes in the issue after you have followed the instructions. You will need to clear linter errors and determine if asn ARM review is warranted. |
Azure Pipelines successfully started running 1 pipeline(s). |
Fixed |
@zfchen95 Per the breaing change errors, these changes require a new api-version (breaking changes are allowed in preview APIs that are < 1 year old, but only in a new api-version). |
Please note that the new properties are added under a preview API version. There are two types of breaking changes. For additive breaking change, from what I learned, can always be added to a preview API version that was released within a year. |
@zfchen95 Is this a p[ublic preview or private preview? If public preview, then a new api-version is required. If private preview, then it seems this should go in the private repo (although if the current version is also a private preview, we cna make an exception in this case, let me know). |
Based on what I learned from the Microsoft Rest API guideline (https://github.com/microsoft/api-guidelines/blob/vNext/azure/Guidelines.md#preview-versions), it is not a requirement to bump the version for adding evolutionary change. |
@zfchen95 These are not evolutionary changes, they are listed as breaking changes, which require a version change for public preview APIs. from the REST API Guidlines:
Per the breaking changes mentioned above, this is a breaking change and so, would require a version update. I believe we can provide an exception in this case, but these rules will soon be strictly enforced, and you should take this into account when pl;anning API changes in the future. |
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.