[Storage] Upgrade API version to 2020-08-01-preview, and version to 18.0.0-beta #16355
Conversation
blueww
requested review from
allenjzhang,
bquantump,
m-nash,
markcowl,
nisha-bhatia and
YalinLi0312
as code owners
ghost
added
the
blueww
changed the title
|
@markcowl I have regenerated the SDK code from latest swagger ,and add a new commit into this PR, to support Blob inventory. The related swagger swagger PRs are: |
| @@ -10,7 +10,7 @@ | |||
| Development of this library has shifted focus to the Azure Unified SDK. The future development will be focused on "Azure.ResourceManager.Storage" (https://www.nuget.org/packages/Azure.ResourceManager.Storage/). Please see the package changelog for more information. | |||
| </Description> | |||
| <AssemblyName>Microsoft.Azure.Management.Storage</AssemblyName> | |||
| <Version>17.2.0</Version> | |||
| <Version>18.0.0-beta</Version> | |||
There was a problem hiding this comment.
This should be 18.0.0-beta.1 to conform with the versioning guidelines: https://azure.github.io/azure-sdk/dotnet_introduction.html#dotnet-versionnumbers
|
|
||
| **Breaking changes** | ||
|
|
||
| - In StorageManagementClient.FileServices.SetServiceProperties(), add a madatory parameter with type Microsoft.Azure.Management.Storage.Models.FileServiceProperties, to input all FileService properties, and remove 2 parameters to input FileService properties: cors， shareDeleteRetentionPolicy. |
There was a problem hiding this comment.
Is this just a temporary change for the preview, or do you intend to go through with this change in the stable API? This will need to go through a breaking change review before you can release as a stable api
There was a problem hiding this comment.
This breaking will also in SDK of stable API version. How to go through a breaking change review？
I would suggest to merge this PR then start the process to breaking review (or resolve the breaking).
Actually, this is not caused by the swagger (or API) breaking, but caused by a limitation of autorest.
We have config payload-flattening-threshold: 2 in https://github.com/Azure/azure-rest-api-specs/blob/master/specification/storage/resource-manager/readme.csharp.md#common-c-settings, so when a object has <= 2 child properties, in autorest generated code, functions will use the child properties as input in stead of the object; when the object has >=3 properties, functions will use the object as input.
So when FileServiceProperties properties count increase from 2 to 3, the function SetServiceProperties() will change from input the file service properties to input FileServiceProperties object.
This kind of breaking happens frequently in .net SDK. Do you have any idea how to resolve this?
If we change the payload-flattening-threshold: 2 to a bigger value, it will also cause many of the existing API breaking.
There was a problem hiding this comment.
We can likely solve it in individual cases with customizations. Can you send me an email, so I can bring in some generator folks?
|
@markcowl PSH new feature depends on this PR, hope we can we merge it ASAP? |
…8.0.0-beta (Azure#16355) * [Storage] Upgrade to 2020-08-01-preview * [Storage] Support blob Inventory rule * [storage] Update version to 18.0.0-beta.1
Add several new features, see the change log.
The related swagger swagger PRs are:
Azure/azure-rest-api-specs#10570
Azure/azure-rest-api-specs#10868
Azure/azure-rest-api-specs#10900
Azure/azure-rest-api-specs#10993
Azure/azure-rest-api-specs#11048