fix correctness errors for AVS 2020-03-20 API #11317

ctaggart · 2020-10-21T22:28:54Z

This is to fix errors identified in:

Swagger Correctness: MICROSOFT.AVS(Azure VMware Solution)
https://msazure.visualstudio.com/Swagger%20KPIs/_workitems/edit/8187811
linting error identified at https://aka.ms/LiveValidation.

The 11 errors that the CI check lists as "breaking changes" fall into two categories:

1041 - AddedPropertyInResponse
These are all for Operations_List, to match what is actually returned.
1023 - TypeFormatChanged
The lint errors say that a format is required for integer. It was unspecified. They are all int32. I can roll back afa0274 if needed, but I'd prefer to fix this lint error.

The existing SDKs will continue to work against the 2020-03-20 API. The Python SDK reported one breaking change in its API for clusters.create_or_update signature.

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

…List"

azure-pipelines · 2020-10-21T22:29:12Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-10-21T22:30:31Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from bbaa684 with merge commit 600bae4. SDK Automation 13.0.17.20200918.2

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Avs [View full logs] [Release SDK Changes]

Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 27 Oct 2020 02:08:50 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0740:0E04:31272A:814B36:5F978132","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

openapi-sdkautomation · 2020-10-21T22:30:33Z

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from bbaa684 with merge commit 600bae4. SDK Automation 13.0.17.20200918.2

⚠️sdk/avs/mgmt-v2019_08_09_preview [View full logs] [Release SDK Changes]

[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.8:jar (default-cli) on project azure-avs: MavenReportException: Error while creating archive: 
[mvn] [ERROR] Exit code: 1 - /z/work/azure-sdk-for-java/sdk/avs/mgmt-v2019_08_09_preview/src/main/java/com/microsoft/azure/management/avs/v2019_08_09_preview/package-info.java:11: warning: a package-info.java file has already been seen for package com.microsoft.azure.management.avs.v2019_08_09_preview
[mvn] [ERROR] package com.microsoft.azure.management.avs.v2019_08_09_preview;
[mvn] [ERROR]                                           ^
[mvn] [ERROR] javadoc: warning - Multiple sources of package comments found for package "com.microsoft.azure.management.avs.v2019_08_09_preview"
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/avs/mgmt-v2019_08_09_preview/src/main/java/com/microsoft/azure/management/avs/v20190809preview/PrivateClouds.java:12: error: cannot access AdminCredentials
[mvn] [ERROR] import com.microsoft.azure.management.avs.v20190809preview.models.AdminCredentials;
[mvn] [ERROR]                                                                  ^
[mvn] [ERROR]   bad source file: /z/work/azure-sdk-for-java/sdk/avs/mgmt-v2019_08_09_preview/src/main/java/com/microsoft/azure/management/avs/v20190809preview/models/AdminCredentials.java
[mvn] [ERROR]     file does not contain class com.microsoft.azure.management.avs.v20190809preview.models.AdminCredentials
[mvn] [ERROR]     Please remove or make sure it appears in the correct subdirectory of the sourcepath.
[mvn] [ERROR] 
[mvn] [ERROR] Command line was: /usr/lib/jvm/java-8-openjdk-amd64/jre/../bin/javadoc @options @packages
[mvn] [ERROR] 
[mvn] [ERROR] Refer to the generated Javadoc files in '/z/work/azure-sdk-for-java/sdk/avs/mgmt-v2019_08_09_preview/target/apidocs' dir.
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 27 Oct 2020 02:08:35 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0741:922E:C6CB0:DFAD4:5F978123","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

⚠️sdk/avs/mgmt-v2020_03_20 [View full logs] [Release SDK Changes]

Only show 100 items here, please refer to log for details.

[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.8:jar (default-cli) on project azure-avs: MavenReportException: Error while creating archive: 
[mvn] [ERROR] Exit code: 1 - /z/work/azure-sdk-for-java/sdk/avs/mgmt-v2020_03_20/src/main/java/com/microsoft/azure/management/avs/v20200320/package-info.java:11: warning: a package-info.java file has already been seen for package com.microsoft.azure.management.avs.v2020_03_20
[mvn] [ERROR] package com.microsoft.azure.management.avs.v2020_03_20;
[mvn] [ERROR]                                           ^
[mvn] [ERROR] javadoc: warning - Multiple sources of package comments found for package "com.microsoft.azure.management.avs.v2020_03_20"
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/avs/mgmt-v2020_03_20/src/main/java/com/microsoft/azure/management/avs/v2020_03_20/AdminCredentials.java:11: error: package com.microsoft.azure.arm.model does not exist
[mvn] [ERROR] import com.microsoft.azure.arm.model.HasInner;
[mvn] [ERROR]                                     ^
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/avs/mgmt-v2020_03_20/src/main/java/com/microsoft/azure/management/avs/v2020_03_20/AdminCredentials.java:12: error: package com.microsoft.azure.arm.resources.models does not exist
[mvn] [ERROR] import com.microsoft.azure.arm.resources.models.HasManager;
[mvn] [ERROR]                                                ^
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/avs/mgmt-v2020_03_20/src/main/java/com/microsoft/azure/management/avs/v2020_03_20/AdminCredentials.java:19: error: cannot find symbol
[mvn] [ERROR] public interface AdminCredentials extends HasInner, HasManager {
[mvn] [ERROR]                                           ^
[mvn] [ERROR]   symbol: class HasInner
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/avs/mgmt-v2020_03_20/src/main/java/com/microsoft/azure/management/avs/v2020_03_20/AdminCredentials.java:19: error: cannot find symbol
[mvn] [ERROR] public interface AdminCredentials extends HasInner, HasManager {
[mvn] [ERROR]                                                                            ^
[mvn] [ERROR]   symbol: class HasManager
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/avs/mgmt-v2020_03_20/src/main/java/com/microsoft/azure/management/avs/v2020_03_20/implementation/AVSManager.java:16: error: package com.microsoft.azure.arm.resources does not exist
[mvn] [ERROR] import com.microsoft.azure.arm.resources.AzureConfigurable;
[mvn] [ERROR]                                         ^
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/avs/mgmt-v2020_03_20/src/main/java/com/microsoft/azure/management/avs/v2020_03_20/implementation/AVSManager.java:25: error: package com.microsoft.azure.arm.resources.implementation does not exist
[mvn] [ERROR] import com.microsoft.azure.arm.resources.implementation.AzureConfigurableCoreImpl;
[mvn] [ERROR]                                                        ^
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/avs/mgmt-v2020_03_20/src/main/java/com/microsoft/azure/management/avs/v2020_03_20/implementation/AVSManager.java:26: error: package com.microsoft.azure.arm.resources.implementation does not exist
[mvn] [ERROR] import com.microsoft.azure.arm.resources.implementation.ManagerCore;
[mvn] [ERROR]                                                        ^
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/avs/mgmt-v2020_03_20/src/main/java/com/microsoft/azure/management/avs/v2020_03_20/implementation/AVSManager.java:31: error: cannot find symbol
[mvn] [ERROR] public final class AVSManager extends ManagerCore {
[mvn] [ERROR]                                       ^
[mvn] [ERROR]   symbol: class ManagerCore
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/avs/mgmt-v2020_03_20/src/main/java/com/microsoft/azure/management/avs/v2020_03_20/Operations.java:13: error: package com.microsoft.azure.arm.model does not exist
[mvn] [ERROR] import com.microsoft.azure.arm.model.HasInner;
[mvn] [ERROR]                                     ^
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/avs/mgmt-v2020_03_20/src/main/java/com/microsoft/azure/management/avs/v2020_03_20/Operations.java:18: error: cannot find symbol
[mvn] [ERROR] public interface Operations extends HasInner {
[mvn] [ERROR]                                     ^
[mvn] [ERROR]   symbol: class HasInner
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/avs/mgmt-v2020_03_20/src/main/java/com/microsoft/azure/management/avs/v2020_03_20/Locations.java:13: error: package com.microsoft.azure.arm.model does not exist
[mvn] [ERROR] import com.microsoft.azure.arm.model.HasInner;
[mvn] [ERROR]                                     ^
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/avs/mgmt-v2020_03_20/src/main/java/com/microsoft/azure/management/avs/v2020_03_20/Locations.java:18: error: cannot find symbol
[mvn] [ERROR] public interface Locations extends HasInner {
[mvn] [ERROR]                                    ^
[mvn] [ERROR]   symbol: class HasInner
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/avs/mgmt-v2020_03_20/src/main/java/com/microsoft/azure/management/avs/v2020_03_20/PrivateClouds.java:11: error: package com.microsoft.azure.arm.collection does not exist
[mvn] [ERROR] import com.microsoft.azure.arm.collection.SupportsCreating;
[mvn] [ERROR]                                          ^
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/avs/mgmt-v2020_03_20/src/main/java/com/microsoft/azure/management/avs/v2020_03_20/PrivateClouds.java:12: error: package com.microsoft.azure.arm.resources.collection does not exist
[mvn] [ERROR] import com.microsoft.azure.arm.resources.collection.SupportsDeletingByResourceGroup;
[mvn] [ERROR]                                                    ^
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/avs/mgmt-v2020_03_20/src/main/java/com/microsoft/azure/management/avs/v2020_03_20/PrivateClouds.java:13: error: package com.microsoft.azure.arm.resources.collection does not exist
[mvn] [ERROR] import com.microsoft.azure.arm.resources.collection.SupportsBatchDeletion;
[mvn] [ERROR]                                                    ^
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/avs/mgmt-v2020_03_20/src/main/java/com/microsoft/azure/management/avs/v2020_03_20/PrivateClouds.java:14: error: package com.microsoft.azure.arm.resources.collection does not exist
[mvn] [ERROR] import com.microsoft.azure.arm.resources.collection.SupportsGettingByResourceGroup;
[mvn] [ERROR]                                                    ^
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/avs/mgmt-v2020_03_20/src/main/java/com/microsoft/azure/management/avs/v2020_03_20/PrivateClouds.java:16: error: package com.microsoft.azure.arm.resources.collection does not exist
[mvn] [ERROR] import com.microsoft.azure.arm.resources.collection.SupportsListingByResourceGroup;
[mvn] [ERROR]                                                    ^
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/avs/mgmt-v2020_03_20/src/main/java/com/microsoft/azure/management/avs/v2020_03_20/PrivateClouds.java:17: error: package com.microsoft.azure.arm.collection does not exist
[mvn] [ERROR] import com.microsoft.azure.arm.collection.SupportsListing;
[mvn] [ERROR]                                          ^
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/avs/mgmt-v2020_03_20/src/main/java/com/microsoft/azure/management/avs/v2020_03_20/PrivateClouds.java:19: error: package com.microsoft.azure.arm.model does not exist
[mvn] [ERROR] import com.microsoft.azure.arm.model.HasInner;
[mvn] [ERROR]                                     ^
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/avs/mgmt-v2020_03_20/src/main/java/com/microsoft/azure/management/avs/v2020_03_20/PrivateClouds.java:24: error: cannot find symbol
[mvn] [ERROR] public interface PrivateClouds extends SupportsCreating, SupportsDeletingByResourceGroup, SupportsBatchDeletion, SupportsGettingByResourceGroup, SupportsListingByResourceGroup, SupportsListing, HasInner {
[mvn] [ERROR]                                        ^
[mvn] [ERROR]   symbol: class SupportsCreating
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/avs/mgmt-v2020_03_20/src/main/java/com/microsoft/azure/management/avs/v2020_03_20/PrivateCloud.java:11: error: package com.microsoft.azure.arm.model does not exist
[mvn] [ERROR] import com.microsoft.azure.arm.model.HasInner;
[mvn] [ERROR]                                     ^
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/avs/mgmt-v2020_03_20/src/main/java/com/microsoft/azure/management/avs/v2020_03_20/PrivateCloud.java:12: error: package com.microsoft.azure.arm.resources.models does not exist
[mvn] [ERROR] import com.microsoft.azure.arm.resources.models.Resource;
[mvn] [ERROR]                                                ^
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/avs/mgmt-v2020_03_20/src/main/java/com/microsoft/azure/management/avs/v2020_03_20/PrivateCloud.java:13: error: package com.microsoft.azure.arm.resources.models does not exist
[mvn] [ERROR] import com.microsoft.azure.arm.resources.models.GroupableResourceCore;
[mvn] [ERROR]                                                ^
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/avs/mgmt-v2020_03_20/src/main/java/com/microsoft/azure/management/avs/v2020_03_20/PrivateCloud.java:14: error: package com.microsoft.azure.arm.resources.models does not exist
[mvn] [ERROR] import com.microsoft.azure.arm.resources.models.HasResourceGroup;
[mvn] [ERROR]                                                ^
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/avs/mgmt-v2020_03_20/src/main/java/com/microsoft/azure/management/avs/v2020_03_20/PrivateCloud.java:15: error: package com.microsoft.azure.arm.model does not exist
[mvn] [ERROR] import com.microsoft.azure.arm.model.Refreshable;
[mvn] [ERROR]                                     ^
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/avs/mgmt-v2020_03_20/src/main/java/com/microsoft/azure/management/avs/v2020_03_20/PrivateCloud.java:16: error: package com.microsoft.azure.arm.model does not exist
[mvn] [ERROR] import com.microsoft.azure.arm.model.Updatable;
[mvn] [ERROR]                                     ^
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/avs/mgmt-v2020_03_20/src/main/java/com/microsoft/azure/management/avs/v2020_03_20/PrivateCloud.java:17: error: package com.microsoft.azure.arm.model does not exist
[mvn] [ERROR] import com.microsoft.azure.arm.model.Appliable;
[mvn] [ERROR]                                     ^
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/avs/mgmt-v2020_03_20/src/main/java/com/microsoft/azure/management/avs/v2020_03_20/PrivateCloud.java:18: error: package com.microsoft.azure.arm.model does not exist
[mvn] [ERROR] import com.microsoft.azure.arm.model.Creatable;
[mvn] [ERROR]                                     ^
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/avs/mgmt-v2020_03_20/src/main/java/com/microsoft/azure/management/avs/v2020_03_20/PrivateCloud.java:19: error: package com.microsoft.azure.arm.resources.models does not exist
[mvn] [ERROR] import com.microsoft.azure.arm.resources.models.HasManager;
[mvn] [ERROR]                                                ^
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/avs/mgmt-v2020_03_20/src/main/java/com/microsoft/azure/management/avs/v2020_03_20/PrivateCloud.java:27: error: cannot find symbol
[mvn] [ERROR] public interface PrivateCloud extends HasInner, Resource, GroupableResourceCore, HasResourceGroup, Refreshable, Updatable, HasManager {

openapi-sdkautomation · 2020-10-21T22:30:33Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-10-21T22:30:34Z

azure-sdk-for-python - Release

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from bbaa684 with merge commit 600bae4. SDK Automation 13.0.17.20200918.2

⚠️azure-mgmt-avs [View full logs] [Release SDK Changes] Breaking Change Detected

[build_conf] INFO:packaging_tools:Building template azure-mgmt-avs
[build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
[build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
[build_conf] INFO:packaging_tools:Template done azure-mgmt-avs
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 27 Oct 2020 02:06:43 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0703:33F1:467B2D:D7112F:5F9780B3","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[ChangeLog] Size of delta 16.131% size of original (original: 23098 chars, delta: 3726 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Model ManagementCluster has a new parameter provisioning_state
[ChangeLog]   - Model Operation has a new parameter origin
[ChangeLog]   - Model Operation has a new parameter properties
[ChangeLog]   - Model Operation has a new parameter is_data_action
[ChangeLog] 
[ChangeLog] **Breaking changes**
[ChangeLog] 
[ChangeLog]   - Operation ClustersOperations.create_or_update has a new signature
[ChangeLog]   - Operation ClustersOperations.create_or_update has a new signature

openapi-sdkautomation · 2020-10-21T22:30:34Z

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from bbaa684 with merge commit 600bae4. SDK Automation 13.0.17.20200918.2

️✔️avs/mgmt/2020-03-20 [View full logs] [Release SDK Changes]

avs.mgmt.2020-03-20.zip

Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 27 Oct 2020 02:09:10 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0781:9231:887351:999FFA:5F978146","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

⚠️preview/avs/mgmt/2019-08-09-preview [View full logs]
- preview.avs.mgmt.2019-08-09-preview.zip
```
No file is changed.
```

openapi-sdkautomation · 2020-10-21T22:30:34Z

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-10-21T22:30:35Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from bbaa684 with merge commit 600bae4. SDK Automation 13.0.17.20200918.2

️✔️@azure/arm-avs [View full logs] [Release SDK Changes]

azure-arm-avs-0.1.0.tgz

Only show 100 items here, please refer to log for details.

[npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
[npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
[npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/avsClient.js → ./dist/arm-avs.js...
[npmPack] created ./dist/arm-avs.js in 344ms
[npmPack] npm notice 
[npmPack] npm notice package: @azure/arm-avs@0.1.0
[npmPack] npm notice === Tarball Contents === 
[npmPack] npm notice 98.8kB  dist/arm-avs.js                              
[npmPack] npm notice 32.5kB  dist/arm-avs.min.js                          
[npmPack] npm notice 9.1kB   esm/operations/authorizations.js             
[npmPack] npm notice 671B    esm/models/authorizationsMappers.js          
[npmPack] npm notice 1.7kB   esm/avsClient.js                             
[npmPack] npm notice 2.4kB   esm/avsClientContext.js                      
[npmPack] npm notice 10.8kB  esm/operations/clusters.js                   
[npmPack] npm notice 662B    esm/models/clustersMappers.js                
[npmPack] npm notice 6.5kB   esm/operations/hcxEnterpriseSites.js         
[npmPack] npm notice 667B    esm/models/hcxEnterpriseSitesMappers.js      
[npmPack] npm notice 345B    esm/models/index.js                          
[npmPack] npm notice 543B    esm/operations/index.js                      
[npmPack] npm notice 2.6kB   esm/operations/locations.js                  
[npmPack] npm notice 454B    esm/models/locationsMappers.js               
[npmPack] npm notice 31.4kB  esm/models/mappers.js                        
[npmPack] npm notice 2.2kB   esm/operations/operations.js                 
[npmPack] npm notice 584B    esm/models/operationsMappers.js              
[npmPack] npm notice 2.7kB   esm/models/parameters.js                     
[npmPack] npm notice 12.6kB  esm/operations/privateClouds.js              
[npmPack] npm notice 695B    esm/models/privateCloudsMappers.js           
[npmPack] npm notice 961B    rollup.config.js                             
[npmPack] npm notice 1.6kB   package.json                                 
[npmPack] npm notice 457B    tsconfig.json                                
[npmPack] npm notice 198.7kB dist/arm-avs.js.map                          
[npmPack] npm notice 29.0kB  dist/arm-avs.min.js.map                      
[npmPack] npm notice 2.4kB   esm/operations/authorizations.d.ts.map       
[npmPack] npm notice 4.3kB   esm/operations/authorizations.js.map         
[npmPack] npm notice 366B    esm/models/authorizationsMappers.d.ts.map    
[npmPack] npm notice 379B    esm/models/authorizationsMappers.js.map      
[npmPack] npm notice 767B    esm/avsClient.d.ts.map                       
[npmPack] npm notice 983B    esm/avsClient.js.map                         
[npmPack] npm notice 484B    esm/avsClientContext.d.ts.map                
[npmPack] npm notice 1.4kB   esm/avsClientContext.js.map                  
[npmPack] npm notice 2.8kB   esm/operations/clusters.d.ts.map             
[npmPack] npm notice 5.3kB   esm/operations/clusters.js.map               
[npmPack] npm notice 361B    esm/models/clustersMappers.d.ts.map          
[npmPack] npm notice 374B    esm/models/clustersMappers.js.map            
[npmPack] npm notice 2.8kB   esm/operations/hcxEnterpriseSites.d.ts.map   
[npmPack] npm notice 3.7kB   esm/operations/hcxEnterpriseSites.js.map     
[npmPack] npm notice 374B    esm/models/hcxEnterpriseSitesMappers.d.ts.map
[npmPack] npm notice 387B    esm/models/hcxEnterpriseSitesMappers.js.map  
[npmPack] npm notice 13.4kB  esm/models/index.d.ts.map                    
[npmPack] npm notice 248B    esm/operations/index.d.ts.map                
[npmPack] npm notice 126B    esm/models/index.js.map                      
[npmPack] npm notice 263B    esm/operations/index.js.map                  
[npmPack] npm notice 1.1kB   esm/operations/locations.d.ts.map            
[npmPack] npm notice 1.5kB   esm/operations/locations.js.map              
[npmPack] npm notice 220B    esm/models/locationsMappers.d.ts.map         
[npmPack] npm notice 233B    esm/models/locationsMappers.js.map           
[npmPack] npm notice 1.7kB   esm/models/mappers.d.ts.map                  
[npmPack] npm notice 17.8kB  esm/models/mappers.js.map                    
[npmPack] npm notice 1.0kB   esm/operations/operations.d.ts.map           
[npmPack] npm notice 1.4kB   esm/operations/operations.js.map             
[npmPack] npm notice 297B    esm/models/operationsMappers.d.ts.map        
[npmPack] npm notice 310B    esm/models/operationsMappers.js.map          
[npmPack] npm notice 639B    esm/models/parameters.d.ts.map               
[npmPack] npm notice 2.0kB   esm/models/parameters.js.map                 
[npmPack] npm notice 3.7kB   esm/operations/privateClouds.d.ts.map        
[npmPack] npm notice 6.6kB   esm/operations/privateClouds.js.map          
[npmPack] npm notice 390B    esm/models/privateCloudsMappers.d.ts.map     
[npmPack] npm notice 403B    esm/models/privateCloudsMappers.js.map       
[npmPack] npm notice 3.0kB   README.md                                    
[npmPack] npm notice 7.1kB   esm/operations/authorizations.d.ts           
[npmPack] npm notice 13.1kB  src/operations/authorizations.ts             
[npmPack] npm notice 361B    esm/models/authorizationsMappers.d.ts        
[npmPack] npm notice 657B    src/models/authorizationsMappers.ts          
[npmPack] npm notice 1.1kB   esm/avsClient.d.ts                           
[npmPack] npm notice 1.8kB   src/avsClient.ts                             
[npmPack] npm notice 754B    esm/avsClientContext.d.ts                    
[npmPack] npm notice 2.3kB   src/avsClientContext.ts                      
[npmPack] npm notice 7.6kB   esm/operations/clusters.d.ts                 
[npmPack] npm notice 14.3kB  src/operations/clusters.ts                   
[npmPack] npm notice 352B    esm/models/clustersMappers.d.ts              
[npmPack] npm notice 656B    src/models/clustersMappers.ts                
[npmPack] npm notice 7.8kB   esm/operations/hcxEnterpriseSites.d.ts       
[npmPack] npm notice 13.9kB  src/operations/hcxEnterpriseSites.ts         
[npmPack] npm notice 357B    esm/models/hcxEnterpriseSitesMappers.d.ts    
[npmPack] npm notice 649B    src/models/hcxEnterpriseSitesMappers.ts      
[npmPack] npm notice 35.6kB  esm/models/index.d.ts                        
[npmPack] npm notice 227B    esm/operations/index.d.ts                    
[npmPack] npm notice 33.9kB  src/models/index.ts                          
[npmPack] npm notice 511B    src/operations/index.ts                      
[npmPack] npm notice 2.1kB   esm/operations/locations.d.ts                
[npmPack] npm notice 4.5kB   src/operations/locations.ts                  
[npmPack] npm notice 144B    esm/models/locationsMappers.d.ts             
[npmPack] npm notice 421B    src/models/locationsMappers.ts               
[npmPack] npm notice 2.1kB   esm/models/mappers.d.ts

openapi-sdkautomation · 2020-10-21T22:30:36Z

azure-resource-manager-schemas - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from bbaa684 with merge commit 600bae4. Schema Automation 13.0.17.20200918.2

[vmware][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
[vmware][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
[vmware][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend

️✔️vmware [View full logs] [Release Schema Changes]

[after_scripts|node] PostProcessor finished successfully.
[after_scripts|node]   5790 passing (1m)
AzureResourceSchema has no registered package commands.
Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 27 Oct 2020 02:12:04 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0440:5082:624D58:EA8F3C:5F9781F4","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

openapi-pipeline-app · 2020-10-21T22:36:51Z

[Staging] Swagger Validation Report

️❌BreakingChange: 11 Errors, 0 Warnings [Detail] [Expand]

Only 10 items are listed, please refer to log for more details.

Rule	Message
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.AVS/stable/2020-03-20/vmware.json#L1213:9 Old: Microsoft.AVS/stable/2020-03-20/vmware.json#L1213:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.AVS/stable/2020-03-20/vmware.json#L1875:9 Old: Microsoft.AVS/stable/2020-03-20/vmware.json#L1722:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.AVS/stable/2020-03-20/vmware.json#L1853:9 Old: Microsoft.AVS/stable/2020-03-20/vmware.json#L1705:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.AVS/stable/2020-03-20/vmware.json#L1228:11 Old: Microsoft.AVS/stable/2020-03-20/vmware.json#L1227:11
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.AVS/stable/2020-03-20/vmware.json#L1213:9 Old: Microsoft.AVS/stable/2020-03-20/vmware.json#L1213:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.AVS/stable/2020-03-20/vmware.json#L1228:11 Old: Microsoft.AVS/stable/2020-03-20/vmware.json#L1227:11
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.AVS/stable/2020-03-20/vmware.json#L1875:9 Old: Microsoft.AVS/stable/2020-03-20/vmware.json#L1722:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.AVS/stable/2020-03-20/vmware.json#L1853:9 Old: Microsoft.AVS/stable/2020-03-20/vmware.json#L1705:9
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'isDataAction' in response that was not found in the old version. New: Microsoft.AVS/stable/2020-03-20/vmware.json#L1327:7 Old: Microsoft.AVS/stable/2020-03-20/vmware.json#L1325:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'properties' in response that was not found in the old version. New: Microsoft.AVS/stable/2020-03-20/vmware.json#L1327:7 Old: Microsoft.AVS/stable/2020-03-20/vmware.json#L1325:7

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

️️✔️ModelValidation [Detail]

 Validation passes for ModelValidation.

️️✔️SemanticValidation [Detail]

 Validation passes for SemanticValidation.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-10-21T22:37:04Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-10-21T22:38:33Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

ctaggart · 2020-10-21T22:50:20Z

The 11 errors listed as "breaking changes" fall into two categories:

1041 - AddedPropertyInResponse
These are all for Operations_List, to match what is actually returned.
1023 - TypeFormatChanged
The lint errors say that a format is required for integer. It was unspecified. They are all int32. I can roll back afa0274 if needed.

specification/vmware/resource-manager/Microsoft.AVS/stable/2020-03-20/vmware.json

…turn" This reverts commit a2fe16d.

…tials return"" This reverts commit 214ed73.

azure-pipelines · 2020-10-21T23:39:13Z

Azure Pipelines successfully started running 1 pipeline(s).

This reverts commit 31b80bb.

azure-pipelines · 2020-10-22T14:29:19Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-workflow-bot · 2020-10-22T16:15:35Z

Hi, @ctaggart Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

ctaggart · 2020-10-22T20:15:59Z

This is considered an urgent issue, so I created an ICM to get this reviewed:
https://portal.microsofticm.com/imp/v3/incidents/details/210561485/home

openapi-workflow-bot · 2020-10-23T03:41:47Z

Hi @ctaggart, one or multiple breaking change(s) is detected in your PR. Pls follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.

ctaggart · 2020-10-23T17:22:08Z

@ruowan, there is a one single sdk breaking change reported by the pthon sdk check. It is saying:

Operation ClustersOperations.create_or_update has a new signature

No other SDK has a breaking change. A stable version of the python SDK has not yet been published, so I do not think this is a blocking issue. If you look at https://pypi.org/project/azure-mgmt-avs/#history, you will see two versions:

1.0.0rc1 on July 14 for the 2020-03-20 API
0.1.0 on June 19 for the 2019-08-09 API

The az-vmware-cli uses autorest with --use=@microsoft.azure/autorest.python@3.0.62 and there are no breaking changes. The breaking changes check is using --use=@microsoft.azure/autorest.python@~4.0.71. I'm not sure what version of autorust.python, the 1.0.0rc1 used.

I will ask for a stable 1.0.0 of azure-mgmt-avs after this is merged.

ctaggart · 2020-10-23T18:58:59Z

I created this breaking change review: https://msazure.visualstudio.com/One/_workitems/edit/8653604

ruowan · 2020-10-26T05:48:30Z

@changlong-liu Could you pls help to review this Python Breaking Change?

changlong-liu · 2020-10-26T05:56:49Z

Hi @ruowan @ctaggart , I added comments in the github issue: Azure/azure-sdk-for-python#14735

Hi @ctaggart ,
for breaking change about create_or_update:
It related to the "Cluster" model definition changes in your PR. Originally there are only two properties in it is not readonly, (sku and clusterSize); currently there more properties become to non-readonly. This make the cluster parameter in create_or_update can be flattened in Python.

ctaggart · 2020-10-26T16:36:27Z

@changlong-liu those breaking changes are occurring when you run autorest against the current specification: https://github.com/ctaggart/azure-sdk-for-python/pull/1/files#diff-4db79dc989d60426c9b0788a2502c7c7c85acd73e15617a48794ca0691337080R179

There are no breaking changes caused by these spec changes in the Python SDK: ctaggart/azure-sdk-for-python#2

ctaggart · 2020-10-26T18:45:13Z

@ruowan, the breaking changes review was approved. Please merge this. I'll request new SDK versions after it is merged and KPIs show they are fixed.

* fix OBJECT_ADDITIONAL_PROPERTIES identified in operation "Operations_List" * remove x-ms-secret from PrivateClouds_ListAdminCredentials return * specify int32 for integers * add provisioningState to ManagementCluster * suppress warnings * prettier * Revert "remove x-ms-secret from PrivateClouds_ListAdminCredentials return" This reverts commit a2fe16d. * try suppressing SECRET_PROPERTY error * Revert "try suppressing SECRET_PROPERTY error" This reverts commit d3a567f. * Revert "Revert "remove x-ms-secret from PrivateClouds_ListAdminCredentials return"" This reverts commit 214ed73. * put back x-ms-secret from PrivateClouds_ListAdminCredentials return This reverts commit 31b80bb. * suppress SECRET_PROPERTY error

cataggar added 5 commits October 21, 2020 15:27

fix OBJECT_ADDITIONAL_PROPERTIES identified in operation "Operations_…

a97e492

…List"

remove x-ms-secret from PrivateClouds_ListAdminCredentials return

a2fe16d

specify int32 for integers

afa0274

add provisioningState to ManagementCluster

9f088fe

suppress warnings

4a4ae71

openapi-assignment-bot bot assigned ruowan Oct 21, 2020

This was referenced Oct 21, 2020

[AutoPR @azure/arm-avs] fix correctness errors for AVS 2020-03-20 API AzureSDKAutomation/azure-sdk-for-js#2240

Closed

[AutoPR azure-mgmt-avs] fix correctness errors for AVS 2020-03-20 API AzureSDKAutomation/azure-sdk-for-python#2527

Closed

openapi-sdkautomation bot added the CI-BreakingChange-Python label Oct 21, 2020

prettier

7dc9e4f

openapi-sdkautomation bot mentioned this pull request Oct 21, 2020

[AutoPR vmware] fix correctness errors for AVS 2020-03-20 API AzureSDKAutomation/azure-resource-manager-schemas#601

Closed

ctaggart commented Oct 21, 2020

View reviewed changes

specification/vmware/resource-manager/Microsoft.AVS/stable/2020-03-20/vmware.json Outdated Show resolved Hide resolved

cataggar added 2 commits October 21, 2020 17:12

Revert "remove x-ms-secret from PrivateClouds_ListAdminCredentials re…

214ed73

…turn" This reverts commit a2fe16d.

try suppressing SECRET_PROPERTY error

d3a567f

Revert "Revert "remove x-ms-secret from PrivateClouds_ListAdminCreden…

31b80bb

…tials return"" This reverts commit 214ed73.

cataggar added 2 commits October 22, 2020 08:11

put back x-ms-secret from PrivateClouds_ListAdminCredentials return

7147cb5

This reverts commit 31b80bb.

suppress SECRET_PROPERTY error

bbaa684

pilor self-requested a review October 22, 2020 21:56

pilor added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Oct 22, 2020

ruowan approved these changes Oct 23, 2020

View reviewed changes

ruowan added the BreakingChangeReviewRequired label Oct 23, 2020

ruowan self-requested a review October 23, 2020 03:42

ctaggart mentioned this pull request Oct 23, 2020

changes with correctness fix ctaggart/az-vmware-cli#1

Draft

ctaggart mentioned this pull request Oct 23, 2020

breaking change for azure-mgmt-avs? Azure/azure-sdk-for-python#14735

Closed

ctaggart mentioned this pull request Oct 26, 2020

autorest with correctness fixes ctaggart/azure-sdk-for-python#2

Draft

ctaggart mentioned this pull request Oct 26, 2020

AVS breaking change test #11385

Closed

ctaggart mentioned this pull request Oct 26, 2020

AVS 1.0.0 SDK for 2020-03-20 API Azure/azure-sdk-for-net#12983

Merged

ruowan added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Oct 27, 2020

ruowan merged commit 600bae4 into Azure:master Oct 27, 2020

ctaggart deleted the correctness branch October 27, 2020 02:39

This was referenced Oct 29, 2020

Refactor spec file ctaggart/autorust#75

Merged

fix correctness errors for AVS 2019-08-09-preview API #11545

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix correctness errors for AVS 2020-03-20 API #11317

fix correctness errors for AVS 2020-03-20 API #11317

ctaggart commented Oct 21, 2020 •

edited

Loading

azure-pipelines bot commented Oct 21, 2020

openapi-sdkautomation bot commented Oct 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 21, 2020 •

edited

Loading

openapi-pipeline-app bot commented Oct 21, 2020 •

edited

Loading

azure-pipelines bot commented Oct 21, 2020

openapi-sdkautomation bot commented Oct 21, 2020 •

edited

Loading

ctaggart commented Oct 21, 2020 •

edited

Loading

azure-pipelines bot commented Oct 21, 2020

azure-pipelines bot commented Oct 22, 2020

openapi-workflow-bot bot commented Oct 22, 2020

ctaggart commented Oct 22, 2020

openapi-workflow-bot bot commented Oct 23, 2020

ctaggart commented Oct 23, 2020 •

edited

Loading

ctaggart commented Oct 23, 2020

ruowan commented Oct 26, 2020

changlong-liu commented Oct 26, 2020

ctaggart commented Oct 26, 2020

ctaggart commented Oct 26, 2020 •

edited

Loading

fix correctness errors for AVS 2020-03-20 API #11317

fix correctness errors for AVS 2020-03-20 API #11317

Conversation

ctaggart commented Oct 21, 2020 • edited Loading

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

azure-pipelines bot commented Oct 21, 2020

openapi-sdkautomation bot commented Oct 21, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Oct 21, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Oct 21, 2020 • edited Loading

Trenton Generation - Release

openapi-sdkautomation bot commented Oct 21, 2020 • edited Loading

azure-sdk-for-python - Release

- Breaking Change detected in SDK

openapi-sdkautomation bot commented Oct 21, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Oct 21, 2020 • edited Loading

Azure CLI Extension Generation - Release

openapi-sdkautomation bot commented Oct 21, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Oct 21, 2020 • edited Loading

azure-resource-manager-schemas - Release

openapi-pipeline-app bot commented Oct 21, 2020 • edited Loading

[Staging] Swagger Validation Report

azure-pipelines bot commented Oct 21, 2020

openapi-sdkautomation bot commented Oct 21, 2020 • edited Loading

azure-sdk-for-python-track2 - Release

ctaggart commented Oct 21, 2020 • edited Loading

azure-pipelines bot commented Oct 21, 2020

azure-pipelines bot commented Oct 22, 2020

openapi-workflow-bot bot commented Oct 22, 2020

ctaggart commented Oct 22, 2020

openapi-workflow-bot bot commented Oct 23, 2020

ctaggart commented Oct 23, 2020 • edited Loading

ctaggart commented Oct 23, 2020

ruowan commented Oct 26, 2020

changlong-liu commented Oct 26, 2020

ctaggart commented Oct 26, 2020

ctaggart commented Oct 26, 2020 • edited Loading

ctaggart commented Oct 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 21, 2020 •

edited

Loading

openapi-pipeline-app bot commented Oct 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 21, 2020 •

edited

Loading

ctaggart commented Oct 21, 2020 •

edited

Loading

ctaggart commented Oct 23, 2020 •

edited

Loading

ctaggart commented Oct 26, 2020 •

edited

Loading