AVS 1.0.0 SDK for 2020-03-20 API #12983
Conversation
|
I'm headed out on leave for 12 weeks. @leedouglas will be creating a new pull request to replace this one. |
|
Hello, I'm back from medical leave and need to get this .NET SDK published for AVS, since the service is already GA. autorest ../azure-rest-api-specs/specification/vmware/resource-manager/readme.md --csharp --version=v2 --azure-arm=true --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=$PWD\sdk --reflect-api-versionsUsing the latest commit from Azure/azure-rest-api-specs#11317. I'm expecting it to be merged very soon. My goal in the next couple of days is to add all the tests. |
ctaggart
requested review from
allenjzhang,
bquantump,
m-nash,
markcowl,
nisha-bhatia and
YalinLi0312
as code owners
|
Hi @markcowl, the additional tests have been added and this is ready for review. |
sdk/avs/Microsoft.Azure.Management.Avs/src/Microsoft.Azure.Management.Avs.csproj
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
One change, and Missing a few things,
- The generation scripts creates a metadata file in th /eng/mgmt/... folder, please include it
- Please include a link to the swagger PR associated with thsi change in the PR description or comments
- You must add an api version tag for any new api-version in the Az.RP.Sdk.props file for this
sdk/avs/Microsoft.Azure.Management.Avs/src/Microsoft.Azure.Management.Avs.csproj
Show resolved
Hide resolved
|
@markcowl, thanks for the review. I made the updates. CI is passing, except for some unrelated issue with the CI infrastructure for MacOS testing. |
| @@ -6,7 +6,7 @@ | |||
| <PropertyGroup> | |||
| <PackageId>Microsoft.Azure.Management.Avs</PackageId> | |||
| <Description>Provides developers with libraries for Azure VMware Solution.</Description> | |||
| <Version>1.0.0-preview.1</Version> | |||
| <Version>1.0.0</Version> | |||
There was a problem hiding this comment.
You will need to make a change to at least the AssemblyFileVersion in AssemblyInfo.cs - the file version needs to be monotonically increasing, or some kinds of installation processes (like msis) will not recognize that this assembly is different from the preview.
There was a problem hiding this comment.
I set AssemblyFileVersion in 8835f83.
| @@ -0,0 +1,8 @@ | |||
| // Copyright (c) Microsoft Corporation. All rights reserved. | |||
There was a problem hiding this comment.
I didn't realize this didn't have an assembly info. It should have all the appropriate properties in here. Here is a sample: https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/compute/Microsoft.Azure.Management.Compute/src/Properties/AssemblyInfo.cs
Assembly Version should be 1.0.0, Metadata should match this assembly name.
There was a problem hiding this comment.
I added the additional assembly info metadata as requested in 19b8c13. I set the AssemblyVersion to 1.0.0 as well.
|
It has been published: |
* update to AVS 2020-03-20 stable API * generated from commit bbaa6841ceeafc5027b5b2d1f04875a4a22b80be * lots more tests * move to 1.0.0 * ran src/generate.ps1 * set AzureApiTag to AVS_2020-03-20 * add AssemblyFileVersion * add other AssemblyInfo metadata
AVS 1.0.0-preview.1 was #12602. This will be 1.0.0 and it updates to the 2020-03-20 stable API:
https://github.com/Azure/azure-rest-api-specs/blob/master/specification/vmware/resource-manager/Microsoft.AVS/stable/2020-03-20/vmware.json