Add "mail" parameter to UserUpdateParameters in graphrbac

[dcepelik]

This patch adds a single optional field "mail" to UserUpdateParameters schema. This makes it possible to update user's e-mail address using the (Go) Azure SDK. Currently this is not possible.

I have curled the graphrbac API with the extra body parameter and it works as expected. It seems that this field was omitted from the OpenAPI spec by accident rather than on purpose, since the field is available in the UserCreateParameters (so not including it in UserUpdateParameters creates a strange asymmetry where I can configure a user's e-mail address, but cannot change it later on).

The curl proving that the field is in fact respected by the UserUpdate endpoint is

curl \
    -i \
    -X PATCH \
    -H "Authorization: Bearer <token>" \
    -H "Content-Type: application/json" \
    -d '{"mail": "foo@bar.com"}' \
    "https://graph.windows.net/<tenantID>/users/<objectID>?api-version=1.6"

Addition of the field will make it possible to support the mail property on the azuread_user resource in terraform-provider-azuread. Currently it's not possible to configure e-mail addresses for users onboarded via Terraform.

Sorry for not sticking with the original pull request checklist, it seemed to me that it applies to Microsoft employees only.

[openapi-pipeline-app]

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

• Compared Swaggers (Based on Oad v0.8.1)
  • original: stable/1.6/graphrbac.json <---> new: stable/1.6/graphrbac.json

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

• Linted configuring files (Based on source branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
  • graphrbac/data-plane/readme.md tag:1.6
• Linted configuring files (Based on target branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
  • graphrbac/data-plane/readme.md tag:1.6

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

_{Posted by Swagger Pipeline | How to fix these errors?}

[openapi-pipeline-app]

Swagger Generation Artifacts

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

• ️✔️Succeeded [Logs]Release - Generate from e91876b. SDK Automation 14.0.0

  warn	Skip initScript due to not configured
  command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/graphrbac/data-plane/readme.md

• ️✔️@azure/graph [View full logs]  [Release SDK Changes]
  • azure-graph-5.0.1.tgz

  cmderr	[npmPack] node-resolve: setting options.module is deprecated, please override options.mainFields instead
  cmderr	[npmPack] ./esm/graphRbacManagementClient.js → ./dist/graph.js...
  cmderr	[npmPack] created ./dist/graph.js in 328ms

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

• ️✔️Succeeded [Logs]Release - Generate from e91876b. SDK Automation 14.0.0

  command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
  command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

• ️✔️graphrbac/1.6/graphrbac [View full logs]  [Release SDK Changes]

  info	[Changelog] ### New Constants
  info	[Changelog]
  info	[Changelog] 1. ObjectType.ObjectTypeAppRoleAssignment
  info	[Changelog]
  info	[Changelog] ### New Funcs
  info	[Changelog]
  info	[Changelog] 1. *AppRoleAssignment.UnmarshalJSON([]byte) error
  info	[Changelog] 1. *AppRoleAssignmentListResultIterator.Next() error
  info	[Changelog] 1. *AppRoleAssignmentListResultIterator.NextWithContext(context.Context) error
  info	[Changelog] 1. *AppRoleAssignmentListResultPage.Next() error
  info	[Changelog] 1. *AppRoleAssignmentListResultPage.NextWithContext(context.Context) error
  info	[Changelog] 1. ADGroup.AsAppRoleAssignment() (*AppRoleAssignment, bool)
  info	[Changelog] 1. AppRoleAssignment.AsADGroup() (*ADGroup, bool)
  info	[Changelog] 1. AppRoleAssignment.AsAppRoleAssignment() (*AppRoleAssignment, bool)
  info	[Changelog] 1. AppRoleAssignment.AsApplication() (*Application, bool)
  info	[Changelog] 1. AppRoleAssignment.AsBasicDirectoryObject() (BasicDirectoryObject, bool)
  info	[Changelog] 1. AppRoleAssignment.AsDirectoryObject() (*DirectoryObject, bool)
  info	[Changelog] 1. AppRoleAssignment.AsServicePrincipal() (*ServicePrincipal, bool)
  info	[Changelog] 1. AppRoleAssignment.AsUser() (*User, bool)
  info	[Changelog] 1. AppRoleAssignment.MarshalJSON() ([]byte, error)
  info	[Changelog] 1. AppRoleAssignmentListResult.IsEmpty() bool
  info	[Changelog] 1. AppRoleAssignmentListResultIterator.NotDone() bool
  info	[Changelog] 1. AppRoleAssignmentListResultIterator.Response() AppRoleAssignmentListResult
  info	[Changelog] 1. AppRoleAssignmentListResultIterator.Value() AppRoleAssignment
  info	[Changelog] 1. AppRoleAssignmentListResultPage.NotDone() bool
  info	[Changelog] 1. AppRoleAssignmentListResultPage.Response() AppRoleAssignmentListResult
  info	[Changelog] 1. AppRoleAssignmentListResultPage.Values() []AppRoleAssignment
  info	[Changelog] 1. Application.AsAppRoleAssignment() (*AppRoleAssignment, bool)
  info	[Changelog] 1. DirectoryObject.AsAppRoleAssignment() (*AppRoleAssignment, bool)
  info	[Changelog] 1. NewAppRoleAssignmentListResultIterator(AppRoleAssignmentListResultPage) AppRoleAssignmentListResultIterator
  info	[Changelog] 1. NewAppRoleAssignmentListResultPage(AppRoleAssignmentListResult, func(context.Context, AppRoleAssignmentListResult) (AppRoleAssignmentListResult, error)) AppRoleAssignmentListResultPage
  info	[Changelog] 1. ServicePrincipal.AsAppRoleAssignment() (*AppRoleAssignment, bool)
  info	[Changelog] 1. ServicePrincipalsClient.AddOwner(context.Context, string, AddOwnerParameters) (autorest.Response, error)
  info	[Changelog] 1. ServicePrincipalsClient.AddOwnerPreparer(context.Context, string, AddOwnerParameters) (*http.Request, error)
  info	[Changelog] 1. ServicePrincipalsClient.AddOwnerResponder(*http.Response) (autorest.Response, error)
  info	[Changelog] 1. ServicePrincipalsClient.AddOwnerSender(*http.Request) (*http.Response, error)
  info	[Changelog] 1. ServicePrincipalsClient.ListAppRoleAssignedTo(context.Context, string) (AppRoleAssignmentListResultPage, error)
  info	[Changelog] 1. ServicePrincipalsClient.ListAppRoleAssignedToComplete(context.Context, string) (AppRoleAssignmentListResultIterator, error)
  info	[Changelog] 1. ServicePrincipalsClient.ListAppRoleAssignedToPreparer(context.Context, string) (*http.Request, error)
  info	[Changelog] 1. ServicePrincipalsClient.ListAppRoleAssignedToResponder(*http.Response) (AppRoleAssignmentListResult, error)
  info	[Changelog] 1. ServicePrincipalsClient.ListAppRoleAssignedToSender(*http.Request) (*http.Response, error)
  info	[Changelog] 1. ServicePrincipalsClient.ListAppRoleAssignments(context.Context, string) (AppRoleAssignmentListResultPage, error)
  info	[Changelog] 1. ServicePrincipalsClient.ListAppRoleAssignmentsComplete(context.Context, string) (AppRoleAssignmentListResultIterator, error)
  info	[Changelog] 1. ServicePrincipalsClient.ListAppRoleAssignmentsPreparer(context.Context, string) (*http.Request, error)
  info	[Changelog] 1. ServicePrincipalsClient.ListAppRoleAssignmentsResponder(*http.Response) (AppRoleAssignmentListResult, error)
  info	[Changelog] 1. ServicePrincipalsClient.ListAppRoleAssignmentsSender(*http.Request) (*http.Response, error)
  info	[Changelog] 1. ServicePrincipalsClient.RemoveOwner(context.Context, string, string) (autorest.Response, error)
  info	[Changelog] 1. ServicePrincipalsClient.RemoveOwnerPreparer(context.Context, string, string) (*http.Request, error)
  info	[Changelog] 1. ServicePrincipalsClient.RemoveOwnerResponder(*http.Response) (autorest.Response, error)
  info	[Changelog] 1. ServicePrincipalsClient.RemoveOwnerSender(*http.Request) (*http.Response, error)
  info	[Changelog] 1. User.AsAppRoleAssignment() (*AppRoleAssignment, bool)
  info	[Changelog]
  info	[Changelog] ## Struct Changes
  info	[Changelog]
  info	[Changelog] ### New Structs
  info	[Changelog]
  info	[Changelog] 1. AppRoleAssignment
  info	[Changelog] 1. AppRoleAssignmentListResult
  info	[Changelog] 1. AppRoleAssignmentListResultIterator
  info	[Changelog] 1. AppRoleAssignmentListResultPage
  info	[Changelog]
  info	[Changelog] ### New Struct Fields
  info	[Changelog]
  info	[Changelog] 1. UserUpdateParameters.Mail
  info	[Changelog]

️⚠️ azure-sdk-for-java warning [Detail]

• ⚠️Warning [Logs]Release - Generate from e91876b. SDK Automation 14.0.0

  command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
  command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  cmderr	[generate.py] 2020-12-30 19:31:11 ERROR [Skip] readme path does not format as specification/*/resource-manager/readme.md
  warn	No file changes detected after generation
  warn	No package detected after generation

️️✔️ azure-sdk-for-python succeeded [Detail] [Expand]

• ️✔️Succeeded [Logs]Release - Generate from e91876b. SDK Automation 14.0.0

  warn	Skip initScript due to not configured
  command	npx n 12
  command	python3 -m venv venv
  command	pip install --upgrade setuptools wheel pip
  command	pip install pathlib jinja2 msrestazure
  command	autorest --version=V2 --use=@microsoft.azure/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/graphrbac/data-plane/readme.md

• ️✔️azure-graphrbac [View full logs]  [Release SDK Changes] Breaking Change Detected
  • azure-graphrbac-0.61.1.zip
  • azure_graphrbac-0.61.1-py2.py3-none-any.whl

  cmderr	[buildConf] INFO:packaging_tools:Building template azure-graphrbac
  cmderr	[buildConf] INFO:packaging_tools.conf:Skipping default conf since the file exists
  cmderr	[buildConf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
  cmderr	[buildConf] INFO:packaging_tools:Template done azure-graphrbac
  cmderr	[changelogSetup] WARNING: Skipping azure-nspkg as it is not installed.
  cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.graphrbac
  cmderr	[changelogReport] INFO:__main__:Found azure.graphrbac
  cmderr	[changelogReport] INFO:__main__:Working on azure.graphrbac
  cmderr	[changelogReport] INFO:__main__:Report written to sdk/graphrbac/azure-graphrbac/code_reports/latest/report.json
  cmderr	[changelogReportLatest] INFO:__main__:Download versions of azure-graphrbac on PyPI
  cmderr	[changelogReportLatest] INFO:__main__:Got ['0.30.0a1', '0.30.0rc1', '0.30.0rc2', '0.30.0rc3', '0.30.0rc4', '0.30.0rc5', '0.30.0rc6', '0.30.0', '0.31.0', '0.32.0', '0.33.0', '0.40.0', '0.50.0', '0.51.0', '0.51.1', '0.52.0', '0.53.0', '0.60.0', '0.61.0', '0.61.1']
  cmderr	[changelogReportLatest] INFO:__main__:Only keep last PyPI version
  cmderr	[changelogReportLatest] INFO:__main__:Installing version 0.61.1 of azure-graphrbac in a venv
  cmderr	[changelogReportLatest] Cache entry deserialization failed, entry ignored
  cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.graphrbac
  cmderr	[changelogReportLatest] INFO:__main__:Found azure.graphrbac
  cmderr	[changelogReportLatest] INFO:__main__:Working on azure.graphrbac
  cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/graphrbac/azure-graphrbac/code_reports/0.61.1/report.json
  cmdout	[Changelog] Size of delta 6.134% size of original (original: 53488 chars, delta: 3281 chars)
  cmdout	[Changelog] **Features**
  cmdout	[Changelog]   - Model UserUpdateParameters has a new parameter mail
  cmdout	[Changelog]   - Added operation ServicePrincipalsOperations.list_app_role_assignments
  cmdout	[Changelog]   - Added operation ServicePrincipalsOperations.list_app_role_assigned_to
  cmdout	[Changelog]   - Added operation ServicePrincipalsOperations.add_owner
  cmdout	[Changelog]   - Added operation ServicePrincipalsOperations.remove_owner
  cmdout	[Changelog] **Breaking changes**
  cmdout	[Changelog]   - Operation UsersOperations.list has a new signature
  warn	Breaking change found in changelog

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account. 

_{Posted by Swagger Pipeline | How to fix these errors?}

[ghost]

Thank you for your contribution dcepelik! We will review the pull request and get back to you soon.

[ghostinushanka]

Hello @lmazuel
I see that the pull request been accepted and merged, but the resulting state confuses me, as I cannot find the actual changes in the latest versions of the SDK.
It seems that (in the example of GO SDK) the #13208 did contain the code changes to the SDK for the mail parameter, but the #13960, listed after the acceptance, actually does not have those changes.

Could you please clarify whether it is meant to land into the SDK in the end?