-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
user: support the mail
property
#374
user: support the mail
property
#374
Conversation
this change explicitly depends on acceptance of Azure/azure-rest-api-specs#12127
Hi @ghostinushanka, thanks for this suggestion. Unfortunately the Regrettably this will not work and we won't be able to merge this. Since we have a lot of work in progress to migrate to the newer MS Graph API - where setting this field might be more feasible - I'm going to close this. Thanks again for submitting. |
Hello @manicminer, you have me at a loss here. I do know that the SDK currently supports the create-only, that is why I have referred the pull request of the colleague of mine, where we have added support for the update operation as well. You mention that the field is supported by the "Office 365 tenants" and in the #280 you mention "O365 license" - that is the confusing part for me. |
Sorry for the confusion from my choice of phrasing. I was referring to the Azure AD SKUs as per https://azure.microsoft.com/en-us/pricing/details/active-directory/ I've dug up an old branch where I was testing setting the I'm happy to reopen this, on the basis that we could look to merge it when/if the upstream PR is merged and released. For some additional context, there's ongoing work to move away from the Azure AD Graph API to the Microsoft Graph API. Generally speaking, we're not looking to merge in new features unless they translate well during the API migration - this would qualify if the swagger/SDK can be fixed up. |
mail
property
Hi @ghostinushanka, it looks like the swagger change was merged but hasn't made it into the SDK as yet. As AzureAD v1.5.0 has now been released with initial Microsoft Graph support, features using the Azure SDK are now frozen. Whilst you cannot currently update the It's unfortunate the SDK change didn't make it sooner, but as we will no longer be using the Azure SDK going forward I'm going to close this PR. You can expect to see this fixed in v2.0 using the new API. Thanks again for the effort :) |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
With this Terraform operators will be able to also set/modify the primary email address for the users.
Change explicitly depends on acceptance of Azure/azure-rest-api-specs#12127 which will make the Mail field available for updates.