-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch update 2021 01 01.13.0 - Resource Manager only #12393
Conversation
Hi, @paterasMSFT Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
Rule | Message |
---|---|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: autoUpgradeMinorVersion New: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L4121 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️
[Staging] Cross Version BreakingChange (Base on stable version): 2 Warnings warning [Detail]
- Compared Swaggers (Based on Oad v0.8.5)
- original: stable/2020-09-01/BatchManagement.json <---> new: stable/2021-01-01/BatchManagement.json
Rule | Message |
---|---|
The new version removs a required header 'Location'. New: azure-rest-api-specs/blob/c2e530b75bd3fecc82623ad2d9fdd0fab05a9184/ Old: Microsoft.Batch/stable/2020-09-01/BatchManagement.json#L1745:15 |
|
The new version removs a required header 'Retry-After'. New: azure-rest-api-specs/blob/c2e530b75bd3fecc82623ad2d9fdd0fab05a9184/ Old: Microsoft.Batch/stable/2020-09-01/BatchManagement.json#L1749:15 |
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
Swagger Generation Artifacts
|
Hi @paterasMSFT, Your PR has some issues. Please fix the CI sequentially by following the order of
|
6eadae9
to
330c9f3
Compare
Hi, @paterasMSFT your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @anuchandy |
96bf921
to
e2c7774
Compare
specification/batch/data-plane/Microsoft.Batch/stable/2021-01-01.13.0/BatchService.json
Outdated
Show resolved
Hide resolved
specification/batch/data-plane/Microsoft.Batch/stable/2021-01-01.13.0/BatchService.json
Outdated
Show resolved
Hide resolved
specification/batch/data-plane/Microsoft.Batch/stable/2021-01-01.13.0/BatchService.json
Outdated
Show resolved
Hide resolved
specification/batch/data-plane/Microsoft.Batch/stable/2021-01-01.13.0/BatchService.json
Outdated
Show resolved
Hide resolved
specification/batch/data-plane/Microsoft.Batch/stable/2021-01-01.13.0/BatchService.json
Outdated
Show resolved
Hide resolved
specification/batch/data-plane/Microsoft.Batch/stable/2021-01-01.13.0/BatchService.json
Outdated
Show resolved
Hide resolved
specification/batch/resource-manager/Microsoft.Batch/stable/2021-01-01/BatchManagement.json
Outdated
Show resolved
Hide resolved
specification/batch/resource-manager/Microsoft.Batch/stable/2021-01-01/BatchManagement.json
Outdated
Show resolved
Hide resolved
specification/batch/resource-manager/Microsoft.Batch/stable/2021-01-01/BatchManagement.json
Outdated
Show resolved
Hide resolved
93c51c4
to
bfe8020
Compare
specification/batch/resource-manager/Microsoft.Batch/stable/2021-01-01/BatchManagement.json
Outdated
Show resolved
Hide resolved
specification/batch/resource-manager/Microsoft.Batch/stable/2021-01-01/BatchManagement.json
Show resolved
Hide resolved
We decided to split the data-plane off into its own PR, so I have removed it from this one. |
For Python, the breaking change is caused by other PR, not this one. |
New features in this release are:
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.