Update batch dataplane for version 2021-01-01-13.0 - Data Plane #12426

paterasMSFT · 2021-01-13T23:54:10Z

New features in this release are:

Managed identity support for pools
Virtual machine extension support for nodes
Availability zone support for pools

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet. Service has already begun to roll out.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet. ASAP (delivery due 01-01-2021)
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-01-13T23:54:13Z

Hi, @paterasMSFT Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-01-13T23:54:14Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Linted configuring files (Based on source branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- batch/data-plane/readme.md tag:package-2021-01.13.0
Linted configuring files (Based on target branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- batch/data-plane/readme.md tag:default

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

Compared Swaggers (Based on Oad v0.8.6)
- original: stable/2020-09-01.12.0/BatchService.json <---> new: stable/2021-01-01.13.0/BatchService.json

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️[Staging] SDK Track2 Validation: 154 Warnings warning [Detail]

Only 10 items are listed, please refer to log for more details.

The following tags are being changed in this PR

batch/data-plane/readme.md#package-2021-01.13.0

Rule	Message
⚠️ PreCheck/SchemaMissingType	"readme":"batch/data-plane/readme.md", "tag":"package-2021-01.13.0", "details":"The schema 'PoolUsageMetrics' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"batch/data-plane/readme.md", "tag":"package-2021-01.13.0", "details":"The schema 'PoolListUsageMetricsResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"batch/data-plane/readme.md", "tag":"package-2021-01.13.0", "details":"The schema 'ImageInformation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"batch/data-plane/readme.md", "tag":"package-2021-01.13.0", "details":"The schema 'AuthenticationTokenSettings' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"batch/data-plane/readme.md", "tag":"package-2021-01.13.0", "details":"The schema 'AccountListSupportedImagesResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"batch/data-plane/readme.md", "tag":"package-2021-01.13.0", "details":"The schema 'UsageStatistics' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"batch/data-plane/readme.md", "tag":"package-2021-01.13.0", "details":"The schema 'ResourceStatistics' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"batch/data-plane/readme.md", "tag":"package-2021-01.13.0", "details":"The schema 'PoolStatistics' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"batch/data-plane/readme.md", "tag":"package-2021-01.13.0", "details":"The schema 'JobStatistics' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"batch/data-plane/readme.md", "tag":"package-2021-01.13.0", "details":"The schema 'NameValuePair' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-01-13T23:54:14Z

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 4e733eb36d56479d2ce7fa31f3943623cf2214f6. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️batch/2021-01-01.13.0/batch [View full logs] [Preview SDK Changes]
```
info	[Changelog] This is a new package
```
️✔️batch/2020-09-01.12.0/batch [View full logs] [Preview SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️batch/2020-03-01.11.0/batch [View full logs] [Preview SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️batch/2019-08-01.10.0/batch [View full logs] [Preview SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️batch/2019-06-01.9.0/batch [View full logs] [Preview SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️batch/2018-12-01.8.0/batch [View full logs] [Preview SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️batch/2018-08-01.7.0/batch [View full logs] [Preview SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️batch/2018-03-01.6.1/batch [View full logs] [Preview SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️batch/2017-05-01.5.0/batch [View full logs] [Preview SDK Changes]
```
info	[Changelog] No exported changes
```

️❌ azure-sdk-for-js failed [Detail]

❌Failed [Logs] Generate from 4e733eb36d56479d2ce7fa31f3943623cf2214f6. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/batch/data-plane/readme.md
cmdout	[Autorest] WARNING: HEAD 'getPropertiesFromTask' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getPropertiesFromComputeNode' method missing 404 status code section -- this might be unintentional.

❌@azure/batch [View full logs] [Preview SDK Changes]

error	Script return with result [failed] code [2] signal [null] cwd [azure-sdk-for-js/azure-sdk-for-js/sdk/batch/batch]: npm pack --silent

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-01-13T23:54:38Z

Hi, @paterasMSFT your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @tjprescott

dpwatrous · 2021-01-14T00:18:17Z

This PR was split off from #12393 (which contained both data and management planes previously). Added @anuchandy as the reviewer since he has already reviewed these changes in the other PR.

We're in a bit of a holding pattern here while we sort through an issue on the service side with VM extensions, so marked this as not ready for review. Will update when we have things sorted on our end.

akning-ms · 2021-01-20T03:22:07Z

/azp run

azure-pipelines · 2021-01-20T03:22:22Z

Azure Pipelines successfully started running 2 pipeline(s).

dpwatrous · 2021-01-21T20:08:29Z

Marked as DoNotMerge until the issue with virtual machine extensions is resolved on the service side. (Even though this likely won't affect the data plane swagger)

ghost · 2021-02-21T16:01:29Z

Hi, @paterasMSFT. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

ghost · 2021-03-22T03:01:37Z

Hi, @paterasMSFT. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee @anuchandy.

JackTn · 2022-06-16T03:01:22Z

Hi, @paterasMSFT. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

JackTn · 2022-06-16T03:12:01Z

Hi, @paterasMSFT. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

JackTn · 2022-06-16T03:25:43Z

Hi, @paterasMSFT. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

paterasMSFT requested review from lirenhe, matthchr and xingwu1 as code owners January 13, 2021 23:54

openapi-assignment-bot bot assigned tjprescott Jan 13, 2021

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 13, 2021

openapi-sdkautomation bot mentioned this pull request Jan 13, 2021

[AutoPR @azure/batch] Update batch dataplane for version 2021-01-01-13.0 - Data Plane AzureSDKAutomation/azure-sdk-for-js#3218

Draft

dpwatrous added NotReadyForReview <valid label in PR review process>It is in draft for swagger or not swagger PR and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 14, 2021

dpwatrous assigned anuchandy Jan 14, 2021

dpwatrous unassigned tjprescott Jan 14, 2021

paterasMSFT force-pushed the Batch-update-data-plane-2021-01-01.13.0 branch from 44a2c13 to 32ec4dd Compare January 14, 2021 17:17

paterasMSFT added 2 commits January 14, 2021 14:14

2020-09-01 baseline

acc1b9e

Update batch dataplane for version 2021-01-01-13.0

487da4b

paterasMSFT force-pushed the Batch-update-data-plane-2021-01-01.13.0 branch from 32ec4dd to 487da4b Compare January 14, 2021 19:21

dpwatrous added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jan 21, 2021

Added note about UTC times to job schedule description

b66dfa2

paterasMSFT requested a review from ArcturusZhang as a code owner January 28, 2021 20:22

Added a note about task retention and small VM sizes

417fbe0

ghost added the no-recent-activity label Feb 21, 2021

ghost closed this Mar 22, 2021

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update batch dataplane for version 2021-01-01-13.0 - Data Plane #12426

Update batch dataplane for version 2021-01-01-13.0 - Data Plane #12426

paterasMSFT commented Jan 13, 2021 •

edited

Loading

openapi-workflow-bot bot commented Jan 13, 2021

openapi-pipeline-app bot commented Jan 13, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 13, 2021 •

edited

Loading

openapi-workflow-bot bot commented Jan 13, 2021

dpwatrous commented Jan 14, 2021

akning-ms commented Jan 20, 2021

azure-pipelines bot commented Jan 20, 2021

dpwatrous commented Jan 21, 2021

ghost commented Feb 21, 2021

ghost commented Mar 22, 2021

JackTn commented Jun 16, 2022

JackTn commented Jun 16, 2022

JackTn commented Jun 16, 2022

Update batch dataplane for version 2021-01-01-13.0 - Data Plane #12426

Update batch dataplane for version 2021-01-01-13.0 - Data Plane #12426

Conversation

paterasMSFT commented Jan 13, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Jan 13, 2021

openapi-pipeline-app bot commented Jan 13, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jan 13, 2021 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Jan 13, 2021

dpwatrous commented Jan 14, 2021

akning-ms commented Jan 20, 2021

azure-pipelines bot commented Jan 20, 2021

dpwatrous commented Jan 21, 2021

ghost commented Feb 21, 2021

ghost commented Mar 22, 2021

JackTn commented Jun 16, 2022

JackTn commented Jun 16, 2022

JackTn commented Jun 16, 2022

paterasMSFT commented Jan 13, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 13, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 13, 2021 •

edited

Loading