Add 2021-03-01 API version with the GA version changes #13380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @dramuy Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: allowPartialScopes Location: Microsoft.ResourceGraph/stable/2021-03-01/resourcegraph.json#L224 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️[Staging] Cross Version BreakingChange (Base on preview version): 2 Warnings warning [Detail]
- Compared Swaggers (Based on Oad v0.8.7)
- original: preview/2020-04-01-preview/resourcegraph.json <---> new: stable/2021-03-01/resourcegraph.json
| Rule | Message |
|---|---|
| The new version has a different default value than the previous one. New: Microsoft.ResourceGraph/stable/2021-03-01/resourcegraph.json#L211:9 Old: Microsoft.ResourceGraph/preview/2020-04-01-preview/resourcegraph.json#L207:9 |
|
| The new version is missing a property found in the old version. Was 'managementGroupId' renamed or removed? New: Microsoft.ResourceGraph/stable/2021-03-01/resourcegraph.json#L154:7 Old: Microsoft.ResourceGraph/preview/2020-04-01-preview/resourcegraph.json#L154:7 |
️⚠️[Staging] Cross Version BreakingChange (Base on stable version): 2 Warnings warning [Detail]
- Compared Swaggers (Based on Oad v0.8.7)
- original: stable/2019-04-01/resourcegraph.json <---> new: stable/2021-03-01/resourcegraph.json
| Rule | Message |
|---|---|
| The new version adds a response code 'default'. New: Microsoft.ResourceGraph/stable/2021-03-01/resourcegraph.json#L137:11 |
|
| The new version has a different default value than the previous one. New: Microsoft.ResourceGraph/stable/2021-03-01/resourcegraph.json#L211:9 Old: Microsoft.ResourceGraph/stable/2019-04-01/resourcegraph.json#L198:9 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️[Staging] SDK Track2 Validation: 6 Warnings warning [Detail]
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
| "readme":"resourcegraph/resource-manager/readme.md", "tag":"package-2021-03", "details":"The schema 'QueryRequestOptions' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"resourcegraph/resource-manager/readme.md", "tag":"package-2021-03", "details":"The schema 'FacetRequestOptions' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"resourcegraph/resource-manager/readme.md", "tag":"package-2021-03", "details":"The schema 'OperationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"resourcegraph/resource-manager/readme.md", "tag":"package-2021-03", "details":"The schema 'Operation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"resourcegraph/resource-manager/readme.md", "tag":"package-2021-03", "details":"The schema 'Operation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"resourcegraph/resource-manager/readme.md", "tag":"package-2021-03", "details":"Checking for duplicate schemas, this could take a (long) while. Run with --verbose for more detail." |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
This was referenced Mar 11, 2021
sanjaiganesh
added
the
ARMSignedOff
fenwickt
reviewed
Mar 12, 2021
fenwickt
reviewed
Mar 12, 2021
.../resourcegraph/resource-manager/Microsoft.ResourceGraph/stable/2021-03-01/resourcegraph.json
Show resolved
Hide resolved
fenwickt
approved these changes
Mar 16, 2021
11 tasks
|
@qianwens could you please help review and merge this PR. |
This was referenced Mar 18, 2021
Merged
MirzaSikander
pushed a commit
to MirzaSikander/azure-rest-api-specs
that referenced
this pull request
Mar 22, 2021
* Add 2021-03-01 API version with the GA version changes * Addressing review feedback. * Address the prettier check errors and swagger tooling input files.
1 task
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
* Add 2021-03-01 API version with the GA version changes * Addressing review feedback. * Address the prettier check errors and swagger tooling input files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
This current PR is reviewed on the private repo already got sign off. https://github.com/Azure/azure-rest-api-specs-pr/pull/2967
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.