-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.ResourceGraph to add version preview/2021-06-01-preview #14765
[Hub Generated] Review request for Microsoft.ResourceGraph to add version preview/2021-06-01-preview #14765
Conversation
Hi, @johnthcall Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
Rule | Message |
---|---|
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.ResourceGraph/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.ResourceGraph/preview/2021-06-01-preview/resourcegraph.json#L113 |
R4037 - MissingTypeObject |
The schema 'QueryRequestOptions' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ResourceGraph/preview/2021-06-01-preview/resourcegraph.json#L191 |
R4037 - MissingTypeObject |
The schema 'FacetRequestOptions' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ResourceGraph/preview/2021-06-01-preview/resourcegraph.json#L263 |
R4037 - MissingTypeObject |
The schema 'OperationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ResourceGraph/preview/2021-06-01-preview/resourcegraph.json#L545 |
R4037 - MissingTypeObject |
The schema 'Operation' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ResourceGraph/preview/2021-06-01-preview/resourcegraph.json#L557 |
R4037 - MissingTypeObject |
The schema 'display' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ResourceGraph/preview/2021-06-01-preview/resourcegraph.json#L564 |
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: allowPartialScopes Location: Microsoft.ResourceGraph/preview/2021-06-01-preview/resourcegraph.json#L224 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌
Cross-Version Breaking Changes: 6 Errors, 0 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.8.11)
- current:preview/2021-06-01-preview/resourcegraph.json compared with base:preview/2020-04-01-preview/resourcegraph.json
- current:preview/2021-06-01-preview/resourceshistory.json compared with base:preview/2020-04-01-preview/resourceshistory.json
- current:preview/2021-06-01-preview/resourcegraph.json compared with base:stable/2021-03-01/resourcegraph.json
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️
[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
|:speech_balloon: AutorestCore/Exception|"readme":"resourcegraph/resource-manager/readme.md",
"tag":"package-preview-2021-06",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"resourcegraph/resource-manager/readme.md",
"tag":"package-preview-2021-06",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"resourcegraph/resource-manager/readme.md",
"tag":"package-preview-2021-06",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
️️✔️
[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@PhoenixHe-msft Is there anything you need from me on this PR?
|
@johnthcall ARM review is required for new api version |
Reviewed the version changes from ARM perspective. Marking ARMSignedOff. |
…sion preview/2021-06-01-preview (Azure#14765) * Adds base for updating Microsoft.ResourceGraph from version stable/2021-03-01 to version 2021-06-01-preview * Updates readme * Updates API version in new specs and examples * Add history and AuthorizationScopeFilter * Add history to readme * Fixing Linting * Fixing format * Remove ResultFormat default
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Latest improvements:
### Contribution checklist: - [ ] I have reviewed the [documentation](https://github.com/Azure/adx-documentation-pr/wiki/Overall-basic-flow) for the workflow. - [ ] [Validation tools](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/swagger-checklist.md#validation-tools-for-swagger-checklist) were run on swagger spec(s) and have all been fixed in this PR. - [x] The [OpenAPI Hub](https://aka.ms/openapiportal) was used for checking validation status and next steps. ### ARM API Review Checklist - [ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories. - adding/removing APIs. - adding/removing properties. - adding/removing API-version. - adding a new service in Azure.
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.